Re: [kvm-devel] [PATCH 3/3] KVM - add hypercall nr to kvm_run

2007-07-18 Thread Jeff Dike
On Wed, Jul 18, 2007 at 11:28:18AM -0500, Anthony Liguori wrote: Within the kernel right (VMCALL is only usable in ring 1). Yup. Is it terribly important to be able to pass through the syscall arguments in registers verses packing them in a data structure and passing a pointer to that

Re: [kvm-devel] [PATCH 3/3] KVM - add hypercall nr to kvm_run

2007-07-17 Thread Jeff Dike
On Tue, Jul 17, 2007 at 09:15:51AM -0500, Anthony Liguori wrote: I'm planning on breaking this interface again since the new hypercall API only takes 4 arguments instead of 6. Is anything written anywhere about this hypercall interface? The thing which would make me happy (which the current

[kvm-devel] [PATCH 3/3] KVM - add hypercall nr to kvm_run

2007-07-16 Thread Jeff Dike
Add the hypercall number to kvm_run and initialize it. This might be considered API-changing, so I kept it separate. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- drivers/kvm/kvm_main.c |1 + include/linux/kvm.h|1 + 2 files changed, 2 insertions(+) Index: kvm/drivers/kvm

[kvm-devel] [PATCH 1/3] KVM - Add missing kvm_run initializations

2007-07-16 Thread Jeff Dike
initializations of hardware_exit_reason with KVM_EXIT_UNKNOWN, so I added those. One case had exit_reason = 0, which I changed to KVM_EXIT_UNKNOWN. I did a pass over all of the return 0 paths in the exit handler callbacks, so this should cover everything. Signed-off-by: Jeff Dike [EMAIL PROTECTED

[kvm-devel] [PATCH] KVM - Fix rmode_tss_base declaration

2007-06-06 Thread Jeff Dike
The long return value of rmode_tss_base is truncated by its declared return type of int. Signed-off-by: Jeff Dike [EMAIL PROTECTED] -- drivers/kvm/vmx.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: kvm/drivers/kvm/vmx.c