Re: [kvm-devel] regression breaks lowmem reserved RAM

2008-04-01 Thread Jens Axboe
code). Signed-off-by: Andrea Arcangeli [EMAIL PROTECTED] Thanks Andrea, this looks much saner! -- Jens Axboe - Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about

Re: [kvm-devel] [PATCH 4/6] virtio block driver

2007-09-21 Thread Jens Axboe
On Fri, Sep 21 2007, Rusty Russell wrote: On Thu, 2007-09-20 at 15:05 +0200, Jens Axboe wrote: On Thu, Sep 20 2007, Rusty Russell wrote: +static void end_dequeued_request(struct request *req, + struct request_queue *q, int uptodate) +{ + /* And so

Re: [kvm-devel] [PATCH 4/6] virtio block driver

2007-09-21 Thread Jens Axboe
On Fri, Sep 21 2007, Rusty Russell wrote: On Thu, 2007-09-20 at 14:27 +0200, Jens Axboe wrote: On Thu, Sep 20 2007, Rusty Russell wrote: The block driver uses scatter-gather lists with sg[0] being the request information (struct virtio_blk_outhdr) with the type, sector and inbuf id

Re: [kvm-devel] [PATCH 4/6] virtio block driver

2007-09-20 Thread Jens Axboe
(struct request *, int); extern void end_queued_request(struct request *, int); +extern void end_dequeued_request(struct request *, int); extern void blk_complete_request(struct request *); /* -- Jens Axboe - This SF.net

Re: [kvm-devel] More virtio users

2007-06-12 Thread Jens Axboe
On Mon, Jun 11 2007, Rusty Russell wrote: On Mon, 2007-06-11 at 08:41 +0200, Jens Axboe wrote: On Sun, Jun 10 2007, Rusty Russell wrote: On Sun, 2007-06-10 at 11:16 +0300, Avi Kivity wrote: Rusty Russell wrote: Lguest doesn't have a framebuffer, so maybe this is a good thing

Re: [kvm-devel] More virtio users

2007-06-12 Thread Jens Axboe
On Tue, Jun 12 2007, Rusty Russell wrote: On Mon, 2007-06-11 at 09:33 +0200, Jens Axboe wrote: On Mon, Jun 11 2007, Rusty Russell wrote: So the problem is that I'd like to handle all of them, but I'm not clear what requests my device can get. I can't see a source of any other type

Re: [kvm-devel] [PATCH RFC 3/3] virtio infrastructure: example block driver

2007-06-04 Thread Jens Axboe
On Mon, Jun 04 2007, Carsten Otte wrote: Jens Axboe wrote: On Fri, Jun 01 2007, Carsten Otte wrote: With regard to compute power needed, almost none. The penalty is latency, not overhead: A small request may sit on the request queue to wait for other work to arrive until the queue gets

Re: [kvm-devel] [PATCH RFC 3/3] virtio infrastructure: example block driver

2007-06-04 Thread Jens Axboe
On Mon, Jun 04 2007, Rusty Russell wrote: On Mon, 2007-06-04 at 15:43 +0200, Jens Axboe wrote: On Mon, Jun 04 2007, Carsten Otte wrote: Jens Axboe wrote: On Fri, Jun 01 2007, Carsten Otte wrote: With regard to compute power needed, almost none. The penalty is latency, not overhead

Re: [kvm-devel] [PATCH RFC 3/3] virtio infrastructure: example block driver

2007-06-04 Thread Jens Axboe
On Mon, Jun 04 2007, Carsten Otte wrote: Jens Axboe wrote: Most people should not fiddle with it, the defaults are there for good reason. I can provide a blk_queue_unplug_thresholds(q, depth, delay) helper that you could use for the virtualized drivers, perhaps that would be better

Re: [kvm-devel] [PATCH RFC 3/3] virtio infrastructure: example block driver

2007-06-01 Thread Jens Axboe
another one. Performance was a nightmare, so we discontinued pursuing that idea. I'd greatly prefer maintaing a request_fn interface for this. The make_request_fn/request_fn call ratio is at least 1, and typically a lot larger (4kb blocks, 128kb request not uncommon - 32). -- Jens Axboe