Hi,
Iain Kyte wrote:
> What has made the KVM-13 stop working with Linux 2.6.20 kvm and kvm-intel?
>
API has been modified.
As said Avi in kvm-13 release note : "if you use the modules from Linux 2.6.20,
you need to use kvm-12".
You can also apply attached patch on linux-2.6.20 source tree (i
On Fri, 09 Feb 2007 10:54:53 +0100
> Laurent Vivier <[EMAIL PROTECTED]> wrote:
>
> > Iain Kyte wrote:
> > > What has made the KVM-13 stop working with Linux 2.6.20 kvm and
> > > kvm-intel?
> >
> > API has been modified.
> >
> > As sa
Avi Kivity wrote:
> Muli Ben-Yehuda wrote:
>> On Wed, Feb 14, 2007 at 10:25:46AM +0200, Avi Kivity wrote:
>>
>>> Muli Ben-Yehuda wrote:
>>>
On Wed, Feb 14, 2007 at 09:57:13AM +0200, Avi Kivity wrote:
> kvm: revert r4386
>
> causes breakage, as well as usi
Avi Kivity wrote:
> Aurelien Jarno wrote:
>>
>>> What is your disk image file format, or are you using a partition?
>>>
>> I am using a raw image file on an ext3 partition.
>>
>>
>>> Do the results change (on kvm-14) if you pin the guest to a core with
>>> 'taskset 1 qemu ...'
>>>
Anthony Liguori wrote:
> Laurent Vivier wrote:
>> Avi Kivity wrote:
>>
>>> Aurelien Jarno wrote:
>>>
>>>>
>>>>
>>>>> What is your disk image file format, or are you using a partition?
>>
Anthony Liguori wrote:
> Laurent Vivier wrote:
>> Avi Kivity wrote:
>>
>>> Aurelien Jarno wrote:
>>>
>>>>
>>>>
>>>>> What is your disk image file format, or are you using a partition?
>>
Aurelien Jarno wrote:
> Laurent Vivier a écrit :
>> Anthony Liguori wrote:
>>> Laurent Vivier wrote:
>>>> Avi Kivity wrote:
>>>>
>>>>> Aurelien Jarno wrote:
>>>>>
>>>>>>
Avi Kivity wrote:
> Laurent Vivier wrote:
>>
>>> Would it be possible to merge the kvm part, and maybe to send it to the
>>> qemu mailing list?
>>>
>>
>> I can try to send it to qemu mailing list but I think it is not useful
>> for pure
Anthony Liguori wrote:
> Avi Kivity wrote:
>> Anthony Liguori wrote:
>>> Avi Kivity wrote:
>>>> Laurent Vivier wrote:
>>>>> There are remaining issues : libposix-aio uses kernel AIO, so files
>>>>> must be
>>>>> opened
Avi Kivity wrote:
> Michael Riepe wrote:
>> Hi!
>>
>> This is just a (probably silly) idea I had the other day. Currently, the
>> guest's memory is allocated inside the kernel and exported to userspace
>> via mmap(). But wouldn't it also be possible to create a file in
>> userspace and pass its des
Avi Kivity wrote:
> Regular readers of this column will not be surprised to hear that kvm-25
> is much faster than earlier versions.
>
> Changes since kvm-24:
> - massive performance increase (Eddie Dong)
> - regenerate bios from latest bochs sources, hopefully fixing a
> regression with some gues
Hi,
I made some benchmarks with dbench on linux/KVM.
IDE means I use an image disk with "-hda"
SCSI means I use an image disk with "-sda"
(see the patch I proposed on qemu list:
http://www.mail-archive.com/[EMAIL PROTECTED]/msg08679.html )
threads KVM-21 KVM-21 KVM-24 KVM-24 KVM-25 KVM-25
Anthony Liguori wrote:
> Laurent Vivier wrote:
>> Hi,
>>
>> I made some benchmarks with dbench on linux/KVM.
>>
>> IDE means I use an image disk with "-hda"
>> SCSI means I use an image disk with "-sda"
>> (see the patch I propo
Anthony Liguori wrote:
> Laurent Vivier wrote:
>> Anthony Liguori wrote:
>> Hi Anthony,
>>
>> I didn't modify aio_init limit...
>>
>
> It would be pretty useful to give it a try. In qemu_aio_init() where
> aio_init() get's called. If yo
Benjamin Budts wrote:
> Gregory Haskins wrote:
>> On Tue, 2007-07-03 at 11:43 +0200, Benjamin Budts wrote:
>>
>>> 3* When I specify a mac address for my debian virtual machine eth0
>>> changes to eth3 ... very very weird... it's not that bad, i just changed
>>> my interfaces config file from e
Benjamin Budts wrote:
[snip]
> 1* When i run hdparm -t /dev/sda1 I have 80-85Mbit/s read speed on my
> guest os (debian etch)
>
> If I run it ''in'' a virtual machine (using also debian Etch with
> 2.6.21.5 kernel) I get : 28-35Mbits...
>
> I even tried to put the image on a seperate disk to be
.kvm.devel/3373
> thx a lot
>
> Laurent Vivier wrote:
>> Benjamin Budts wrote:
>> [snip]
>>
>>> 1* When i run hdparm -t /dev/sda1 I have 80-85Mbit/s read speed on my
>>> guest os (debian etch)
>>>
>>> If I run it ''in&
: cmpxchg_emulated-vcpu, emulator_cmpxchr_emulated() uses struct
kvm_vcpu instead of x86_emulate_ctxt to be consistency with other memops.
Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]>
--
- [EMAIL PROTECTED] --
"Software is hard" - Donald Knuth
signature
emulator_write_emulated() uses struct kvm_vcpu instead of x86_emulate_ctxt to be
called in place of kvm_write_guest().
Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]>
--
- [EMAIL PROTECTED] --
"Software is hard" - Donald Knuth
Index:
remove kvm_read_guest() and use emulator_read_std() instead.
Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]>
--
- [EMAIL PROTECTED] --
"Software is hard" - Donald Knuth
Index: kvm/d
remove kvm_write_guest() and use emulator_write_emulated() instead.
Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]>
--
- [EMAIL PROTECTED] --
"Software is hard" - Donald Knuth
Index: kvm/d
emulator_cmpxchr_emulated() uses struct kvm_vcpu instead of x86_emulate_ctxt to
be consistency with other memops.
Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]>
--
- [EMAIL PROTECTED] --
"Software is hard" - Donald Knuth
Index: kvm/driver
emulator_read_std() uses struct kvm_vcpu instead of x86_emulate_ctxt to be
called in place of kvm_read_guest().
Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]>
--
- [EMAIL PROTECTED] --
"Software is hard" - Donald Knuth
Index: kvm/driver
emulator_read_emulated() uses struct kvm_vcpu instead of x86_emulate_ctxt to be
consistency with emulator_read_std().
Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]>
--
- [EMAIL PROTECTED] --
"Software is hard" - Donald Knuth
Index: kvm/driver
Avi Kivity wrote:
> Laurent Vivier wrote:
>> From the TODO, this serie of patch is trying to consolidate the various
>> functions that read and write guest memory.
>> We remove kvm_read_guest() and kvm_write_guest(), and we use instead
>> emulator_read_std()
I think line 1809 of kvm_main.c (from git) is useless, isn't it ???
1809 now = min(count, PAGE_SIZE / size);
1810
1811 if (!down)
1812 in_page = PAGE_SIZE - offset_in_page(address);
1813 else
1814 in_page = offset_in_page(address) + size;
181
Jorge Lucángeli Obes wrote:
[...]
> Laurent, do you want the patches for the functionality that's working
> right now? We can divide the (not very big amount of) work that's
> left. It consists basically on teaching qemu how to look for command
> line options, if none are present on the current inv
To be able to extract easily prefix decoding from x86_emulate_memop(), group all
prefix decoding results in a structure called x86_prefix.
Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]>
--
- [EMAIL PROTECTED] --
"Software is hard" - Donald
Extract prefix decoding part from x86_emulate_memop() to x86_decode_prefix().
Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]>
--
- [EMAIL PROTECTED] --
"Software is hard" - Donald Knuth
Index: kvm/drivers/k
vmx.c uses x86_decode_prefix() instead of get_io_count().
Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]>
--
- [EMAIL PROTECTED] --
"Software is hard" - Donald Knuth
Index: kvm/d
To be able to extract easily prefix decoding from x86_emulate_memop(), change
ctxt.*_base to an array ctxt.base[X86EMUL_BASE_*]
Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]>
--
- [EMAIL PROTECTED] --
"Software is hard" - Donald Knuth
Index:
svm.c uses x86_decode_prefix() instead of io_address() and io_get_override().
*** WARNING: the SVM part has not been tested because I don't have any AMD
system. ***
Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]>
--
- [EMAIL PROTECTED] --
"
[PATCH 0/5] Consolidate the insb/outsb emulation into x86_emulate.c
From the TODO, this serie of patches consolidates the insb/outsb emulation into
x86_emulate.c.
The prefix decoding part is extracted from x86_emulate_memop() and a function
called x86_decode_prefix() is created.
Then, in vmx.c, h
;
1815 now = min(count, (unsigned long)in_page / size);
1816 if (!now) {
Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]>
--
- [EMAIL PROTECTED] --
"Software is hard" - Donald Knuth
Index: kvm/driver
Avi Kivity wrote:
> Laurent Vivier wrote:
>> vmx.c uses x86_decode_prefix() instead of get_io_count().
>>
>>static int handle_io(struct kvm_vcpu *vcpu, struct kvm_run *kvm_run)
>> {
>> u64 exit_qualification;
>> @@ -1831,8 +1780,32 @@
Avi Kivity wrote:
> Laurent Vivier wrote:
>>>
>>> How about just calliing emulate_instruction() from here (just for the
>>> string case)? That will eliminate all the setup code.
>>>
>>
>> But this setup is in emulate_instruction() so it will
Dong, Eddie wrote:
> [EMAIL PROTECTED] wrote:
>> Laurent Vivier wrote:
>>> Dong, Eddie wrote:
>>>> [EMAIL PROTECTED] wrote:
>>>>> PATCH 2/2] setup_pio-cleanup, some cleanup, split
>>>>> kvm_setup_pio() in two
>>>>> functi
Laurent Vivier wrote:
> Dong, Eddie wrote:
>> [EMAIL PROTECTED] wrote:
>>>>> I may confuse you. Currently master doesn't do in kernel PIO
>>>>> emulation, all string PIO will go to user level which is fine. With
>>>>> lapic3, we have k
Dong, Eddie wrote:
>>> I may confuse you. Currently master doesn't do in kernel PIO
>>> emulation, all string PIO will go to user level which is fine. With
>>> lapic3, we have kernel PIO emulation for PIC. Linux doesn;t use
>>> string PIO for PIC (port 0x20/0x21) but XP and Win2003 does. So can
>>
Dong, Eddie wrote:
> [EMAIL PROTECTED] wrote:
I may confuse you. Currently master doesn't do in kernel PIO
emulation, all string PIO will go to user level which is fine. With
lapic3, we have kernel PIO emulation for PIC. Linux doesn;t use
string PIO for PIC (port 0x20/0x21) but
PATCH 2/2] setup_pio-cleanup, some cleanup, split kvm_setup_pio() in two
functions, one to setup in/out pio (kvm_emulate_pio()) and one to setup ins/outs
pio (kvm_emulate_pio_string()).
Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]>
--
- [EMAIL PRO
has not been tested...
Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]>
--
- [EMAIL PROTECTED] --
"Software is hard" - Donald Knuth
signature.asc
Description: OpenPGP d
for me, AMD part has not been tested...
Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]>
--
- [EMAIL PROTECTED] --
"Software is hard" - Donald Knuth
Index: kvm/driver
Dong, Eddie wrote:
> [EMAIL PROTECTED] wrote:
>> PATCH 2/2] setup_pio-cleanup, some cleanup, split
>> kvm_setup_pio() in two
>> functions, one to setup in/out pio (kvm_emulate_pio()) and one to
>> setup ins/outs pio (kvm_emulate_pio_string()).
>>
> Did u try on lapic3 branch with XP guest? Only win
Anthony Liguori wrote:
> Avi Kivity wrote:
>> Anthony Liguori wrote:
>>
>>> I don't think adding annotations as snapshots is the right approach. I
>>> think proper support should be added in the header. I wouldn't be too
>>> concerned with breaking compatibility in qcow2. That's why it's qc
introduce a new field, "guest", in cpustat to store the time used by the CPU to
run virtual CPU. Modify /proc/stat to display this new field.
Signed-Off-by: Laurent Vivier <[EMAIL PROTECTED]>
--
- [EMAIL PROTECTED] --
"Software is hard&
d user to allow an unmodified
"top(1)" to display correct value. A modified "top(1)" is able to display good
cpu user time and cpu guest time by subtracting cpu guest time from cpu user
time.
Signed-Off-by: Laurent Vivier <[EMAIL PROTECTED]>
You can find attached to this email the patch to apply to procps-3.2.7[1] to
allow "top(1)" to display the cpu guest time.
Laurent
[1] http://procps.sf.net/procps-3.2.7.tar.gz
--
- [EMAIL PROTECTED] --
"Software is hard" - Donald Knuth
Index: procps-3.2.7/top.c
e duplicate VCPU time between guest and user to
allow an unmodified "top(1)" to display correct value. A modified "top(1)" is
able to display good cpu user time and cpu guest time by subtracting cpu guest
time from cpu user time.
Signed-Off-by: Laurent Vivier <[
Avi Kivity wrote:
> Laurent Vivier wrote:
>> The aim of these two patches is to measure the CPU time used by a virtual
>> machine. All comments are welcome... I'm not sure it's the good way to
>> do that.
>>
>> [PATCH 1/2] introduce a new field, "
Avi Kivity wrote:
> Jorge Lucángeli Obes wrote:
My feeling is that config files are outdated. When used with a gui,
you end up writing silly parsers and stuff and still wrecking things
horribly when the the gui writer's expectations don't match reality.
When used without a gui,
Avi Kivity wrote:
> Laurent Vivier wrote:
>>> - perhaps the new fields should be guarded by a #ifdef CONFIG_HYPERVISOR
>>> (selected by CONFIG_KVM)? that way the (minor) additional overhead is
>>> only incurred if it can possibly be used. I imagine that our cani
Christian Borntraeger wrote:
> Am Freitag, 10. August 2007 schrieb Laurent Vivier:
>> The aim of these two patches is to measure the CPU time used by a virtual
>> machine. All comments are welcome... I'm not sure it's the good way to do
> that.
>
> I did
Avi Kivity wrote:
> Laurent Vivier wrote:
>> Christian Borntraeger wrote:
>>
>>> Am Freitag, 10. August 2007 schrieb Laurent Vivier:
>>>
>>>> The aim of these two patches is to measure the CPU time used by a
>>>> virtual
>>>
Christian Borntraeger wrote:
> Am Montag, 13. August 2007 schrieb Laurent Vivier:
>>>> As guest accounting is hw dependent, I think we should add a hook in the
>>>> accounting functions.
>>>>
>>> Isn't PF_VM exactly such a hook? All the hy
Thiemo Seufer wrote:
> Jorge Lucángeli Obes wrote:
> [snip]
>> When I read Avi's TODO, I basically thought about getting rid of the
>> long command lines I had to store in scripts. I wanted to write that
>> command line once, and then forgetting about it, until I needed to
>> change it.
>
> Instea
Markus Hitter wrote:
>
> Am 13.08.2007 um 11:19 schrieb Laurent Vivier:
>
>> We can modify qemu to test if the argument is a directory, if yes, it
>> reads args
>> from file args in this directory and for security the disk image must
>> be in the
>> same
Modify KVM to use the "account modifiers". KVM can now measure time
consumed by a Virtual Machine on a per-cpu basis and modify kernel statistics to
report this value.
Signed-off-by: Laurent Vivier <[EMAIL PROT
[PATCH 1/4] as modern CPUs introduce a third running state, after "user" and
"system", we need a new field, "guest", in cpustat to store the time used by
the CPU to run virtual CPU. Modify /proc/stat to display this new field.
Signed-off-by: La
ons registered by a module to modify the
cputime value.
Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]>
--
- [EMAIL PROTECTED] --
"Software is hard" - Donald Knuth
Index: kvm/include/linux/sched.h
==
PATCH 2/4] like for cpustat, introduce the "guest" and "cguest" fields for the
tasks. Modify
signal_struct and task_struct. Modify /proc//stat to display these new
field
Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]>
--
- [EMAIL PROTECTED] ---
[PATCH 4/4] Modify KVM to use the "account modifiers". KVM can now measure time
consumed by a Virtual Machine on a per-cpu basis and modify kernel statistics to
report this value.
Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]>
--
-
Rusty Russell wrote:
> On Thu, 2007-08-16 at 17:58 +0200, Laurent Vivier wrote:
>> [PATCH 3/3] introduce "account modifiers" mechanism in the kernel allowing a
>> module to modify the collected accounting for a given task. This
>> implementation
>&
Rusty Russell wrote:
> On Fri, 2007-08-17 at 09:35 +0200, Laurent Vivier wrote:
>> Rusty Russell wrote:
>>> Hi Laurent,
>> Hi Rusty,
>> how are your puppies ?
>
> They're getting a little fat, actually. Too many features ...
>
>> - remove PATCH
This is another way to compute guest time... I remove the "account modifiers"
mechanism and call directly account_guest_time() from account_system_time().
account_system_time() computes user, system and guest times according value
accumulated in vtime (a ktime_t) in task_struct by the virtual machi
KVM updates vtime in task_struct to allow account_guest_time() to modify user,
system and guest time in cpustat accordingly.
Index: kvm/drivers/kvm/Kconfig
===
--- kvm.orig/drivers/kvm/Kconfig2007-08-17 10:24:46.0 +0200
Avi Kivity wrote:
> Laurent Vivier wrote:
>>>
>>>> - remove PATCH 3, and add in task_struct a "ktime vtime" where we
>>>> accumulate
>>>> guest time (by calling something like guest_enter() and guest_exit() from
>>>> the
Avi Kivity wrote:
> Laurent Vivier wrote:
>> KVM updates vtime in task_struct to allow account_guest_time() to modify
>> user,
>> system and guest time in cpustat accordingly.
>>
>
>> --- kvm.orig/drivers/kvm/Kconfig 2007-08-17 10:24:46.0 +0200
Avi Kivity wrote:
[...]
>
> The normal user/system accounting has the same issue, no? Whereever we
> happen to land (kernel or user) gets the whole tick.
>
> So I think it is okay to have the same limitation for guest time.
>
So this is how it looks like.
PATCH 1 and 2 are always a prerequisit
Avi Kivity wrote:
> Laurent Vivier wrote:
>> Avi Kivity wrote:
>> [...]
>>
>>> The normal user/system accounting has the same issue, no? Whereever we
>>> happen to land (kernel or user) gets the whole tick.
>>>
>>> So I th
time. Update "gtime" and "cgtime" in signal_struct and
task_struct accordingly.
[PATCH 4/4] Modify KVM to update guest time accounting.
Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]>
--
- [EMAIL PROTECTED] --
"Software is hard&q
guest and user to
allow an unmodified "top(1)" to display correct value. A modified "top(1)" is
able to display good cpu user time and cpu guest time by subtracting cpu guest
time from cpu user time. Update "gtime" in task_struct accordingly.
Signed-o
[PATCH 1/4] as recent CPUs introduce a third running state, after "user" and
"system", we need a new field, "guest", in cpustat to store the time used by
the CPU to run virtual CPU. Modify /proc/stat to display this new field.
Signed-off-by: La
[PATCH 4/4] Modify KVM to update guest time accounting.
Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]>
--
- [EMAIL PROTECTED] --
"Software is hard" - Donald Knuth
Index: kvm/d
[PATCH 2/4] like for cpustat, introduce the "gtime" (guest time of the task) and
"cgtime" (guest time of the task children) fields for the
tasks. Modify signal_struct and task_struct. Modify /proc//stat to display
these new fields.
Signed-off-by: Laurent Vivi
Avi Kivity wrote:
> Laurent Vivier wrote:
>> [PATCH 4/4] Modify KVM to update guest time accounting.
>>
>>
>
>> Index: kvm/drivers/kvm/kvm.h
>> ===
>> --- kvm.orig/drivers/kvm/kv
Christian Borntraeger wrote:
> Am Montag, 20. August 2007 schrieb Laurent Vivier:
>> Index: kvm/fs/proc/array.c
>> ===
>> --- kvm.orig/fs/proc/array.c2007-08-20 11:11:30.0 +0200
>> +++ kvm/fs/pr
Avi Kivity wrote:
> Laurent Vivier wrote:
>> Avi Kivity wrote:
>>
>>> Laurent Vivier wrote:
>>>
>>>> [PATCH 4/4] Modify KVM to update guest time accounting.
>>>&
Hi John,
John Stoffel wrote:
>
> Laurent> The aim of these four patches is to introduce Virtual Machine
> Laurent> time accounting.
>
> So what does this buy us? What increased functionality?
>
functionnalities:
- allow to measure time spent by a CPU in a virtual CPU.
- allow to display in
> Laurent Vivier wrote:
> functionnalities:
>
> > - allow to measure time spent by a CPU in a virtual CPU.
> > - allow to display in /proc/state this value by CPU
> > - allow to display in /proc//state this value by process
> > - allow KVM to use these 3 pre
Glauber de Oliveira Costa wrote:
>> by doing this at kernel level, we can:
>> - measure exactly the guest time,
>> - move this part of system time to user time (as you think it should be
>> user time),
>> - have consistency between system, user and guest time,
>> - report values in /proc/state and
It is from the TODO and I hope no one is already working on this.
'vmx_load_host_state() bundles fs, gs, ldt, and tss reloading into one in the
hope that it is infrequent. With smp guests, fs reloading is frequent and the
separate reloads should be unbundled.'
Signed-off-by: Laur
Avi Kivity wrote:
> Laurent Vivier wrote:
>> It is from the TODO and I hope no one is already working on this.
>>
>> 'vmx_load_host_state() bundles fs, gs, ldt, and tss reloading into one in the
>> hope that it is infrequent. With smp guests, fs reloading is freq
From KVM/TODO:
vmx_load_host_state() bundles fs, gs, ldt, and tss reloading into
one in the hope that it is infrequent. With smp guests, fs reloading is
frequent and the separate reloads should be unbundled.
Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]>
Index: kvm/drivers/kvm
Christian Ehrhardt wrote:
> +config KVM_POWERPC_440
> +tristate "KVM for embedded PowerPC 440 cores"
> +depends on KVM && POWERPC
> +---help---
> + Provides support for KVM on embedded PowerPC 440 cores
> +
> +config KVM_POWERPC_E500
> +tristate "KVM for embedded PowerPC e500 c
we exit from kvm module. Call x86_decode_insn() only
when needed. Modify x86_emulate_insn() to not modify the context if
it must be re-entered.
Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]>
--
- [EMAIL PROTECTED] --
"Softw
Remove #ifdef functions never used
Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]>
Index: kvm/drivers/kvm/x86_emulate.c
===
--- kvm.orig/drivers/kvm/x86_emulate.c 2007-08-27 10:55:05.0 +0200
+++ kvm/drive
;
u8 modrm_mod;
u8 modrm_reg;
u8 modrm_rm;
u8 use_modrm_ea;
unsigned long modrm_ea;
unsigned long modrm_val;
};
Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]>
Index: kvm/drive
move all decoding process to function x86_decode_insn().
Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]>
Index: kvm/drivers/kvm/x86_emulate.c
===
--- kvm.orig/drivers/kvm/x86_emulate.c 2007-08-29 18:04:53.0 +0200
+
emulate_instruction() calls now x86_decode_insn() and x86_emulate_insn().
x86_emulate_insn() is x86_emulate_memop() without the decoding part.
Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]>
Index: kvm/drivers/kvm/kvm_
move emulate_ctxt to kvm_vcpu to keep emulate context when we exit from kvm
module. Call x86_decode_insn() only when needed. Modify x86_emulate_insn() to
not modify the context if it must be re-entered.
Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]>
Index: kvm/drivers/kvm
Laurent Vivier wrote:
> Index: kvm/drivers/kvm/kvm.h
> @@ -1860,7 +1869,7 @@ static int kvm_vcpu_ioctl_run(struct kvm
> vcpu->mmio_read_completed = 1;
> vcpu->mmio_needed = 0;
> r = emulate_inst
fig_version.
Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]>
Index: kvm/drivers/kvm/kvm.h
===
--- kvm.orig/drivers/kvm/kvm.h 2007-08-30 13:40:10.0 +0200
+++ kvm/drivers/kvm/kvm.h 2007-08-30 13:40:13.0 +0200
Hi Anthony,
I think passing only the directory name is better because it can be like a
"black box" : the user don't have to know how it is inside. And it is much
more simple to use "qemu my_pc" than "qemu -c my_pc/config".
Regards,
Laurent
--
> Hi,
>
> On Fri, 31 Aug 2007, [EMAIL PROTECTED] wrote:
>
> > I think passing only the directory name is better because it can be
like
> > a "black box" : the user don't have to know how it is inside.
>
> I consider this a super downside.
>
> "If you think your users are idiots, only idiots will u
Anthony Liguori wrote:
> On Fri, 2007-08-31 at 22:13 +0200, [EMAIL PROTECTED] wrote:
>> Hi Anthony,
>>
>> I think passing only the directory name is better because it can be like a
>> "black box" : the user don't have to know how it is inside. And it is much
>> more simple to use "qemu my_pc" than
Avi Kivity wrote:
> Nitin A Kamble wrote:
>> Hi Avi,
>> Attached is the patch to implement the push imm8 instruction opcode
>> 0x6a.
>>
>> Please apply or comment.
>>
>>
>
> The patches look good, but I am holding on right now because of the
> emulator split. If that is not merged in the ne
Avi Kivity wrote:
> Laurent Vivier wrote:
>> These patches split the emulator in two parts: one to decode the
>> instruction,
>> the other to execute it. The decode part is then called only when needed.
>>
>>
>
> Patchset looks good, but fails booting FC
Avi Kivity wrote:
> Laurent Vivier wrote:
>> These patches split the emulator in two parts: one to decode the
>> instruction,
>> the other to execute it. The decode part is then called only when needed.
>>
>>
>
> Patchset looks good, but fails booting FC
Avi Kivity wrote:
> Laurent Vivier wrote:
>> Avi Kivity wrote:
>>
>>> Laurent Vivier wrote:
>>>
>>>> These patches split the emulator in two parts: one to decode the
>>>> instruction,
>>>> the
1 - 100 of 224 matches
Mail list logo
