Re: [kvm-devel] [Disscussion] Moving x86 code out of kvm.h

2007-11-15 Thread Avi Kivity
Zhang, Xiantao wrote: > Jerone Young wrote: > >> This is a continuation of a conversation I have been having with Izik >> Eidus on IRC today. >> >> I plan on moving x86 code out of kvm.h and into kvm-x86.h. kvm-x86.h >> would then include kvm.h and would be included by files like svm.c >> instea

Re: [kvm-devel] [Disscussion] Moving x86 code out of kvm.h

2007-11-15 Thread Jerone Young
On Thu, 2007-11-15 at 10:34 +0200, Avi Kivity wrote: > Jerone Young wrote: > > This is a continuation of a conversation I have been having with Izik > > Eidus on IRC today. > > > > I plan on moving x86 code out of kvm.h and into kvm-x86.h. kvm-x86.h > > would then include kvm.h and would be includ

Re: [kvm-devel] [Disscussion] Moving x86 code out of kvm.h

2007-11-15 Thread Avi Kivity
Zhang, Xiantao wrote: >>> For driver/kvm/kvm.h, I have a proposal before in mailing list. In >>> my proposal, we can split x86-specific code of kvm.h into current >>> x86.h, and make code in kvm.h as common. Then, we rename kvm.h to >>> kvm_comm.h, and also rename x86.h to kvm-x86.h, and meantime

Re: [kvm-devel] [Disscussion] Moving x86 code out of kvm.h

2007-11-15 Thread Zhang, Xiantao
Avi Kivity wrote: > Zhang, Xiantao wrote: >> Jerone Young wrote: >> >>> This is a continuation of a conversation I have been having with >>> Izik Eidus on IRC today. >>> >>> I plan on moving x86 code out of kvm.h and into kvm-x86.h. kvm-x86.h >>> would then include kvm.h and would be included by

Re: [kvm-devel] [Disscussion] Moving x86 code out of kvm.h

2007-11-15 Thread Zhang, Xiantao
Avi Kivity wrote: > Zhang, Xiantao wrote: For driver/kvm/kvm.h, I have a proposal before in mailing list. In my proposal, we can split x86-specific code of kvm.h into current x86.h, and make code in kvm.h as common. Then, we rename kvm.h to kvm_comm.h, and also rename x86.h to

[kvm-devel] [Disscussion] Moving x86 code out of kvm.h

2007-11-15 Thread Jerone Young
This is a continuation of a conversation I have been having with Izik Eidus on IRC today. I plan on moving x86 code out of kvm.h and into kvm-x86.h. kvm-x86.h would then include kvm.h and would be included by files like svm.c instead of kvm.h. Izik pointed out a big issue with this approach and

Re: [kvm-devel] [Disscussion] Moving x86 code out of kvm.h

2007-11-15 Thread Zhang, Xiantao
Jerone Young wrote: > This is a continuation of a conversation I have been having with Izik > Eidus on IRC today. > > I plan on moving x86 code out of kvm.h and into kvm-x86.h. kvm-x86.h > would then include kvm.h and would be included by files like svm.c > instead of kvm.h. I assume you are talk

Re: [kvm-devel] [Disscussion] Moving x86 code out of kvm.h

2007-11-15 Thread Avi Kivity
Izik Eidus wrote: >>> >>> >> Have kvm.h include >> > what you mean by that? > > include/asm is a symlink to include/asm-$arch, and this is where arch-specific definitions are placed in Linux. -- Do not meddle in the internals of kernels, for they are subtle and quick to pani

Re: [kvm-devel] [Disscussion] Moving x86 code out of kvm.h

2007-11-15 Thread Izik Eidus
On Thu, 2007-11-15 at 10:34 +0200, Avi Kivity wrote: > Jerone Young wrote: > > This is a continuation of a conversation I have been having with Izik > > Eidus on IRC today. > > > > I plan on moving x86 code out of kvm.h and into kvm-x86.h. kvm-x86.h > > would then include kvm.h and would be includ

Re: [kvm-devel] [Disscussion] Moving x86 code out of kvm.h

2007-11-15 Thread Avi Kivity
Jerone Young wrote: > This is a continuation of a conversation I have been having with Izik > Eidus on IRC today. > > I plan on moving x86 code out of kvm.h and into kvm-x86.h. kvm-x86.h > would then include kvm.h and would be included by files like svm.c > instead of kvm.h. > > Which kvm.h ar