Re: [kvm-devel] [PATCH] lighweight VM Exit

2007-05-17 Thread Avi Kivity
Avi Kivity wrote: > Dong, Eddie wrote: >> Avi Kivity wrote: >> Here it is. >>> It's broken; your binutils is probably too old. >>> >>> >>> Can u also send me your bootstrap and flat so that I can try here? Thx,eddie >> Avi: >> Using yout vmexit.

Re: [kvm-devel] [PATCH] lighweight VM Exit

2007-05-17 Thread Avi Kivity
Dong, Eddie wrote: > Avi Kivity wrote: > >>> Here it is. >>> >>> >> It's broken; your binutils is probably too old. >> >> >> >>> Can u also send me your bootstrap and flat so that I can try here? >>> Thx,eddie >>> > Avi: > Using yout vmexit.flat, it can work with my patc

Re: [kvm-devel] [PATCH] lighweight VM Exit

2007-05-17 Thread Dong, Eddie
Avi Kivity wrote: >> Here it is. >> > > It's broken; your binutils is probably too old. > > >> Can u also send me your bootstrap and flat so that I can try here? >> Thx,eddie > Avi: Using yout vmexit.flat, it can work with my patch smoothly. Is this the one you see problems? Fr

Re: [kvm-devel] [PATCH] lighweight VM Exit

2007-05-16 Thread Avi Kivity
Dong, Eddie wrote: > Avi Kivity wrote: > >> This looks nicer, however I get an oops on fxrstor in >> kvm_load_guest_fpu(), when running user/test/vmexit.flat compiled for >> i386, on an x86_64 host. >> >> > Avi: > Per your guideline, I did following under kvm-userspace/user: >

Re: [kvm-devel] [PATCH] lighweight VM Exit

2007-05-16 Thread Dong, Eddie
Avi Kivity wrote: > > This looks nicer, however I get an oops on fxrstor in > kvm_load_guest_fpu(), when running user/test/vmexit.flat compiled for > i386, on an x86_64 host. > Avi: Per your guideline, I did following under kvm-userspace/user: 1: make test/bootstrap 2: ma

Re: [kvm-devel] [PATCH] lighweight VM Exit

2007-05-16 Thread Avi Kivity
Dong, Eddie wrote: > Alternative to swaping host/guest MSR entry array to avoid MSR bitmap. > More suggestions? > This looks nicer, however I get an oops on fxrstor in kvm_load_guest_fpu(), when running user/test/vmexit.flat compiled for i386, on an x86_64 host. Additionally: - please includ

Re: [kvm-devel] [PATCH] lighweight VM Exit

2007-05-15 Thread Dong, Eddie
Alternative to swaping host/guest MSR entry array to avoid MSR bitmap. More suggestions? thx,eddie Signed-off-by: Yaozu(Eddie) Dong [EMAIL PROTECTED] against ca76d209b88c344fc6a8eac17057c0088a3d6940. diff --git a/drivers/kvm/kvm.h b/drivers/kvm/kvm.h index 1bbafba..5f056d9 100644 --- a/driver

Re: [kvm-devel] [PATCH] lighweight VM Exit

2007-05-15 Thread Dong, Eddie
Avi Kivity wrote: > > You missed my comments regarding coding style. > Oo, I read the original mail too quickly and goes to bottom directly. Here is the update. BTW, vcpu->active_msr_list is not in this patch. I am working on another patch for MSR_EFER acceleration now which give me another 5-10

Re: [kvm-devel] [PATCH] lighweight VM Exit

2007-05-15 Thread Avi Kivity
Dong, Eddie wrote: > Avi Kivity wrote: > >> Why not use hardware autoloading? Is it slower than software? >> > > I believe HW is faster than SW, but the problem is that this kind of > save/restore is > only needed for heavy weight VM Exit in KVM. While HW doesn't provide an > easy > way t

Re: [kvm-devel] [PATCH] lighweight VM Exit

2007-05-14 Thread Dong, Eddie
Avi Kivity wrote: > Why not use hardware autoloading? Is it slower than software? I believe HW is faster than SW, but the problem is that this kind of save/restore is only needed for heavy weight VM Exit in KVM. While HW doesn't provide an easy way to bypass these MSR save/restore for light weig

Re: [kvm-devel] [PATCH] lighweight VM Exit

2007-05-14 Thread Christoph Hellwig
On Mon, May 14, 2007 at 06:14:31PM +0300, Avi Kivity wrote: > Dong, Eddie wrote: > > OK, how about this patch which further reduce the light weight VM Exit > > MSR save/restore? > > > > > > diff --git a/drivers/kvm/kvm_main.c b/drivers/kvm/kvm_main.c > > index 1288cff..ef96fae 100644 > > --- a/driv

Re: [kvm-devel] [PATCH] lighweight VM Exit

2007-05-14 Thread Avi Kivity
Dong, Eddie wrote: > OK, how about this patch which further reduce the light weight VM Exit > MSR save/restore? > > > diff --git a/drivers/kvm/kvm_main.c b/drivers/kvm/kvm_main.c > index 1288cff..ef96fae 100644 > --- a/drivers/kvm/kvm_main.c > +++ b/drivers/kvm/kvm_main.c > @@ -1596,6 +1596,30 @@ v

[kvm-devel] [PATCH] lighweight VM Exit (was:RE: guest state leak into host)

2007-05-14 Thread Dong, Eddie
Avi Kivity wrote: > > Some exit handlers (even the #PF handler) can sleep sometimes. They > call kvm_arch_ops->vcpu_put(), do some sleepy thing, then call > kvm_arch_ops->vcpu_load(). The changes in the commit make > sure that if > vcpu_put() is called, the lightweight exit is converted to a > h