Re: [kvm-devel] [PATCH] Enable memory mapped TPR shadow(FlexPriority)

2007-10-25 Thread Avi Kivity
Yang, Sheng wrote: >> >> Exporting an ioctl handler isn't very pretty. Izik is working on a >> patch that also requires an internal memory slot, so he will add an >> > API > >> for it. >> > > OK, that's my hope :-) > I will wait for that. > I've just merged and pushed that bit.

Re: [kvm-devel] [PATCH] Enable memory mapped TPR shadow(FlexPriority)

2007-10-24 Thread Avi Kivity
Yang, Sheng wrote: > I agreed, and interested in it. But I don't know if I have enough time > to do this. I can take this, but you may wait a little long time. :) > > Good, thanks. > BTW: I've checked the instructions which need decode operand. Your are > right, and to be exactly, that's two k

Re: [kvm-devel] [PATCH] Enable memory mapped TPR shadow(FlexPriority)

2007-10-24 Thread Yang, Sheng
Avi Kivity wrote: > Yang, Sheng wrote: Another thing, if we can use physical address as supplement of cr2 in emulate_instrcutions, that will be better. Any suggestion? >>> Sorry, I don't understand the question. >>> >>> I'd like to see cr2 completely removed from x86_emulate.

Re: [kvm-devel] [PATCH] Enable memory mapped TPR shadow(FlexPriority)

2007-10-24 Thread Izik Eidus
On Wed, 2007-10-24 at 10:55 +0800, Yang, Sheng wrote: > >From ac4dd1782b9f0f51e0c366a1b8db4515d6828df8 Mon Sep 17 00:00:00 2001 > From: Sheng Yang <[EMAIL PROTECTED]> > Date: Tue, 23 Oct 2007 12:34:42 +0800 > Subject: [PATCH] Enable memory mapped TPR shadow(FlexPriority) > > This patch based on CR

Re: [kvm-devel] [PATCH] Enable memory mapped TPR shadow(FlexPriority)

2007-10-24 Thread Avi Kivity
Yang, Sheng wrote: >>> Another thing, if we can use physical address as supplement of cr2 in >>> emulate_instrcutions, that will be better. Any suggestion? >>> >>> >> Sorry, I don't understand the question. >> >> I'd like to see cr2 completely removed from x86_emulate.c. >> > > Do you m

Re: [kvm-devel] [PATCH] Enable memory mapped TPR shadow(FlexPriority)

2007-10-24 Thread Yang, Sheng
Avi Kivity wrote: > Yang, Sheng wrote: >> Avi Kivity wrote: >> >>> Yang, Sheng wrote: >>> Another comment: I forgot if I answer the question on why eip should >> move >> backward. I did it because some instruction like "mov" will move eip >> to >> skip some dst/src op

Re: [kvm-devel] [PATCH] Enable memory mapped TPR shadow(FlexPriority)

2007-10-24 Thread Avi Kivity
Yang, Sheng wrote: > Avi Kivity wrote: > >> Yang, Sheng wrote: >> >>> Another comment: I forgot if I answer the question on why eip should >>> > move > >>> backward. I did it because some instruction like "mov" will move eip >>> > to > >>> skip some dst/src operand when

Re: [kvm-devel] [PATCH] Enable memory mapped TPR shadow(FlexPriority)

2007-10-24 Thread Yang, Sheng
Avi Kivity wrote: > Yang, Sheng wrote: >> Another comment: I forgot if I answer the question on why eip should move >> backward. I did it because some instruction like "mov" will move eip to >> skip some dst/src operand when executing, so eip should be kept for >> consistency. >> > > I think you

Re: [kvm-devel] [PATCH] Enable memory mapped TPR shadow(FlexPriority)

2007-10-24 Thread Yang, Sheng
Avi Kivity wrote: > Yang, Sheng wrote: >>> From ac4dd1782b9f0f51e0c366a1b8db4515d6828df8 Mon Sep 17 00:00:00 2001 >> From: Sheng Yang <[EMAIL PROTECTED]> >> Date: Tue, 23 Oct 2007 12:34:42 +0800 >> Subject: [PATCH] Enable memory mapped TPR shadow(FlexPriority) >> >> This patch based on CR8/TPR pat

Re: [kvm-devel] [PATCH] Enable memory mapped TPR shadow(FlexPriority)

2007-10-24 Thread Avi Kivity
Yang, Sheng wrote: > Another comment: I forgot if I answer the question on why eip should > move backward. > I did it because some instruction like "mov" will move eip to skip some > dst/src operand > when executing, so eip should be kept for consistency. > I think you're talking about >

Re: [kvm-devel] [PATCH] Enable memory mapped TPR shadow(FlexPriority)

2007-10-24 Thread Avi Kivity
Yang, Sheng wrote: > >From ac4dd1782b9f0f51e0c366a1b8db4515d6828df8 Mon Sep 17 00:00:00 2001 > From: Sheng Yang <[EMAIL PROTECTED]> > Date: Tue, 23 Oct 2007 12:34:42 +0800 > Subject: [PATCH] Enable memory mapped TPR shadow(FlexPriority) > > This patch based on CR8/TPR patch before, and enable the T

Re: [kvm-devel] [PATCH] Enable memory mapped TPR shadow(FlexPriority)

2007-10-23 Thread Yang, Sheng
Another comment: I forgot if I answer the question on why eip should move backward. I did it because some instruction like "mov" will move eip to skip some dst/src operand when executing, so eip should be kept for consistency. Yang, Sheng wrote: > From ac4dd1782b9f0f51e0c366a1b8db4515d6828df8 Mo

[kvm-devel] [PATCH] Enable memory mapped TPR shadow(FlexPriority)

2007-10-23 Thread Yang, Sheng
>From ac4dd1782b9f0f51e0c366a1b8db4515d6828df8 Mon Sep 17 00:00:00 2001 From: Sheng Yang <[EMAIL PROTECTED]> Date: Tue, 23 Oct 2007 12:34:42 +0800 Subject: [PATCH] Enable memory mapped TPR shadow(FlexPriority) This patch based on CR8/TPR patch before, and enable the TPR shadow(FlexPriority) for 32