Re: [kvm-devel] [PATCH] Fix e1000 can_receive handler

2008-05-09 Thread Avi Kivity
Anthony Liguori wrote: > Avi Kivity wrote: > >> Anthony Liguori wrote: >> >>> Aurelien Jarno wrote: >>> On Wed, May 07, 2008 at 04:40:58PM -0500, Anthony Liguori wrote: > The current logic of the can_receive handler is to allow packets > whenever th

Re: [kvm-devel] [PATCH] Fix e1000 can_receive handler

2008-05-08 Thread Anthony Liguori
Avi Kivity wrote: > Anthony Liguori wrote: >> Aurelien Jarno wrote: >>> On Wed, May 07, 2008 at 04:40:58PM -0500, Anthony Liguori wrote: >>> The current logic of the can_receive handler is to allow packets whenever the receiver is disabled or when there are descriptors available i

Re: [kvm-devel] [PATCH] Fix e1000 can_receive handler

2008-05-08 Thread Avi Kivity
Avi Kivity wrote: > > Note that flow control still makes sense since it allows us to buffer > some packets if the guest is scheduled out. But we can't use it as > the primary mechanism since it won't exist with multiqueue NICs (where > the virtio descriptors are fed to driver). > ... are fed t

Re: [kvm-devel] [PATCH] Fix e1000 can_receive handler

2008-05-08 Thread Avi Kivity
Anthony Liguori wrote: > Aurelien Jarno wrote: >> On Wed, May 07, 2008 at 04:40:58PM -0500, Anthony Liguori wrote: >> >>> The current logic of the can_receive handler is to allow packets >>> whenever the >>> receiver is disabled or when there are descriptors available in the >>> ring. >>> >>> I

Re: [kvm-devel] [PATCH] Fix e1000 can_receive handler

2008-05-08 Thread Anthony Liguori
Aurelien Jarno wrote: > On Wed, May 07, 2008 at 04:40:58PM -0500, Anthony Liguori wrote: > >> The current logic of the can_receive handler is to allow packets whenever the >> receiver is disabled or when there are descriptors available in the ring. >> >> I think the logic ought to be to allow pa

Re: [kvm-devel] [PATCH] Fix e1000 can_receive handler

2008-05-08 Thread Aurelien Jarno
On Wed, May 07, 2008 at 04:40:58PM -0500, Anthony Liguori wrote: > The current logic of the can_receive handler is to allow packets whenever the > receiver is disabled or when there are descriptors available in the ring. > > I think the logic ought to be to allow packets whenever the receiver is

[kvm-devel] [PATCH] Fix e1000 can_receive handler

2008-05-07 Thread Anthony Liguori
The current logic of the can_receive handler is to allow packets whenever the receiver is disabled or when there are descriptors available in the ring. I think the logic ought to be to allow packets whenever the receiver is enabled and there are descriptors available in the ring. Signed-off-by: A