[kvm-devel] [PATCH] QEMU support for virtio balloon driver

2008-03-18 Thread Anthony Liguori
This patch adds support to QEMU for Rusty's recently introduce virtio balloon driver. The user-facing portions of this are the introduction of a "balloon" and "info balloon" command in the monitor. Right now madvise() is commented out since it causes host panics. Ballooning is still functional t

Re: [kvm-devel] [PATCH] QEMU support for virtio balloon driver

2008-03-08 Thread Anthony Liguori
Marcelo Tosatti wrote: >> How to proceed now? Do we want to efficiently support ballooning without >> mmu notifiers? If so, an ioctl to zap the mmu is necessary as discussed >> before. >> > > Err, actually zapping the mmu is necessary to guarantee guest will not > use stale shadow entries vs e

Re: [kvm-devel] [PATCH] QEMU support for virtio balloon driver

2008-03-08 Thread Marcelo Tosatti
On Sat, Mar 08, 2008 at 04:27:13PM -0300, Marcelo Tosatti wrote: > On Sat, Jan 26, 2008 at 08:47:28PM +0200, Avi Kivity wrote: > > Anthony Liguori wrote: > > >Do others expect KVM to just cope with the virtual mapping being changed > > >out from underneath of it? > > > > > > > kvm should cope w

Re: [kvm-devel] [PATCH] QEMU support for virtio balloon driver

2008-03-08 Thread Marcelo Tosatti
On Sat, Jan 26, 2008 at 08:47:28PM +0200, Avi Kivity wrote: > Anthony Liguori wrote: > >Do others expect KVM to just cope with the virtual mapping being changed > >out from underneath of it? > > > > kvm should cope with both malicious guests and malicious (or buggy) host > userspace. It's dif

Re: [kvm-devel] [PATCH] QEMU support for virtio balloon driver

2008-02-25 Thread Dor Laor
On Mon, 2008-02-25 at 13:47 -0600, Anthony Liguori wrote: > This patch adds support to QEMU for Rusty's recently introduce virtio balloon > driver. The user-facing portions of this are the introduction of a "balloon" > and "info balloon" command in the monitor. > The patch looks good. Might be

Re: [kvm-devel] [PATCH] QEMU support for virtio balloon driver

2008-01-26 Thread Avi Kivity
Anthony Liguori wrote: > Do others expect KVM to just cope with the virtual mapping being changed > out from underneath of it? > kvm should cope with both malicious guests and malicious (or buggy) host userspace. It's difficuly to analyze, but mmu notifiers might be necessary for the latter

Re: [kvm-devel] [PATCH] QEMU support for virtio balloon driver

2008-01-26 Thread Avi Kivity
Anthony Liguori wrote: >>> Looks like it's not. I just hung my host system after doing a bunch >>> of ballooning with a kernel that doesn't have MM notifiers. >>> >>> I'm inclined to think that we should have a capability check for MM >>> notifiers and just not do madvise if they are

Re: [kvm-devel] [PATCH] QEMU support for virtio balloon driver

2008-01-25 Thread Rusty Russell
On Saturday 26 January 2008 03:08:57 Marcelo Tosatti wrote: > On Thu, Jan 24, 2008 at 04:29:51PM -0600, Anthony Liguori wrote: > > I'm inclined to think that we should have a capability check for MM > > notifiers and just not do madvise if they aren't present. I don't think > > the ioctl approach

Re: [kvm-devel] [PATCH] QEMU support for virtio balloon driver

2008-01-25 Thread Anthony Liguori
Dor Laor wrote: > On Thu, 2008-01-24 at 16:29 -0600, Anthony Liguori wrote: > >> Anthony Liguori wrote: >> >>> This patch adds support to QEMU for Rusty's recently introduce virtio >>> balloon >>> driver. The user-facing portions of this are the introduction of a >>> "balloon" >>> and "i

Re: [kvm-devel] [PATCH] QEMU support for virtio balloon driver

2008-01-25 Thread Dor Laor
On Thu, 2008-01-24 at 16:29 -0600, Anthony Liguori wrote: > Anthony Liguori wrote: > > This patch adds support to QEMU for Rusty's recently introduce virtio > > balloon > > driver. The user-facing portions of this are the introduction of a > > "balloon" > > and "info balloon" command in the mon

Re: [kvm-devel] [PATCH] QEMU support for virtio balloon driver

2008-01-25 Thread Anthony Liguori
Marcelo Tosatti wrote: > On Thu, Jan 24, 2008 at 04:29:51PM -0600, Anthony Liguori wrote: > >> Anthony Liguori wrote: >> >>> This patch adds support to QEMU for Rusty's recently introduce virtio >>> balloon >>> driver. The user-facing portions of this are the introduction of a >>> "ballo

Re: [kvm-devel] [PATCH] QEMU support for virtio balloon driver

2008-01-25 Thread Marcelo Tosatti
On Thu, Jan 24, 2008 at 04:29:51PM -0600, Anthony Liguori wrote: > Anthony Liguori wrote: > >This patch adds support to QEMU for Rusty's recently introduce virtio > >balloon > >driver. The user-facing portions of this are the introduction of a > >"balloon" > >and "info balloon" command in the mo

Re: [kvm-devel] [PATCH] QEMU support for virtio balloon driver

2008-01-24 Thread Anthony Liguori
Anthony Liguori wrote: > This patch adds support to QEMU for Rusty's recently introduce virtio balloon > driver. The user-facing portions of this are the introduction of a "balloon" > and "info balloon" command in the monitor. > > I think using madvise unconditionally is okay but I am not sure. L

[kvm-devel] [PATCH] QEMU support for virtio balloon driver

2008-01-24 Thread Anthony Liguori
This patch adds support to QEMU for Rusty's recently introduce virtio balloon driver. The user-facing portions of this are the introduction of a "balloon" and "info balloon" command in the monitor. I think using madvise unconditionally is okay but I am not sure. If madvise is called on memory th