Re: [kvm-devel] [PATCH] hardware debug register handling

2007-07-19 Thread Nguyen Anh Quynh
On 7/19/07, Avi Kivity <[EMAIL PROTECTED]> wrote: > Nguyen Anh Quynh wrote: > > Currently, when handling hardware breakpoints, we always set values > > for all the 4 hardware debug registers, regardless it is needed or > > not. This patch fixes the bug. > > Why is this a problem? Only enabled brea

Re: [kvm-devel] [PATCH] hardware debug register handling

2007-07-19 Thread Avi Kivity
Nguyen Anh Quynh wrote: > Currently, when handling hardware breakpoints, we always set values > for all the 4 hardware debug registers, regardless it is needed or > not. This patch fixes the bug. Why is this a problem? Only enabled breakpoints are programmed into dr7. > @@ -1519,12 +1522,18 @@ s

[kvm-devel] [PATCH] hardware debug register handling

2007-07-19 Thread Nguyen Anh Quynh
Currently, when handling hardware breakpoints, we always set values for all the 4 hardware debug registers, regardless it is needed or not. This patch fixes the bug. Signed-off-by: Nguyen Anh Quynh <[EMAIL PROTECTED]> diff --git a/drivers/kvm/kvm.h b/drivers/kvm/kvm.h index 7bdffe6..c6187c8 10064