Re: [kvm-devel] [PATCH] make KVM selectable again

2008-02-10 Thread Balbir Singh
On Feb 10, 2008 2:29 AM, Dave Hansen <[EMAIL PROTECTED]> wrote: > Current git for me (b1d0e4f535e10775cffde922208b49629169aeaa) doesn't > let me build KVM. In fact, I don't seem to have *ANY* kvm-related > symbols in my .config at all. > > I've verified that arch/x86/kvm/Kconfig was getting run by

Re: [kvm-devel] [PATCH] make KVM selectable again

2008-02-10 Thread Sam Ravnborg
Hi Dave. > > I've verified that arch/x86/kvm/Kconfig was getting run by putting some > comments in it. It seems to me like just putting: > > config HAVE_KVM > bool > > isn't letting anything come into my .config at all. I'm not sure why we > do that, and then have: > >

Re: [kvm-devel] [PATCH] make KVM selectable again

2008-02-10 Thread Sam Ravnborg
On Sat, Feb 09, 2008 at 10:24:01PM +0100, Ingo Molnar wrote: > > * Dave Hansen <[EMAIL PROTECTED]> wrote: > > > config HAVE_SETUP_PER_CPU_AREA > > def_bool X86_64 > > > > -select HAVE_KVM > > +config HAVE_KVM > > + def_bool y > > i think it might be better to just move the select to aft

Re: [kvm-devel] [PATCH] make KVM selectable again

2008-02-09 Thread Ingo Molnar
* Dave Hansen <[EMAIL PROTECTED]> wrote: > config HAVE_SETUP_PER_CPU_AREA > def_bool X86_64 > > -select HAVE_KVM > +config HAVE_KVM > + def_bool y i think it might be better to just move the select to after the "config X86" option. (this is a legitimate use of select) Sam, do you c

[kvm-devel] [PATCH] make KVM selectable again

2008-02-09 Thread Dave Hansen
Current git for me (b1d0e4f535e10775cffde922208b49629169aeaa) doesn't let me build KVM. In fact, I don't seem to have *ANY* kvm-related symbols in my .config at all. I've verified that arch/x86/kvm/Kconfig was getting run by putting some comments in it. It seems to me like just putting: