Re: [kvm-devel] [PATCH] replace the slots lock from the mmap_sem to private kvm lock

2008-02-11 Thread Izik Eidus
Marcelo Tosatti wrote: > On Mon, Feb 11, 2008 at 05:12:42PM +0200, Izik Eidus wrote: > >> right now kvm take the down_read(mmap_sem) lock to make sure that no >> slots will be >> removed while trying to get them / make the dirty log safe, >> but in some cases when the down_read(mmap_sem) is cal

Re: [kvm-devel] [PATCH] replace the slots lock from the mmap_sem to private kvm lock

2008-02-11 Thread Marcelo Tosatti
On Mon, Feb 11, 2008 at 05:12:42PM +0200, Izik Eidus wrote: > right now kvm take the down_read(mmap_sem) lock to make sure that no > slots will be > removed while trying to get them / make the dirty log safe, > but in some cases when the down_read(mmap_sem) is called and after that > kvm_read_gue

[kvm-devel] [PATCH] replace the slots lock from the mmap_sem to private kvm lock

2008-02-11 Thread Izik Eidus
right now kvm take the down_read(mmap_sem) lock to make sure that no slots will be removed while trying to get them / make the dirty log safe, but in some cases when the down_read(mmap_sem) is called and after that kvm_read_guest() is called copy_from_user can result in a page fault that will le