[kvm-devel] [PATCH] use symbols rather than constant vars in kvm_create

2007-06-03 Thread Nguyen Anh Quynh
This patch replaces 2 constant variables "dosmem" and "exmem" in kvm_create() with symbols. Signed-off-by: Nguyen Anh Quynh <[EMAIL PROTECTED]> patch3.patch Description: Binary data - This SF.net email is sponsored by DB2 E

Re: [kvm-devel] [PATCH] use symbols rather than constant vars in kvm_create

2007-06-03 Thread Avi Kivity
Nguyen Anh Quynh wrote: > This patch replaces 2 constant variables "dosmem" and "exmem" in > kvm_create() with symbols. What is the benefit of this? Readability is not improved. -- error compiling committee.c: too many arguments to function ---

Re: [kvm-devel] [PATCH] use symbols rather than constant vars in kvm_create

2007-06-03 Thread Nguyen Anh Quynh
On 6/3/07, Avi Kivity <[EMAIL PROTECTED]> wrote: > Nguyen Anh Quynh wrote: > > This patch replaces 2 constant variables "dosmem" and "exmem" in > > kvm_create() with symbols. > > What is the benefit of this? Readability is not improved. > > yes, but what is the reason to use vars instead of symbo

Re: [kvm-devel] [PATCH] use symbols rather than constant vars in kvm_create

2007-06-03 Thread Avi Kivity
Nguyen Anh Quynh wrote: > On 6/3/07, Avi Kivity <[EMAIL PROTECTED]> wrote: >> Nguyen Anh Quynh wrote: >> > This patch replaces 2 constant variables "dosmem" and "exmem" in >> > kvm_create() with symbols. >> >> What is the benefit of this? Readability is not improved. >> >> > > yes, but what is the

Re: [kvm-devel] [PATCH] use symbols rather than constant vars in kvm_create

2007-06-03 Thread Nguyen Anh Quynh
On 6/3/07, Avi Kivity <[EMAIL PROTECTED]> wrote: > Nguyen Anh Quynh wrote: > > On 6/3/07, Avi Kivity <[EMAIL PROTECTED]> wrote: > >> Nguyen Anh Quynh wrote: > >> > This patch replaces 2 constant variables "dosmem" and "exmem" in > >> > kvm_create() with symbols. > >> > >> What is the benefit of thi