Re: [kvm-devel] [PATCH]4/5 Combine kvm_init and kvm_init_x86

2007-11-14 Thread Carsten Otte
Acked-by: Carsten Otte <[EMAIL PROTECTED]> Zhang, Xiantao wrote: > From: Zhang Xiantao <[EMAIL PROTECTED]> > Combine kvm_init and kvm_init_x86 into one function, and will be called > when arch register. > Signed-off-by: Zhang Xiantao <[EMAIL PROTECTED]> > --- > drivers/kvm/kvm.h |4 +- >

[kvm-devel] [PATCH]4/5 Combine kvm_init and kvm_init_x86

2007-11-13 Thread Zhang, Xiantao
From: Zhang Xiantao <[EMAIL PROTECTED]> Combine kvm_init and kvm_init_x86 into one function, and will be called when arch register. Signed-off-by: Zhang Xiantao <[EMAIL PROTECTED]> --- drivers/kvm/kvm.h |4 +- drivers/kvm/kvm_main.c | 61 +--

Re: [kvm-devel] [PATCH] 4/5 Combine kvm_init and kvm_init_x86 intoonefunction (Correction V3)

2007-11-08 Thread Hollis Blanchard
Your mailer, which I'm guessing is Microsoft Outlook, is wrapping lines and so this patch does not apply. You might try using git-send-email or equivalent to avoid this issue. -- Hollis Blanchard IBM Linux Technology Center On Thu, 2007-11-08 at 16:17 +0800, Zhang, Xiantao wrote: > Hi Avi >

Re: [kvm-devel] [PATCH] 4/5 Combine kvm_init and kvm_init_x86 intoonefunction (Correction V3)

2007-11-08 Thread Zhang, Xiantao
Carsten Otte wrote: > >> +bad_page = alloc_page(GFP_KERNEL | __GFP_ZERO); >> + >> +if (bad_page == NULL) { >> +r = -ENOMEM; >> +goto out; >> +} > I don't think we need bad_page on s390, maybe I missed something. It's > only useful for mmu code as far as I can

Re: [kvm-devel] [PATCH] 4/5 Combine kvm_init and kvm_init_x86 intoonefunction (Correction V3)

2007-11-08 Thread Carsten Otte
I agree with the gernal idea of this patch. Just a few minor things to pick on: Zhang, Xiantao wrote: > diff --git a/drivers/kvm/kvm.h b/drivers/kvm/kvm.h > index 4b2421a..33b4629 100644 > --- a/drivers/kvm/kvm.h > +++ b/drivers/kvm/kvm.h > @@ -494,9 +494,9 @@ void vcpu_load(struct kvm_vcpu *vcpu

[kvm-devel] [PATCH] 4/5 Combine kvm_init and kvm_init_x86 intoonefunction (Correction V3)

2007-11-08 Thread Zhang, Xiantao
Hi Avi Seems my mailer has something wrong, and it always reference an old version. This should be a correct one. Sorry for inconvenience! Xiantao >From 959bc19b0e2ca7edcb3389aabdecf99ba9f1794e Mon Sep 17 00:00:00 2001 From: Zhang Xiantao <[EMAIL PROTECTED]> Date: Thu, 8 Nov 2007 13:19:0

[kvm-devel] [PATCH] 4/5 Combine kvm_init and kvm_init_x86 into onefunction (Correction V2)

2007-11-08 Thread Zhang, Xiantao
Hi Avi Please drop it, and use this one, due to version issue. thanks Xiantao >From 959bc19b0e2ca7edcb3389aabdecf99ba9f1794e Mon Sep 17 00:00:00 2001 From: Zhang Xiantao <[EMAIL PROTECTED]> Date: Thu, 8 Nov 2007 13:19:06 +0800 Subject: [PATCH] Combine kvm_init and kvm_init_x86 into one function,

[kvm-devel] [PATCH] 4/5 Combine kvm_init and kvm_init_x86 into one function

2007-11-07 Thread Zhang, Xiantao
>From 959bc19b0e2ca7edcb3389aabdecf99ba9f1794e Mon Sep 17 00:00:00 2001 From: Zhang Xiantao <[EMAIL PROTECTED]> Date: Thu, 8 Nov 2007 13:19:06 +0800 Subject: [PATCH] Combine kvm_init and kvm_init_x86 into one function, and meanwhile remove module_init module_exit function, since they will be called