Re: [kvm-devel] [PATCH]Add TR insert/purge interface for add-on component

2008-01-31 Thread Xu, Anthony
Hi tony, This is the revised patch per comments. We don't use index as parameter of ia64_ptr_entry, Because it will cause the unconvenientce to user. 1. the user need to remember index. 2. the user may want to use one purge to purge two previous inserts. We add some optimization for

Re: [kvm-devel] [PATCH]Add TR insert/purge interface for add-on component

2008-01-21 Thread Luck, Tony
Looks pretty good. Stylistically it would be nicer to initialize ia64_max_tr_num to 8 (with a comment that this is the least smallest allowed value allowed by the architecture - SDM p.2:44 section 4.1.1.1) and increase this if PAL_VM_SUMMARY indicates that the current processor model supports a

Re: [kvm-devel] [PATCH]Add TR insert/purge interface for add-on component

2008-01-21 Thread Xu, Anthony
Thanks for your comments Luck, Tony wrote: Looks pretty good. Stylistically it would be nicer to initialize ia64_max_tr_num to 8 (with a comment that this is the least smallest allowed value allowed by the architecture - SDM p.2:44 section 4.1.1.1) and increase this if PAL_VM_SUMMARY

Re: [kvm-devel] [PATCH]Add TR insert/purge interface for add-on component

2008-01-21 Thread Xu, Anthony
Xu, Anthony wrote: Thanks for your comments Luck, Tony wrote: Looks pretty good. Stylistically it would be nicer to initialize ia64_max_tr_num to 8 (with a comment that this is the least smallest allowed value allowed by the architecture - SDM p.2:44 section 4.1.1.1) and increase this

[kvm-devel] [PATCH]Add TR insert/purge interface for add-on component

2008-01-20 Thread Xu, Anthony
Hi Avi/Tony, This patch adds the TR insert/purge interface for add-on components. TR insert/purge can only been executed by TR mapped code, while module code is mapped by TC, So module can not execute TR insert/purge. This patch let modules execute TR insert/purge. In the meantime, this

Re: [kvm-devel] [PATCH]Add TR insert/purge interface for add-on component

2008-01-20 Thread Matthew Wilcox
On Mon, Jan 21, 2008 at 11:18:03AM +0800, Xu, Anthony wrote: Hi Avi/Tony, This patch adds the TR insert/purge interface for add-on components. In my world, TR stands for Token Ring. Nowhere in this patch do you explain what TR means to you! -- Intel are signing my paycheques ... these

Re: [kvm-devel] [PATCH]Add TR insert/purge interface for add-on component

2008-01-20 Thread KOSAKI Motohiro
On Mon, Jan 21, 2008 at 11:18:03AM +0800, Xu, Anthony wrote: Hi Avi/Tony, This patch adds the TR insert/purge interface for add-on components. In my world, TR stands for Token Ring. Nowhere in this patch do you explain what TR means to you! may be, TR is Tlb Register. see IA64 itr

Re: [kvm-devel] [PATCH]Add TR insert/purge interface for add-on component

2008-01-20 Thread Xu, Anthony
Matthew Wilcox wrote: On Mon, Jan 21, 2008 at 11:18:03AM +0800, Xu, Anthony wrote: Hi Avi/Tony, This patch adds the TR insert/purge interface for add-on components. In my world, TR stands for Token Ring. Nowhere in this patch do you explain what TR means to you! Sorry for confusing