Re: [kvm-devel] [PATCH 0/7] Rework irq injection infrastructure

2007-12-06 Thread Avi Kivity
-devel@lists.sourceforge.net Subject: [kvm-devel] [PATCH 0/7] Rework irq injection infrastructure The current irq and exception injection infrastructure is quite complex and has been the source of a number of bugs in the past. This patchset simplifies irq and exception injection: - Much

Re: [kvm-devel] [PATCH 0/7] Rework irq injection infrastructure

2007-12-06 Thread Dong, Eddie
Mmm, how can you know if it is injected successfully? From the patch, it looks like you know this by checking IDT_Vectoring in next VM Exit. That means the virtual interrupt controller state in memory is incorrect temply. If the injection success we can get VM Exit before next access to

Re: [kvm-devel] [PATCH 0/7] Rework irq injection infrastructure

2007-12-06 Thread Avi Kivity
Dong, Eddie wrote: Mmm, how can you know if it is injected successfully? From the patch, it looks like you know this by checking IDT_Vectoring in next VM Exit. That means the virtual interrupt controller state in memory is incorrect temply. If the injection success we can get VM Exit

Re: [kvm-devel] [PATCH 0/7] Rework irq injection infrastructure

2007-12-06 Thread Dong, Eddie
One of the optimization, which can be used in pure SW is that we can shadow APIC state as RO to guest so that all guest read to APIC registers can run in full speed. T This can still be done with unacked interrupts: modify the state to as if the interrupt was injected, but commit

Re: [kvm-devel] [PATCH 0/7] Rework irq injection infrastructure

2007-12-06 Thread Avi Kivity
Dong, Eddie wrote: What I mean is we pre-load 2 pages where the stack are in, the logic may be: If (real mode) get 2 pages. enter critical path VM Resume. put these 2 pages. handle VM Exit normally. With 2nd thinking, We can cache these 2 pages. Something like: if

Re: [kvm-devel] [PATCH 0/7] Rework irq injection infrastructure

2007-12-05 Thread Dong, Eddie
Subject: [kvm-devel] [PATCH 0/7] Rework irq injection infrastructure The current irq and exception injection infrastructure is quite complex and has been the source of a number of bugs in the past. This patchset simplifies irq and exception injection: - Much more work is carried out in common code

[kvm-devel] [PATCH 0/7] Rework irq injection infrastructure

2007-12-04 Thread Avi Kivity
The current irq and exception injection infrastructure is quite complex and has been the source of a number of bugs in the past. This patchset simplifies irq and exception injection: - Much more work is carried out in common code rather than vmx/svm specific code. Information is kept in C

Re: [kvm-devel] [PATCH 0/7] Rework irq injection infrastructure

2007-12-04 Thread Joerg Roedel
On Tue, Dec 04, 2007 at 11:44:07AM +0200, Avi Kivity wrote: The patchset is also necessary for integrating the tpr optimization branch and for injecting interrupts in big real mode. Interesting work. Do you have an updated tpr optimization patch which applys on top of these patches? Joerg --

Re: [kvm-devel] [PATCH 0/7] Rework irq injection infrastructure

2007-12-04 Thread Avi Kivity
Joerg Roedel wrote: On Tue, Dec 04, 2007 at 11:44:07AM +0200, Avi Kivity wrote: The patchset is also necessary for integrating the tpr optimization branch and for injecting interrupts in big real mode. Interesting work. Do you have an updated tpr optimization patch which applys on