Re: [kvm-devel] [PATCH 2/2] KVM: in-kernel-apic modification to QEMU

2007-05-14 Thread Avi Kivity
Anthony Liguori wrote: >> int intno; >> >> +#ifdef USE_KVM >> +if (!kvm_allowed) { >> +#endif >> intno = apic_get_interrupt(env); >> if (intno >= 0) { >> >> > > Indent the inner block please :-) > > Indenting the inner code would cause merging to be very difficult,

Re: [kvm-devel] [PATCH 2/2] KVM: in-kernel-apic modification to QEMU

2007-05-10 Thread Gregory Haskins
Hehe..ya, your points are all valid. Note that I never really intended this code to be reviewed quite yet. Its included purely to enable testing of the kernel side. I'll be the first to admit its a complete hack :). I'll be working on polishing this up next. Stay tuned. -Greg >>> On Thu,

Re: [kvm-devel] [PATCH 2/2] KVM: in-kernel-apic modification to QEMU

2007-05-10 Thread Anthony Liguori
Gregory Haskins wrote: > Signed-off-by: Gregory Haskins <[EMAIL PROTECTED]> > --- > > qemu/hw/apic.c | 22 -- > qemu/hw/pc.c| 13 - > qemu/qemu-kvm.c | 18 ++ > qemu/vl.h |2 +- > user/kvmctl.c | 25 +++--

[kvm-devel] [PATCH 2/2] KVM: in-kernel-apic modification to QEMU

2007-05-10 Thread Gregory Haskins
Signed-off-by: Gregory Haskins <[EMAIL PROTECTED]> --- qemu/hw/apic.c | 22 -- qemu/hw/pc.c| 13 - qemu/qemu-kvm.c | 18 ++ qemu/vl.h |2 +- user/kvmctl.c | 25 +++-- user/kvmctl.h |5 +++-- user/ma