Re: [kvm-devel] [PATCH 24/24] make vsmp a paravirt client

2007-11-13 Thread Ravikiran Thirumalai
On Tue, Nov 13, 2007 at 02:09:41PM +0100, Andi Kleen wrote: > >> If vsmp is selected, PARAVIRT will be too, and the interrupt code will >> be patched. >> the vsmp option triggers a select statement. >> >> the ifdef only exists because, as I said, the code itself will be always >> compiled in, to a

Re: [kvm-devel] [PATCH 24/24] make vsmp a paravirt client

2007-11-13 Thread Ravikiran Thirumalai
On Tue, Nov 13, 2007 at 09:36:42AM -0200, Glauber de Oliveira Costa wrote: >-BEGIN PGP SIGNED MESSAGE- > >> And the "EM64T based comment" is wrong because there are AMD based >> vSMPs too. >Just got it as-is from the old Kconfig. Do you think it should be fixed >as well? Yep. Thanks, Kir

Re: [kvm-devel] [PATCH 24/24] make vsmp a paravirt client

2007-11-13 Thread Jeremy Fitzhardinge
Glauber de Oliveira Costa wrote: > the ifdef only exists because, as I said, the code itself will be always > compiled in, to avoid an ifdef in setup_64.c. So it's just a taking it > from here, putting it there issue. Kiran seem to prefer this way, but I > don't really have a preference. It would

Re: [kvm-devel] [PATCH 24/24] make vsmp a paravirt client

2007-11-13 Thread Andi Kleen
> If vsmp is selected, PARAVIRT will be too, and the interrupt code will > be patched. > the vsmp option triggers a select statement. > > the ifdef only exists because, as I said, the code itself will be always > compiled in, to avoid an ifdef in setup_64.c. So it's just a taking it > from here,

Re: [kvm-devel] [PATCH 24/24] make vsmp a paravirt client

2007-11-13 Thread Glauber de Oliveira Costa
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Andi Kleen escreveu: >> The vsmp_64.c file is now compiled unconditionally, according to which >> me and kiran agreed to. The detection code is always run, but will only >> trigger when a suitable box is found. Accordingly, the paravirt structs >> are

Re: [kvm-devel] [PATCH 24/24] make vsmp a paravirt client

2007-11-13 Thread Andi Kleen
> The vsmp_64.c file is now compiled unconditionally, according to which > me and kiran agreed to. The detection code is always run, but will only > trigger when a suitable box is found. Accordingly, the paravirt structs > are only touched when PARAVIRT is on. Otherwise, we don't even have the > s

Re: [kvm-devel] [PATCH 24/24] make vsmp a paravirt client

2007-11-13 Thread Glauber de Oliveira Costa
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Andi Kleen escreveu: > On Fri, Nov 09, 2007 at 04:43:05PM -0200, Glauber de Oliveira Costa wrote: >> This patch makes vsmp a paravirt client. It now uses the whole >> infrastructure provided by pvops. When we detect we're running >> a vsmp box, we chan

Re: [kvm-devel] [PATCH 24/24] make vsmp a paravirt client

2007-11-11 Thread Andi Kleen
On Fri, Nov 09, 2007 at 04:43:05PM -0200, Glauber de Oliveira Costa wrote: > This patch makes vsmp a paravirt client. It now uses the whole > infrastructure provided by pvops. When we detect we're running > a vsmp box, we change the irq-related paravirt operations (and so, > it have to happen quite

[kvm-devel] [PATCH 24/24] make vsmp a paravirt client

2007-11-09 Thread Glauber de Oliveira Costa
This patch makes vsmp a paravirt client. It now uses the whole infrastructure provided by pvops. When we detect we're running a vsmp box, we change the irq-related paravirt operations (and so, it have to happen quite early), and the patching function Signed-off-by: Glauber de Oliveira Costa <[EMAI