[kvm-devel] [PATCH 3/3] [PATCH] kvmclock implementation, the guest part.

2008-01-15 Thread Glauber de Oliveira Costa
This is the guest part of kvm clock implementation It does not do tsc-only timing, as tsc can have deltas between cpus, and it did not seem worthy to me to keep adjusting them. We do use it, however, for fine-grained adjustment. Other than that, time comes from the host. Signed-off-by: Glauber d

Re: [kvm-devel] [PATCH 3/3] [PATCH] kvmclock implementation, the guest part.

2008-01-11 Thread Glauber de Oliveira Costa
Gerd Hoffmann wrote: > Hi, > >> diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c >> index d083ff5..7728b87 100644 >> --- a/arch/x86/xen/time.c >> +++ b/arch/x86/xen/time.c >> -static cycle_t xen_clocksource_read(void); >> +cycle_t xen_clocksource_read(void); > > Huh? You kill the static,

Re: [kvm-devel] [PATCH 3/3] [PATCH] kvmclock implementation, the guest part.

2008-01-11 Thread Gerd Hoffmann
Hi, > diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c > index d083ff5..7728b87 100644 > --- a/arch/x86/xen/time.c > +++ b/arch/x86/xen/time.c > -static cycle_t xen_clocksource_read(void); > +cycle_t xen_clocksource_read(void); Huh? You kill the static, but don't use the functions anywhe

[kvm-devel] [PATCH 3/3] [PATCH] kvmclock implementation, the guest part.

2008-01-11 Thread Glauber de Oliveira Costa
This is the guest part of kvm clock implementation It does not do tsc-only timing, as tsc can have deltas between cpus, and it did not seem worthy to me to keep adjusting them. We do use it, however, for fine-grained adjustment. Other than that, time comes from the host. Signed-off-by: Glauber d