Re: [kvm-devel] [PATCH 3/4] [PATCH] kvmclock: allow it to be turned off

2008-03-06 Thread Glauber Costa
Avi Kivity wrote: Glauber Costa wrote: Use the lower 3 lower bits of the system time msr to turn off the clock. This means that all clock registration has to be aligned in a 4-byte boundary 3 bits - 8 bytes. dohh!! true /me ashamed. How about just using just bit 0 as an enable bit

Re: [kvm-devel] [PATCH 3/4] [PATCH] kvmclock: allow it to be turned off

2008-03-06 Thread Avi Kivity
Glauber Costa wrote: Apart from the fact that it will break every single guest out there, that's ok. As I said: these things are so early, that maybe we can pay this price. Your call. Which guests? kvmclock is only in kvm.git, and I don't think any distro is based on that. -- Do not

[kvm-devel] [PATCH 3/4] [PATCH] kvmclock: allow it to be turned off

2008-03-05 Thread Glauber Costa
Use the lower 3 lower bits of the system time msr to turn off the clock. This means that all clock registration has to be aligned in a 4-byte boundary Signed-off-by: Glauber Costa [EMAIL PROTECTED] --- arch/x86/kvm/x86.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git

Re: [kvm-devel] [PATCH 3/4] [PATCH] kvmclock: allow it to be turned off

2008-03-05 Thread Avi Kivity
Glauber Costa wrote: Use the lower 3 lower bits of the system time msr to turn off the clock. This means that all clock registration has to be aligned in a 4-byte boundary 3 bits - 8 bytes. How about just using just bit 0 as an enable bit (not a disable bit). That means the default