Re: [kvm-devel] [PATCH 4/10] Trivial: Make decode_register() static

2007-07-17 Thread Avi Kivity
Gregory Haskins wrote: > On Tue, 2007-07-17 at 23:16 +1000, Rusty Russell wrote: > >> I have shied away from touching x86_emulate.c (it could definitely use >> some love, but it is forked from the Xen code, and it would be more >> productive to cross-merge fixes). >> > > On this topic, here

Re: [kvm-devel] [PATCH 4/10] Trivial: Make decode_register() static

2007-07-17 Thread Anthony Liguori
Gregory Haskins wrote: > On Tue, 2007-07-17 at 23:16 +1000, Rusty Russell wrote: > >> I have shied away from touching x86_emulate.c (it could definitely use >> some love, but it is forked from the Xen code, and it would be more >> productive to cross-merge fixes). >> > > On this topic, here

Re: [kvm-devel] [PATCH 4/10] Trivial: Make decode_register() static

2007-07-17 Thread Dor Laor
>> I have shied away from touching x86_emulate.c (it could definitely use >> some love, but it is forked from the Xen code, and it would be more >> productive to cross-merge fixes). > >On this topic, here's an idea I have been kicking around for a while: > >If the x86_emulate code is so buggy/incom

Re: [kvm-devel] [PATCH 4/10] Trivial: Make decode_register() static

2007-07-17 Thread Avi Kivity
Rusty Russell wrote: > I have shied away from touching x86_emulate.c (it could definitely use > some love, but it is forked from the Xen code, and it would be more > productive to cross-merge fixes). > > Applied, thanks. -- error compiling committee.c: too many arguments to function ---

Re: [kvm-devel] [PATCH 4/10] Trivial: Make decode_register() static

2007-07-17 Thread Gregory Haskins
On Tue, 2007-07-17 at 23:16 +1000, Rusty Russell wrote: > I have shied away from touching x86_emulate.c (it could definitely use > some love, but it is forked from the Xen code, and it would be more > productive to cross-merge fixes). On this topic, here's an idea I have been kicking around for a

[kvm-devel] [PATCH 4/10] Trivial: Make decode_register() static

2007-07-17 Thread Rusty Russell
I have shied away from touching x86_emulate.c (it could definitely use some love, but it is forked from the Xen code, and it would be more productive to cross-merge fixes). Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> diff -r c7348ac9677f drivers/kvm/x86_emulate.c --- a/drivers/kvm/x86_emulat