Nitin A Kamble wrote:
On Fri, 2007-08-17 at 05:24 -0700, Avi Kivity wrote:
A file scope function would indeed be uglier. But the macro has more
serious problems; it's impossible to understand how variables are
affected since nobody expects function local variables whose address
is
not
On Fri, 2007-08-17 at 05:24 -0700, Avi Kivity wrote:
A file scope function would indeed be uglier. But the macro has more
serious problems; it's impossible to understand how variables are
affected since nobody expects function local variables whose address
is
not taken to change after
Nitin A Kamble wrote:
Hi Avi,
I modified the patch as per your suggestions. Attached is the update
patch for the jmp rel instruction. Also the jmp rel short patch
would go on top of it.
+ inline void jmp_rel(int rel)
+ {
+ _eip += (int)(rel);
+ _eip
Avi,
In my opinion converting this small function to file-scope function,
would make code look ugly. I think the earlier Macro definition was
better.
On Thu, 2007-08-16 at 03:25 -0700, Avi Kivity wrote:
+ inline void jmp_rel(int rel)
+ {
+ _eip += (int)(rel);
Hi Avi,
If you are fine with macro then attached are the updated patches for
jmp rel jmp rel short instruction emulation.
On Thu, 2007-08-16 at 13:34 -0700, Nitin A Kamble wrote:
Avi,
In my opinion converting this small function to file-scope function,
would make code look ugly. I
Hi Avi,
I modified the patch as per your suggestions. Attached is the update
patch for the jmp rel instruction. Also the jmp rel short patch
would go on top of it.
Thanks Regards,
Nitin
Open Source Technology Center, Intel Corporation
Nitin A Kamble wrote:
Hi Avi,
The patch to implement jmp rel emulation is attached.
+#define jmp_rel(rel) \
+do { \
+ _eip += (int)(rel);
Hi Avi,
The patch to implement jmp rel emulation is attached.
Thanks Regards,
Nitin
Open Source Technology Center, Intel Corporation.
-
The mind is like a parachute; it works much better when it's open.
commit
Hi Avi,
Attached is the patch for the instruction jmp rel short, opcode
0xeb.
This patch goes on top of last patch (jmp rel).
Thanks Regards,
Nitin
Open Source Technology Center, Intel Corporation.
-
The mind is
