Re: [kvm-devel] [Qemu-devel] [PATCH 4/6] virtio network driver

2008-03-30 Thread Paul Brook
On Saturday 29 March 2008, Anthony Liguori wrote: +    if ((elem = virtqueue_pop(n-rx_vq)) == NULL) { +   /* wait until the guest adds some rx bufs */ +   n-can_receive = 0; +   return; +    } Setting can_receive to zero *after* dropping a packet is a bit late. Not a fatal flaw,

Re: [kvm-devel] [Qemu-devel] [PATCH 4/6] virtio network driver

2008-03-30 Thread Anthony Liguori
Paul Brook wrote: On Saturday 29 March 2008, Anthony Liguori wrote: +if ((elem = virtqueue_pop(n-rx_vq)) == NULL) { + /* wait until the guest adds some rx bufs */ + n-can_receive = 0; + return; +} Setting can_receive to zero *after* dropping a packet is