Re: [kvm-devel] [RFC] qemu: simulate edge-triggered interrupt in master PIC for time-drift-fix

2007-11-10 Thread Dor Laor
Carlo Marcelo Arenas Belon wrote: On Sat, Nov 10, 2007 at 12:35:34AM +0200, Dor Laor wrote: Carlo Marcelo Arenas Belon wrote: wrong patch, this was meant to go to the slave PIC, so it will use s->pics[1] instead of s->pics[0]. Why to the slave pic? Isn't the pit connected to line 0

Re: [kvm-devel] [RFC] qemu: simulate edge-triggered interrupt in master PIC for time-drift-fix

2007-11-09 Thread Carlo Marcelo Arenas Belon
On Sat, Nov 10, 2007 at 12:35:34AM +0200, Dor Laor wrote: >Carlo Marcelo Arenas Belon wrote: > > wrong patch, this was meant to go to the slave PIC, so it will use s->pics[1] > instead of s->pics[0]. > >Why to the slave pic? Isn't the pit connected to line 0 of the master? yes, you are

Re: [kvm-devel] [RFC] qemu: simulate edge-triggered interrupt in master PIC for time-drift-fix

2007-11-09 Thread Dor Laor
Carlo Marcelo Arenas Belon wrote: wrong patch, this was meant to go to the slave PIC, so it will use s->pics[1] instead of s->pics[0]. Why to the slave pic? Isn't the pit connected to line 0 of the master? also from my tests it might seem that tdf is irrelevant anyway with the new clock wor

Re: [kvm-devel] [RFC] qemu: simulate edge-triggered interrupt in master PIC for time-drift-fix

2007-11-09 Thread Carlo Marcelo Arenas Belon
wrong patch, this was meant to go to the slave PIC, so it will use s->pics[1] instead of s->pics[0]. also from my tests it might seem that tdf is irrelevant anyway with the new clock work and haven't been able to find a case where enabling it (so triggering this buggy code path) migh be needed. a