Re: [kvm-devel] [kvm-ppc-devel] booting from virtio-blk

2008-04-01 Thread Benjamin Herrenschmidt
On Tue, 2008-04-01 at 16:18 -0500, Hollis Blanchard wrote: > The point is that a virtio device appears as a PCI device. Like all > other PCI devices, it has config space. Unlike all other PCI devices, > its config space is accessed with 1-byte reads. Which is weirdo ... it you guys make it look l

Re: [kvm-devel] [kvm-ppc-devel] booting from virtio-blk

2008-04-01 Thread Hollis Blanchard
On Tue, 2008-04-01 at 16:03 -0500, Anthony Liguori wrote: > Benjamin Herrenschmidt wrote: > > On Tue, 2008-04-01 at 12:09 -0500, Anthony Liguori wrote: > > > > > >> It's the unfortunate side-effect of using PCI config space without > >> passing it's semantics through to the virtio devices. Rig

Re: [kvm-devel] [kvm-ppc-devel] booting from virtio-blk

2008-04-01 Thread Benjamin Herrenschmidt
> > Config space should be 8/16/32. Is that ever bridged to real PCI config > > space anyway ? Or only virtio ? And it should be endian swapped at the > > low level, either by your HV calls or by the low level kernel. Always. > > That's how PCI config space is supposed to work. > > > > I guess

Re: [kvm-devel] [kvm-ppc-devel] booting from virtio-blk

2008-04-01 Thread Anthony Liguori
Benjamin Herrenschmidt wrote: > On Tue, 2008-04-01 at 12:09 -0500, Anthony Liguori wrote: > > >> It's the unfortunate side-effect of using PCI config space without >> passing it's semantics through to the virtio devices. Right now, you do >> a config_get which is basically a memcpy. If we di

Re: [kvm-devel] [kvm-ppc-devel] booting from virtio-blk

2008-04-01 Thread Benjamin Herrenschmidt
On Tue, 2008-04-01 at 12:09 -0500, Anthony Liguori wrote: > It's the unfortunate side-effect of using PCI config space without > passing it's semantics through to the virtio devices. Right now, you do > a config_get which is basically a memcpy. If we didn't do accesses with > ioread8(), you