Re: [kvm-devel] [patch 0/4] fix SMP migration and loadvm/savevm (V2)

2008-04-10 Thread Avi Kivity
Marcelo Tosatti wrote: > On Wed, Apr 09, 2008 at 12:59:50AM +0300, Avi Kivity wrote: > >> Marcelo Tosatti wrote: >> >>> Avi, I prefer not to fold mpstate into kvm_save_registers() as a hidden >>> register because the MPSTATE is only used during migration, whereas >>> save_registers() is no

Re: [kvm-devel] [patch 0/4] fix SMP migration and loadvm/savevm (V2)

2008-04-08 Thread Marcelo Tosatti
On Wed, Apr 09, 2008 at 12:59:50AM +0300, Avi Kivity wrote: > Marcelo Tosatti wrote: > >Avi, I prefer not to fold mpstate into kvm_save_registers() as a hidden > >register because the MPSTATE is only used during migration, whereas > >save_registers() is not (seems safer) > > But that's the point.

Re: [kvm-devel] [patch 0/4] fix SMP migration and loadvm/savevm (V2)

2008-04-08 Thread Avi Kivity
Marcelo Tosatti wrote: > Avi, I prefer not to fold mpstate into kvm_save_registers() as a hidden > register because the MPSTATE is only used during migration, whereas > save_registers() is not (seems safer) But that's the point... what about savevm/loadvm, etc? They deserve to work too. -- An

[kvm-devel] [patch 0/4] fix SMP migration and loadvm/savevm (V2)

2008-04-07 Thread Marcelo Tosatti
Now guarded by KVM_CAP and with increased version_id of cpu_save/load as requested. Avi, I prefer not to fold mpstate into kvm_save_registers() as a hidden register because the MPSTATE is only used during migration, whereas save_registers() is not (seems safer). -- ---