Re: [kvm-devel] Broken external module build on 2.6.23

2008-02-11 Thread Avi Kivity
Avi Kivity wrote: > Thanks, applied that. I added an include-compat/asm symlink so that > it builds. > Actually I applied the second version you sent. -- error compiling committee.c: too many arguments to function - This

Re: [kvm-devel] Broken external module build on 2.6.23

2008-02-11 Thread Avi Kivity
Andrea Arcangeli wrote: > I created a more complete patch below, this will solve all my silent > time-wasting miscompilations (currnently when building kvm.git on a > newer mainline kernels, certain kvm*.h $KERNELDIR headers are included > instead of my modified ones in $LINUX, so the build can cra

Re: [kvm-devel] Broken external module build on 2.6.23

2008-02-11 Thread Andrea Arcangeli
On Mon, Feb 11, 2008 at 12:19:44PM +0100, Andrea Arcangeli wrote: > + LINUXINCLUDE="-I`pwd`/include -Iinclude -Iinclude-compat \ woops, here the last version: Signed-off-by: Andrea Arcangeli <[EMAIL PROTECTED]> diff -urN 1/kernel/include/asm-x86/cmpxchg.h 2/kernel/include/asm-x86/cmp

Re: [kvm-devel] Broken external module build on 2.6.23

2008-02-11 Thread Andrea Arcangeli
On Mon, Feb 11, 2008 at 10:14:56AM +0200, Avi Kivity wrote: > What happens if you compile kvm against a kernel that doesn't have > linux/cmpxchg.h? > >> diff --git a/kernel/include/linux/anon_inodes.h >> b/kernel/include/linux/anon_inodes.h >> deleted file mode 100644 >> index b2e1ba3..000 >>

Re: [kvm-devel] Broken external module build on 2.6.23

2008-02-11 Thread Avi Kivity
Andrea Arcangeli wrote: > On Mon, Feb 04, 2008 at 04:01:31PM -0500, Chris Lalancette wrote: > >> Hello, >> The merge with upstream changeset: >> af5ca3f4ec5cc4432a42a73b050dd8898ce8fd00 >> broke building an external module against 2.6.23: >> >> CC [M] /root/kvm-userspace/kernel/kvm_main

Re: [kvm-devel] Broken external module build on 2.6.23

2008-02-05 Thread Andrea Arcangeli
On Mon, Feb 04, 2008 at 04:01:31PM -0500, Chris Lalancette wrote: > Hello, > The merge with upstream changeset: > af5ca3f4ec5cc4432a42a73b050dd8898ce8fd00 > broke building an external module against 2.6.23: > > CC [M] /root/kvm-userspace/kernel/kvm_main.o > /root/kvm-userspace/kernel/kvm_

[kvm-devel] Broken external module build on 2.6.23

2008-02-04 Thread Chris Lalancette
Hello, The merge with upstream changeset: af5ca3f4ec5cc4432a42a73b050dd8898ce8fd00 broke building an external module against 2.6.23: CC [M] /root/kvm-userspace/kernel/kvm_main.o /root/kvm-userspace/kernel/kvm_main.c:1271: error: unknown field ‘name’ specified in initializer Which makes se