Avi Kivity wrote:
> Zhang, Xiantao wrote:
>> According to privious decisions, mmu code should be moved to arch.
>> 
>>> From 43a629932b6babcbf2af75299192c1d77c2393d5 Mon Sep 17 00:00:00
>>> 2001 
>> From: Zhang Xiantao <[EMAIL PROTECTED]>

>> +            kvm_arch_set_memory_region(kvm, mem, user_alloc);
>> 
> 
> But 'old' does not longer exist here.  You recalculate it from
> kvm->memslots[] but the value is not longer identical to the 'old'
> value. 
> 
> Suggest changing this code not to rely on 'old' at all; instead
> recalculate nr_mmu_pages from kvm->memslots[] each time.  That will
> make the code more robust, enabling the movement later.

Good suggestion! I will introduce a function to handle it.

Xiantao

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Reply via email to