Re: [kvm-devel] RFC/patch portability: split kvm_vm_ioctl v2

2007-10-26 Thread Carsten Otte
Zhang, Xiantao wrote: > I don't think we can move the whole function to arch-specific part, > because it should work well (or with few issues) for most archs. > Basically, IA64 mostly can use it directly. If we move them as > arch-specific, it will introduces many duplicates. As you said, S390 has

Re: [kvm-devel] RFC/patch portability: split kvm_vm_ioctl v2

2007-10-26 Thread Carsten Otte
Izik Eidus wrote: > ok i was thinking, > maybe we can rewrite the way kvm hold memory so more code would be shared, > lets say we throw away all the slots and arch depended stuff, and we let kvm > just hold the userspace allocated memory address, > > then we will will have to each arch "arch speci

Re: [kvm-devel] RFC/patch portability: split kvm_vm_ioctl v2

2007-10-25 Thread Zhang, Xiantao
Carsten Otte wrote: > This patch splits kvm_vm_ioctl into archtecture independent parts, and > x86 specific parts which go to kvm_arch_vcpu_ioctl in x86.c. > > Common ioctls for all architectures are: > KVM_CREATE_VCPU, KVM_GET_DIRTY_LOG, KVM_SET_USER_MEMORY_REGION > > KVM_SET_USER_MEMORY_REGION

Re: [kvm-devel] RFC/patch portability: split kvm_vm_ioctl v2

2007-10-25 Thread Izik Eidus
Hollis Blanchard wrote: > On Thu, 2007-10-25 at 17:48 +0200, Izik Eidus wrote: > >> On Thu, 2007-10-25 at 17:48 +0200, Carsten Otte wrote: >> >>> This patch splits kvm_vm_ioctl into archtecture independent parts, and >>> x86 specific parts which go to kvm_arch_vcpu_ioctl in x86.c. >>> >>>

Re: [kvm-devel] RFC/patch portability: split kvm_vm_ioctl v2

2007-10-25 Thread Izik Eidus
On Thu, 2007-10-25 at 11:22 -0500, Hollis Blanchard wrote: > On Thu, 2007-10-25 at 17:48 +0200, Izik Eidus wrote: > > On Thu, 2007-10-25 at 17:48 +0200, Carsten Otte wrote: > > > This patch splits kvm_vm_ioctl into archtecture independent parts, and > > > x86 specific parts which go to kvm_arch_vcp

Re: [kvm-devel] RFC/patch portability: split kvm_vm_ioctl v2

2007-10-25 Thread Hollis Blanchard
On Thu, 2007-10-25 at 17:48 +0200, Izik Eidus wrote: > On Thu, 2007-10-25 at 17:48 +0200, Carsten Otte wrote: > > This patch splits kvm_vm_ioctl into archtecture independent parts, and > > x86 specific parts which go to kvm_arch_vcpu_ioctl in x86.c. > > > > Common ioctls for all architectures are

Re: [kvm-devel] RFC/patch portability: split kvm_vm_ioctl v2

2007-10-25 Thread Izik Eidus
On Thu, 2007-10-25 at 17:48 +0200, Carsten Otte wrote: > This patch splits kvm_vm_ioctl into archtecture independent parts, and > x86 specific parts which go to kvm_arch_vcpu_ioctl in x86.c. > > Common ioctls for all architectures are: > KVM_CREATE_VCPU, KVM_GET_DIRTY_LOG, KVM_SET_USER_MEMORY_REG

[kvm-devel] RFC/patch portability: split kvm_vm_ioctl v2

2007-10-25 Thread Carsten Otte
This patch splits kvm_vm_ioctl into archtecture independent parts, and x86 specific parts which go to kvm_arch_vcpu_ioctl in x86.c. Common ioctls for all architectures are: KVM_CREATE_VCPU, KVM_GET_DIRTY_LOG, KVM_SET_USER_MEMORY_REGION KVM_SET_USER_MEMORY_REGION is actually implemented in x86.c