Re: [kvm-devel] add back pending timer irqs for kernel APIC timer

2007-08-25 Thread Avi Kivity
Dong, Eddie wrote: Avi Kivity wrote: Dong, Eddie wrote: Avi: Any comments to this patch? Seems not in yet. The sequence is apic-timer-TMCCT.patch, apic-timer-last5.patch and apic-timer-pending4.patch. thx,eddie I'd like to get guest smp in first...

Re: [kvm-devel] add back pending timer irqs for kernel APIC timer

2007-08-25 Thread Dong, Eddie
Avi Kivity wrote: Dong, Eddie wrote: Avi Kivity wrote: Dong, Eddie wrote: Avi: Any comments to this patch? Seems not in yet. The sequence is apic-timer-TMCCT.patch, apic-timer-last5.patch and apic-timer-pending4.patch. thx,eddie I'd like to get guest smp in first...

Re: [kvm-devel] add back pending timer irqs for kernel APIC timer

2007-08-24 Thread Dong, Eddie
Avi Kivity wrote: Dong, Eddie wrote: Avi: Any comments to this patch? Seems not in yet. The sequence is apic-timer-TMCCT.patch, apic-timer-last5.patch and apic-timer-pending4.patch. thx,eddie I'd like to get guest smp in first... Avi: We have got SMP Linux up too,

Re: [kvm-devel] add back pending timer irqs for kernel APIC timer

2007-08-19 Thread Avi Kivity
Dong, Eddie wrote: Avi: Any comments to this patch? Seems not in yet. The sequence is apic-timer-TMCCT.patch, apic-timer-last5.patch and apic-timer-pending4.patch. thx,eddie I'd like to get guest smp in first... -- error compiling committee.c: too many arguments to

Re: [kvm-devel] add back pending timer irqs for kernel APIC timer

2007-08-18 Thread Dong, Eddie
:25 To: Avi Kivity Cc: kvm-devel Subject: Re: [kvm-devel] add back pending timer irqs for kernel APIC timer Here are rebased and fixed patches, please check. thanks, eddie apic-timer-tmcct.patch Description: apic-timer-tmcct.patch apic-timer-last5.patch Description: apic-timer-last5.patch

Re: [kvm-devel] add back pending timer irqs for kernel APIC timer

2007-08-13 Thread Avi Kivity
Dong, Eddie wrote: Avi Kivity wrote: Dong, Eddie wrote: Add back pending irqs for apic timer to get precise guest APIC timer interrupt. Can you explain the problem and the solution in more detail? Today guest sleep 10 seconds only get about 5-6 seconds in

Re: [kvm-devel] add back pending timer irqs for kernel APIC timer

2007-08-13 Thread Avi Kivity
Dong, Eddie wrote: [EMAIL PROTECTED] wrote: Add back pending irqs for apic timer to get precise guestAPIC timer interrupt. Signed-off-by: Yaozu (Eddie) Dong [EMAIL PROTECTED] a typo, please use this one. With above patches, now guest timer is much accurate! sleep 60

Re: [kvm-devel] add back pending timer irqs for kernel APIC timer

2007-08-13 Thread Gregory Haskins
On Mon, 2007-08-13 at 11:50 +0300, Avi Kivity wrote: This patch keep track of the pending irqs and inject them back to guest eventually even the guest may be descheduled. This is also what we did in Xen. BTW, This policy will also be applied to future kernel PIT, I just do it step by

Re: [kvm-devel] add back pending timer irqs for kernel APIC timer

2007-08-13 Thread Dong, Eddie
Note that my old lapic branch did a similar tdf thing as well and it worked quite nicely, so I think Eddie is on the right track with adding this. I just copied the whole APIC timer stuff from your old patch at that time as TODO. maybe I missed something :-( Time virtualization has quit a

Re: [kvm-devel] add back pending timer irqs for kernel APIC timer

2007-08-13 Thread Dong, Eddie
Avi Kivity wrote: What does pt mean in this context? pending timer? Suggested descriptive names below. Periodic timer. Comments added. if (apic_lvtt_period(apic)) { -u32 offset; -u32 tmict = apic_get_reg(apic, APIC_TMICT); - -offset =

Re: [kvm-devel] add back pending timer irqs for kernel APIC timer

2007-08-13 Thread Dong, Eddie
[EMAIL PROTECTED] wrote: kvm_pt_update_irq is within intr_assist where host IRQ is disabled. It can be updated only after we return to guest. What if it runs on another cpu? This case will be forbidden in next patch. We need to remove apic-lock too. To avoid confuse, I mean hrtimer

Re: [kvm-devel] add back pending timer irqs for kernel APIC timer

2007-08-13 Thread Avi Kivity
Dong, Eddie wrote: Note that my old lapic branch did a similar tdf thing as well and it worked quite nicely, so I think Eddie is on the right track with adding this. I just copied the whole APIC timer stuff from your old patch at that time as TODO. maybe I missed something :-( Time

Re: [kvm-devel] add back pending timer irqs for kernel APIC timer

2007-08-13 Thread Avi Kivity
Dong, Eddie wrote: [EMAIL PROTECTED] wrote: kvm_pt_update_irq is within intr_assist where host IRQ is disabled. It can be updated only after we return to guest. What if it runs on another cpu? This case will be forbidden in next patch. We need to remove apic-lock too.

Re: [kvm-devel] add back pending timer irqs for kernel APIC timer

2007-08-13 Thread Dong, Eddie
Avi Kivity wrote: 2: stop hrtimer when the guest is descheduled to increase scalibility and remove apic-lock. Why is this important? An hrtimer is just an entry on a list, no? Does it need an IRQ to drive? If we have ten VMs, we got extra 10 IRQs. Do you mean, just if the guest is

Re: [kvm-devel] add back pending timer irqs for kernel APIC timer

2007-08-13 Thread Avi Kivity
Dong, Eddie wrote: Avi Kivity wrote: 2: stop hrtimer when the guest is descheduled to increase scalibility and remove apic-lock. Why is this important? An hrtimer is just an entry on a list, no? Does it need an IRQ to drive? If we have ten VMs, we got extra 10 IRQs.

Re: [kvm-devel] add back pending timer irqs for kernel APIC timer

2007-08-13 Thread Dong, Eddie
Here are rebased and fixed patches, please check. thanks, eddie commit 9b1a9ad955d9ac44ee6e60b4a565edf044d3dcc7 Author: root [EMAIL PROTECTED](none) Date: Fri Aug 10 22:38:59 2007 +0800 APIC_TMCCT is a dynamically running count which always need to be recalculated at the time it is

Re: [kvm-devel] add back pending timer irqs for kernel APIC timer

2007-08-10 Thread Dong, Eddie
[EMAIL PROTECTED] wrote: Add back pending irqs for apic timer to get precise guestAPIC timer interrupt. Signed-off-by: Yaozu (Eddie) Dong [EMAIL PROTECTED] a typo, please use this one. With above patches, now guest timer is much accurate! sleep 60 get exactly 60 seconds in

[kvm-devel] add back pending timer irqs for kernel APIC timer

2007-08-10 Thread Dong, Eddie
Add back pending irqs for apic timer to get precise guest APIC timer interrupt. Signed-off-by: Yaozu (Eddie) Dong [EMAIL PROTECTED] diff --git a/drivers/kvm/irq.h b/drivers/kvm/irq.h index ed6d20a..8867c82 100644 --- a/drivers/kvm/irq.h +++ b/drivers/kvm/irq.h @@ -110,7 +110,7

Re: [kvm-devel] add back pending timer irqs for kernel APIC timer

2007-08-10 Thread Avi Kivity
Dong, Eddie wrote: Add back pending irqs for apic timer to get precise guest APIC timer interrupt. Can you explain the problem and the solution in more detail? - This SF.net email is sponsored by: Splunk Inc.

Re: [kvm-devel] add back pending timer irqs for kernel APIC timer

2007-08-10 Thread Dong, Eddie
Avi Kivity wrote: Dong, Eddie wrote: Add back pending irqs for apic timer to get precise guest APIC timer interrupt. Can you explain the problem and the solution in more detail? Today guest sleep 10 seconds only get about 5-6 seconds in host time. A design philosiphy in various