Dong, Eddie wrote:
>> Well, the ioapic userspace patch removes some nonexistent code that I
>> assume the lapic userspace patch should have added.
>>
>>
> O, this is a temp hack added by in kernel PIC. Maybe the branch
> mismatch.
>
> Here is the resent one. The sequence is:
> lapic
>
> Well, the ioapic userspace patch removes some nonexistent code that I
> assume the lapic userspace patch should have added.
>
O, this is a temp hack added by in kernel PIC. Maybe the branch
mismatch.
Here is the resent one. The sequence is:
lapic
ioapic
hlt
thx,eddie
Dong, Eddie wrote:
> Avi Kivity wrote:
>
>> Dong, Eddie wrote:
>>
>>> Avi:
>>> This is the cleaned and branch check-in ready candidate patch
>>> for lapic based on previous cr8 patch.
>>> It needs the later ioapic patch to fully function.
>>>
>>>
>>>
>> Most of userspace part
Avi Kivity wrote:
> Dong, Eddie wrote:
>> Avi:
>> This is the cleaned and branch check-in ready candidate patch
>> for lapic based on previous cr8 patch.
>> It needs the later ioapic patch to fully function.
>>
>>
>
> Most of userspace part is missing.
>
??? I don't need the user side
Dong, Eddie wrote:
> Missed attachment. Here it is.
>
The userspace part doesn't apply, it needs the missing lapic userspace
patch.
--
Do not meddle in the internals of kernels, for they are subtle and quick to
panic.
Dong, Eddie wrote:
> Avi:
> This is the cleaned and branch check-in ready candidate patch
> for lapic based on previous cr8 patch.
> It needs the later ioapic patch to fully function.
>
>
Most of userspace part is missing.
--
Do not meddle in the internals of kernels, for they are
Dong, Eddie wrote:
> Missed attachment. Here it is.
>
Applied & pushed, thanks.
--
Do not meddle in the internals of kernels, for they are subtle and quick to
panic.
-
This SF.net email is sponsored by DB2 Express
Down
Dong, Eddie wrote:
> Avi:
> This is the cleaned and branch check-in ready candidate patch
> for lapic based on previous cr8 patch.
> It needs the later ioapic patch to fully function.
>
>
Applied. It misses a description and sign-off line. I invented a
description, but please supp
Dong, Eddie wrote:
> This patch is to wrap APIC base register and CR8 operation which can
> provide a unique API for user level irqchip and kernel irqchip.
> This is a preparation of merging lapic/ioapic patch.
>
>
Applied and pushed, thanks.
--
Do not meddle in the internals of kernels, for
Missed attachment. Here it is.
ioapic-30-4.user.patch
Description: ioapic-30-4.user.patch
ioapic-30-4.patch
Description: ioapic-30-4.patch
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE ve
This is the ioapic patch. With this on rebased lapic2 branch, Both
Win2003/Xp and Rhel5 works well.
Appreciate if this can be in the branch so that I can fully move to live
migration support.
thx,eddie
kernel apic/ioapic support
Signed-off-by: Yaozu (Eddie) Dong <[EMAIL PROTECTED]>
+unsigned long get_cr8(struct kvm_vcpu *vcpu)
+{
+ if (irqchip_in_kernel(vcpu->kvm))
+ return kvm_lapic_get_cr8(vcpu);
+ else
+ return vcpu->cr8;
+}
+EXPORT_SYMBOL_GPL(get_cr8);
>>> How about keep vcpu->cr8 even with kern
Dong, Eddie wrote:
>
>
>>> If guest is in hlt time, vcpu->guest_mode=0. (VM Exit always
>>>
>> clear this
>>
>>> one).
>>> BTW, even we give a redunadant IPI, it is just a minor performance
>>>
>> issue
>>
>>> only.
>>>
>> I think that Avi was looking for the ca
Dong, Eddie wrote:
> Avi:
> Most of the comments are fixed, but need to have a double check
> on several point of them. Can u have a look?
> Eddie
>
>
>
>
>>> +
>>> + switch (delivery_mode) {
>>> + case dest_LowestPrio:
>>>
>>>
>> Wierd constant. How about IOAPIC_DEST_LOWEST
>>
>>If guest is in hlt time, vcpu->guest_mode=0. (VM Exit always
>clear this
>>one).
>>BTW, even we give a redunadant IPI, it is just a minor performance
>issue
>>only.
>
>I think that Avi was looking for the call to
>wake_up_interruptible(&vcpu->wq);
>Maybe it's hard to realize the apic code p
>>> +static void vcpu_kick_intr(void *info)
>>> +{
>>> +#ifdef DEBUG
>>> + struct kvm_vcpu *vcpu = (struct kvm_vcpu *)info;
>>> + printk(KERN_DEBUG "vcpu_kick_intr %p \n", vcpu);
>>> +#endif
>>> +}
>>> +
>>> +void kvm_vcpu_kick(struct kvm_vcpu *vcpu)
>>> +{
>>> + int ipi_pcpu = vcpu->cpu;
>>>
Avi:
Most of the comments are fixed, but need to have a double check
on several point of them. Can u have a look?
Eddie
>> +
>> +switch (delivery_mode) {
>> +case dest_LowestPrio:
>>
>
>Wierd constant. How about IOAPIC_DEST_LOWEST_PRIO?
dest_LowestPrio is defined in native
Dong, Eddie wrote:
> Avi:
> Per our discussion, we will only support all user level irqchip
> or all kernel level irqchip.
> Here is the patch against lapic2 that passed RHEL5U test. Please give
> comments.
>
>
> thx,eddie
>
>
General comments:
- please split into a hlt patch, lapic p
Avi:
Per our discussion, we will only support all user level irqchip
or all kernel level irqchip.
Here is the patch against lapic2 that passed RHEL5U test. Please give
comments.
thx,eddie
diff --git a/drivers/kvm/Makefile b/drivers/kvm/Makefile
index 952dff3..b29651b 100644
--- a/d
19 matches
Mail list logo
