Re: [kvm-devel] migration with exec giving truncated images

2007-08-13 Thread Jim Paris
Uri Lublin wrote: There is still the mystery of different file sizes for different migration-exec commands, all files are valid saved image. It seems to me that some unmodified pages are being marked as dirty, and are being saved twice (and later loaded twice). I'm still chasing that. Hi

Re: [kvm-devel] migration with exec giving truncated images

2007-08-13 Thread Jim Paris
I wrote I looked into this a bit more and it seems that a big piece of migration.c is missing or broken. .. Am I missing something? Yes, I am. Sorry, I missed the qemu_live_savevm_state call, which saves the rest of the dirty pages, and explains why some migration images are larger than

Re: [kvm-devel] migration with exec giving truncated images

2007-08-09 Thread Uri Lublin
Thanks for the patches. There is still the mystery of different file sizes for different migration-exec commands, all files are valid saved image. It seems to me that some unmodified pages are being marked as dirty, and are being saved twice (and later loaded twice). I'm still chasing that.

Re: [kvm-devel] migration with exec giving truncated images

2007-08-08 Thread Uri Lublin
I've never encountered that problem. I haven't used exec migration protocol too many times though. I have not used libvirt too many times either. I'll look into it too. Thanks, Uri. Jim Paris wrote: I wrote: It's almost as if migrate_write() is being called after migrate_finish() ??

Re: [kvm-devel] migration with exec giving truncated images

2007-08-08 Thread Jim Paris
I think I've (finally!) tracked it down. See the attached patches. The main problem is this: when using -monitor pty, all incoming commands are terminated with CRLF even though they were sent with just LF, probably because of the pty layer somewhere. When qemu's readline gets CR and LF without

Re: [kvm-devel] migration with exec giving truncated images

2007-08-07 Thread Jim Paris
I wrote: It's almost as if migrate_write() is being called after migrate_finish() ?? Yes, I'm definitely seeing this -- migrate_finish followed by migrate_write, which causes a segfault (and explains my truncated images). Unfortunately I'm not at all familiar with this code, and all the qemu

Re: [kvm-devel] migration with exec giving truncated images

2007-08-03 Thread Jim Paris
I wrote: migrate exec:dd of=STATEFILE ... I was having trouble getting this to work (loading gave Migration failed rc=233) and discovered that not all of the data was being saved, probably because of some buffering/pipe issues. Actually, maybe that isn't the issue. I guess the migration

[kvm-devel] migration with exec giving truncated images

2007-08-02 Thread Jim Paris
http://kvm.qumranet.com/kvmwiki/Migration suggests to use stop migrate exec:dd of=STATEFILE to save an image that can be loaded later. I was having trouble getting this to work (loading gave Migration failed rc=233) and discovered that not all of the data was being saved, probably because