Re: [kvm-devel] [PATCH] disable clock before rebooting.

2008-03-07 Thread Glauber Costa
Avi Kivity wrote: > Glauber Costa wrote: >> as for kexec, it uses precisely the shutdown function, doesn't it? >> >> Or is it crash_shutdown? >> Humm, /me looks, and I think it's the later, right? >> > > Only on crash-triggered kexecs. It can also happen via sys_reboot(). > Which, it appears, g

Re: [kvm-devel] [PATCH] disable clock before rebooting.

2008-03-07 Thread Avi Kivity
Glauber Costa wrote: > as for kexec, it uses precisely the shutdown function, doesn't it? > > Or is it crash_shutdown? > Humm, /me looks, and I think it's the later, right? > Only on crash-triggered kexecs. It can also happen via sys_reboot(). Which, it appears, goes through machine_shutdown().

Re: [kvm-devel] [PATCH] disable clock before rebooting.

2008-03-07 Thread Avi Kivity
Glauber Costa wrote: >> >> Why not go all the way and to _restart the same way? >> > Because it got a parameter, and doing it in the same macro would make > my beautiful macros ugly. > Using another one, to pass the argument, didn't seem justifiable to > me, since there were just one of its kind.

Re: [kvm-devel] [PATCH] disable clock before rebooting.

2008-03-07 Thread Glauber Costa
Avi Kivity wrote: > Glauber Costa wrote: >> This patch writes 0 (actually, what really matters is that the >> LSB is cleared) to the system time msr before rebooting/shutting down >> the machine. >> >> Without it, we can have a random memory location being written >> when the guest comes back >>

Re: [kvm-devel] [PATCH] disable clock before rebooting.

2008-03-07 Thread Glauber Costa
Avi Kivity wrote: > Glauber Costa wrote: >> This patch writes 0 (actually, what really matters is that the >> LSB is cleared) to the system time msr before rebooting/shutting down >> the machine. >> >> Without it, we can have a random memory location being written >> when the guest comes back >> >>

Re: [kvm-devel] [PATCH] disable clock before rebooting.

2008-03-07 Thread Avi Kivity
Glauber Costa wrote: > This patch writes 0 (actually, what really matters is that the > LSB is cleared) to the system time msr before rebooting/shutting down > the machine. > > Without it, we can have a random memory location being written > when the guest comes back > if (!kvm_para_available

Re: [kvm-devel] [PATCH] disable clock before rebooting.

2008-03-07 Thread Avi Kivity
Glauber Costa wrote: > This patch writes 0 (actually, what really matters is that the > LSB is cleared) to the system time msr before rebooting/shutting down > the machine. > > Without it, we can have a random memory location being written > when the guest comes back > > Signed-off-by: Glauber Cost