RE: [Qemu-devel] [PATCH 4/7] kvm: Add sanity checks to slot management

2009-04-29 Thread Liu Yu-B13201
> -Original Message- > From: Jan Kiszka [mailto:jan.kis...@siemens.com] > Sent: Thursday, April 30, 2009 1:31 AM > To: Hollis Blanchard > Cc: Liu Yu-B13201; qemu-de...@nongnu.org; kvm-ppc@vger.kernel.org > Subject: Re: [Qemu-devel] [PATCH 4/7] kvm: Add sanity checks > to slot managemen

Re: [Qemu-devel] [PATCH 4/7] kvm: Add sanity checks to slot management

2009-04-29 Thread Blue Swirl
On 4/29/09, Hollis Blanchard wrote: > On Wed, 2009-04-29 at 12:38 -0500, Anthony Liguori wrote: > > Hollis Blanchard wrote: > > > On Wed, 2009-04-29 at 12:38 +0200, Jan Kiszka wrote: > > > > > >> What is the alignment of those regions then? None? And do regions of > > >> different types overl

Re: [Qemu-devel] [PATCH 4/7] kvm: Add sanity checks to slot management

2009-04-29 Thread Jan Kiszka
Hollis Blanchard wrote: > On Wed, 2009-04-29 at 19:30 +0200, Jan Kiszka wrote: >> Hollis Blanchard wrote: >>> On Wed, 2009-04-29 at 12:38 +0200, Jan Kiszka wrote: Liu Yu-B13201 wrote: >> -Original Message- >> From: qemu-devel-bounces+yu.liu=freescale@nongnu.org >> [mai

Re: [Qemu-devel] [PATCH 4/7] kvm: Add sanity checks to slot management

2009-04-29 Thread Hollis Blanchard
On Wed, 2009-04-29 at 12:38 -0500, Anthony Liguori wrote: > Hollis Blanchard wrote: > > On Wed, 2009-04-29 at 12:38 +0200, Jan Kiszka wrote: > > > >> What is the alignment of those regions then? None? And do regions of > >> different types overlap even on the same page? Maybe the check reveals >

Re: [Qemu-devel] [PATCH 4/7] kvm: Add sanity checks to slot management

2009-04-29 Thread Anthony Liguori
Hollis Blanchard wrote: On Wed, 2009-04-29 at 12:38 +0200, Jan Kiszka wrote: What is the alignment of those regions then? None? And do regions of different types overlap even on the same page? Maybe the check reveals some deeper conflict /wrt KVM. Can you point me to the involved code files?

Re: [Qemu-devel] [PATCH 4/7] kvm: Add sanity checks to slot management

2009-04-29 Thread Hollis Blanchard
On Wed, 2009-04-29 at 19:30 +0200, Jan Kiszka wrote: > Hollis Blanchard wrote: > > On Wed, 2009-04-29 at 12:38 +0200, Jan Kiszka wrote: > >> Liu Yu-B13201 wrote: > -Original Message- > From: qemu-devel-bounces+yu.liu=freescale@nongnu.org > [mailto:qemu-devel-bounces+yu.l

Re: [Qemu-devel] [PATCH 4/7] kvm: Add sanity checks to slot management

2009-04-29 Thread Jan Kiszka
Hollis Blanchard wrote: > On Wed, 2009-04-29 at 12:38 +0200, Jan Kiszka wrote: >> Liu Yu-B13201 wrote: -Original Message- From: qemu-devel-bounces+yu.liu=freescale@nongnu.org [mailto:qemu-devel-bounces+yu.liu=freescale@nongnu.org] On Behalf Of Jan Kiszka S

Re: [Qemu-devel] [PATCH 4/7] kvm: Add sanity checks to slot management

2009-04-29 Thread Hollis Blanchard
On Wed, 2009-04-29 at 12:38 +0200, Jan Kiszka wrote: > Liu Yu-B13201 wrote: > > > >> -Original Message- > >> From: qemu-devel-bounces+yu.liu=freescale@nongnu.org > >> [mailto:qemu-devel-bounces+yu.liu=freescale@nongnu.org] > >> On Behalf Of Jan Kiszka > >> Sent: Sunday, April 12,

Re: qemu-kvm.git now live

2009-04-29 Thread Jan Kiszka
Avi Kivity wrote: > Jan Kiszka wrote: >>> If migration disables dirty memory logging, it must keep the vga logging >>> enabled, and vice versa. >>> >> >> So we need some notifier callbacks on slot changes so that all users can >> re-enable dirty logging after the update as required. > > Simp

Re: [PATCH 04/04] qemu-kvm: other archs should maintain memory mapping also.

2009-04-29 Thread Jes Sorensen
> "Avi" == Avi Kivity writes: Avi> Zhang, Xiantao wrote: >> From d184d9b0a91ca674961000ed3d35b7fc25d29e03 Mon Sep 17 00:00:00 >> 2001 From: Xiantao Zhang Date: Tue, 28 >> Apr 2009 16:59:36 +0800 Subject: [PATCH] qemu-kvm: other archs >> should maintain memory mapping also. Currently, use TA

Re: [PATCH 04/04] qemu-kvm: other archs should maintain memory mapping also.

2009-04-29 Thread Jes Sorensen
Avi Kivity wrote: Hollis, does this work for you? If now, you can add a new define KVM_WANT_MAPPING or something, and define it for I386 and IA64. Hi, This is the one implementing the KVM_WANT_MAPPING change. Cheers, Jes Introduce KVM_WANT_MAPPING define to switch on mapping code, instea

Re: Re: [PATCH 04/04] qemu-kvm: other archs should maintain memory mapping also.

2009-04-29 Thread Jes Sorensen
Avi Kivity wrote: Currently, use TARGET_I386 to comment out the mapping machanism for other archs, but mapping machanism should be useful for other archs to maintain guest's memory mapping. Hollis, does this work for you? If now, you can add a new define KVM_WANT_MAPPING or something, and de

Re: qemu-kvm.git now live

2009-04-29 Thread Avi Kivity
Jan Kiszka wrote: If migration disables dirty memory logging, it must keep the vga logging enabled, and vice versa. So we need some notifier callbacks on slot changes so that all users can re-enable dirty logging after the update as required. Simpler to do reference counting. When a us

Re: [Qemu-devel] [PATCH 4/7] kvm: Add sanity checks to slot management

2009-04-29 Thread Jan Kiszka
Liu Yu-B13201 wrote: >> -Original Message- >> From: Jan Kiszka [mailto:jan.kis...@siemens.com] >> Sent: Wednesday, April 29, 2009 6:38 PM >> To: Liu Yu-B13201 >> Cc: qemu-de...@nongnu.org; kvm-ppc@vger.kernel.org >> Subject: Re: [Qemu-devel] [PATCH 4/7] kvm: Add sanity checks >> to slot m

Re: qemu-kvm.git now live

2009-04-29 Thread Jan Kiszka
Avi Kivity wrote: > Jan Kiszka wrote: >>> I'm unhappy with both qemu.git and qemu-kvm.git memory slot management; >>> qemu-kvm.git is clumsy, and qemu.git is too simplistic (for example, it >>> ignores the fact that dirty logging is a global resource with multiple >>> users). >>> >> >> Don't g

Re: qemu-kvm.git now live

2009-04-29 Thread Avi Kivity
Jan Kiszka wrote: I'm unhappy with both qemu.git and qemu-kvm.git memory slot management; qemu-kvm.git is clumsy, and qemu.git is too simplistic (for example, it ignores the fact that dirty logging is a global resource with multiple users). Don't get your point yet. Can you name a concrete

RE: [Qemu-devel] [PATCH 4/7] kvm: Add sanity checks to slot management

2009-04-29 Thread Liu Yu-B13201
> -Original Message- > From: Jan Kiszka [mailto:jan.kis...@siemens.com] > Sent: Wednesday, April 29, 2009 6:38 PM > To: Liu Yu-B13201 > Cc: qemu-de...@nongnu.org; kvm-ppc@vger.kernel.org > Subject: Re: [Qemu-devel] [PATCH 4/7] kvm: Add sanity checks > to slot management > > Liu Yu-B13201

Re: qemu-kvm.git now live

2009-04-29 Thread Jan Kiszka
Avi Kivity wrote: > Jan Kiszka wrote: >> Avi Kivity wrote: >> >>> After a lengthy testing phase, qemu-kvm.git has replaced >>> kvm-userspace.git as the source repository for kvm userspace >>> development. >>> >>> Differences from kvm-userspace.git are as follows: >>> - everything under qemu/ has

Re: qemu-kvm.git now live

2009-04-29 Thread Avi Kivity
Jan Kiszka wrote: Avi Kivity wrote: After a lengthy testing phase, qemu-kvm.git has replaced kvm-userspace.git as the source repository for kvm userspace development. Differences from kvm-userspace.git are as follows: - everything under qemu/ has been moved to the top-level directory - every

Re: [Qemu-devel] [PATCH 4/7] kvm: Add sanity checks to slot management

2009-04-29 Thread Jan Kiszka
Liu Yu-B13201 wrote: > >> -Original Message- >> From: qemu-devel-bounces+yu.liu=freescale@nongnu.org >> [mailto:qemu-devel-bounces+yu.liu=freescale@nongnu.org] >> On Behalf Of Jan Kiszka >> Sent: Sunday, April 12, 2009 1:20 AM >> To: qemu-de...@nongnu.org >> Subject: [Qemu-devel]

RE: [Qemu-devel] [PATCH 4/7] kvm: Add sanity checks to slot management

2009-04-29 Thread Liu Yu-B13201
> -Original Message- > From: qemu-devel-bounces+yu.liu=freescale@nongnu.org > [mailto:qemu-devel-bounces+yu.liu=freescale@nongnu.org] > On Behalf Of Jan Kiszka > Sent: Sunday, April 12, 2009 1:20 AM > To: qemu-de...@nongnu.org > Subject: [Qemu-devel] [PATCH 4/7] kvm: Add sanity

Re: qemu-kvm.git now live

2009-04-29 Thread Jan Kiszka
Avi Kivity wrote: > After a lengthy testing phase, qemu-kvm.git has replaced > kvm-userspace.git as the source repository for kvm userspace development. > > Differences from kvm-userspace.git are as follows: > - everything under qemu/ has been moved to the top-level directory > - everything not un

Re: qemu-kvm.git now live

2009-04-29 Thread Avi Kivity
Hollis Blanchard wrote: Since PPC is now supported in upstream QEMU, does it really matter if it works in qemu-kvm.git? I was going to take that position too, except Avi asked me specifically if some of the code inside TARGET_I386 ifdefs in qemu-kvm.c works for other architectures. I

Re: qemu-kvm.git now live

2009-04-29 Thread Avi Kivity
Hollis Blanchard wrote: On Thu, 2009-04-23 at 18:40 +0300, Avi Kivity wrote: Still missing: - I have not tested powerpc or ia64. Patches welcome! This repository seems pretty messed up; I'm not even sure what you want from me. Some of the bigger problems: * configure completely