Re: [PATCH 3/6] KVM: PPC: booke: Check for MSR[WE] in prepare_to_enter

2011-11-14 Thread Scott Wood
On 11/14/2011 12:01 PM, Alexander Graf wrote: > > On 14.11.2011, at 18:22, Scott Wood wrote: > >> kvmppc_core_check_exceptions can clear MSR_WE, so we need to check after >> that. We can't enable interrupts after kvmppc_core_check_exceptions (or >> rather, if we do, we need to check again once

Re: [PATCH 3/6] KVM: PPC: booke: Check for MSR[WE] in prepare_to_enter

2011-11-14 Thread Alexander Graf
On 14.11.2011, at 18:22, Scott Wood wrote: > On 11/14/2011 07:13 AM, Alexander Graf wrote: >> On 11/09/2011 01:23 AM, Scott Wood wrote: >>> +/* Check pending exceptions and deliver one, if possible. */ >>> +void kvmppc_core_prepare_to_enter(struct kvm_vcpu *vcpu) >>> +{ >>> +WARN_ON_ONCE(!ir

Re: [PATCH 3/6] KVM: PPC: booke: Check for MSR[WE] in prepare_to_enter

2011-11-14 Thread Scott Wood
On 11/14/2011 07:13 AM, Alexander Graf wrote: > On 11/09/2011 01:23 AM, Scott Wood wrote: >> +/* Check pending exceptions and deliver one, if possible. */ >> +void kvmppc_core_prepare_to_enter(struct kvm_vcpu *vcpu) >> +{ >> +WARN_ON_ONCE(!irqs_disabled()); >> + >> +kvmppc_core_check_except

Re: [PATCH 3/6] KVM: PPC: booke: Check for MSR[WE] in prepare_to_enter

2011-11-14 Thread Alexander Graf
On 11/09/2011 01:23 AM, Scott Wood wrote: This prevents us from inappropriately blocking in a KVM_SET_REGS ioctl -- the MSR[WE] will take effect when the guest is next entered. It also causes SRR1[WE] to be set when we enter the guest's interrupt handler, which is what e500 hardware is documente