Re: [PATCH 16/17] KVM: PPC: MPIC: Add support for KVM_IRQ_LINE

2013-05-01 Thread Marcelo Tosatti
On Thu, Apr 25, 2013 at 11:13:40PM +0200, Alexander Graf wrote: On 25.04.2013, at 21:03, Scott Wood wrote: On 04/25/2013 09:49:23 AM, Alexander Graf wrote: On 25.04.2013, at 13:30, Alexander Graf wrote: On 19.04.2013, at 20:51, Scott Wood wrote: On 04/19/2013 09:06:27 AM,

Re: [PATCH 3/3] kvm: Fix obsolete comment about locking for kvm_io_bus_read/write

2013-05-01 Thread Alexander Graf
On 27.04.2013, at 02:53, Scott Wood wrote: Nobody is actually calling these functions with slots_lock held. The srcu read lock, OTOH, is required. Signed-off-by: Scott Wood scottw...@freescale.com Marcelo, could you please ack? Alex --- virt/kvm/kvm_main.c |4 ++-- 1 file changed,

Re: [PATCH 1/3] kvm/ppc/booke: Hold srcu lock when calling gfn functions

2013-05-01 Thread Marcelo Tosatti
On Fri, Apr 26, 2013 at 07:53:38PM -0500, Scott Wood wrote: KVM core expects arch code to acquire the srcu lock when calling gfn_to_memslot and similar functions. Signed-off-by: Scott Wood scottw...@freescale.com --- arch/powerpc/kvm/44x_tlb.c |5 + arch/powerpc/kvm/booke.c|

Re: [PATCH 1/3] kvm/ppc/booke: Hold srcu lock when calling gfn functions

2013-05-01 Thread Scott Wood
On 05/01/2013 07:15:53 PM, Marcelo Tosatti wrote: On Fri, Apr 26, 2013 at 07:53:38PM -0500, Scott Wood wrote: diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c index 1020119..506c87d 100644 --- a/arch/powerpc/kvm/booke.c +++ b/arch/powerpc/kvm/booke.c @@ -832,6 +832,8 @@ int

[PATCH -next] kvm/ppc/mpic: fix missing unlock in set_base_addr()

2013-05-01 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn Add the missing unlock before return from function set_base_addr() when disables the mapping. Introduced by commit 5df554ad5b7522ea62b0ff9d5be35183494efc21 (kvm/ppc/mpic: in-kernel MPIC emulation) Signed-off-by: Wei Yongjun