Re: [PATCH v12 2/6] KVM: Add generic support for dirty page logging

On 11/02/2014 07:01 PM, Takuya Yoshikawa wrote: > On Thu, 30 Oct 2014 12:19:00 -0700 > Mario Smarduch wrote: > >> On 10/30/2014 05:14 AM, Cornelia Huck wrote: >>> On Wed, 22 Oct 2014 15:34:07 -0700 >>> Mario Smarduch wrote: >>> This patch defines KVM_GENERIC_DIRTYLOG, and moves dirty log re

Re: [PATCH v12 2/6] KVM: Add generic support for dirty page logging

On 11/01/2014 03:12 AM, James Hogan wrote: > Hi Mario, > > On Wed, Oct 22, 2014 at 03:34:07PM -0700, Mario Smarduch wrote: >> +/** >> + * kvm_vm_ioctl_get_dirty_log - get and clear the log of dirty pages in a >> slot >> + * @kvm: kvm instance >> + * @log: slot id and address to which we copy the

Re: [RFC PATCH 1/4] vhost: add VHOST_VRING_F_BYTESWAP flag

On Wed, Oct 29, 2014 at 09:38:42AM +0100, Cédric Le Goater wrote: > The VHOST_VRING_F_BYTESWAP flag will be used by the host to byteswap > the vring data when the guest and the host have a different endian > order. > > Signed-off-by: Cédric Le Goater I don't think it's a good API. You should ask

Re: [RFC PATCH 4/4] vhost_net: byteswap virtio_net header

On Wed, Oct 29, 2014 at 09:38:45AM +0100, Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater This patch casts userspace pointers to void *, this is generally unsafe. In particular sparse will warn. > --- > drivers/vhost/net.c | 39 ++- > 1 file chang

Re: [RFC PATCH 0/4] vhost_net: support for cross endian guests

On Wed, Oct 29, 2014 at 09:38:41AM +0100, Cédric Le Goater wrote: > This patchset adds a VHOST_VRING_F_BYTESWAP flag to inform the host > to byteswap data of the vring when the guest and the host have a > different endian order. The flag is stored at initialization in an > attribute of the virti

Re: [RFC PATCH 3/4] vhost: byteswap virtqueue attributes

On Wed, 29 Oct 2014 09:38:44 +0100 Cédric Le Goater wrote: > The virtqueue structure shares a few attributes with the guest OS > which need to be byteswapped when the endian order of the host is > different. > > This patch uses the vq->byteswap attribute to decide whether to > byteswap or not da

Re: [RFC PATCH 2/4] vhost: add byteswap routines

On Wed, 29 Oct 2014 09:38:43 +0100 Cédric Le Goater wrote: > This patch adds a few helper routines around get_user and put_user > to ease byteswapping. > > Signed-off-by: Cédric Le Goater > --- > > I am not sure these routines belong to this file. There is room for > improvement to remove the

[PATCH] KVM: PPC: Book3S HV: ptes are big endian

When being restored from qemu, the kvm_get_htab_header are in native endian, but the ptes are big endian. This patch fixes restore on a KVM LE host. Qemu also needs a fix for this : http://lists.nongnu.org/archive/html/qemu-ppc/2014-11/msg8.html Signed-off-by: Cédric Le Goater Cc: Pau