Re: [PATCH] kvmppc_init_timing_stats: fix sleep with interrupts disabled

ut the lock makes it mutually exclusive per vcpu and should ensure it isn't running - by that it should be fine. Reviewed-by: Christian Ehrhardt Alex Signed-off-by: Scott Wood --- arch/powerpc/kvm/timing.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/arch/po

[PATCH] [PATCH] qemu: report issues causing the kvm probe to fail v2

# HG changeset patch # User Christian Ehrhardt # Date 1229347014 -3600 # Node ID c754b8806d756a19c57fc3b3e317bbe3c147d5ec # Parent f7dc67cd9b74c5d7ad322686e58325f879d93468 [PATCH] qemu: report issues causing the kvm probe to fail v2 From: Christian Ehrhardt *update to v2* It now reports all

[PATCH] [PATCH] kvm-userspace: ppc: fix compatfd build decision v2

# HG changeset patch # User Christian Ehrhardt # Date 1229345133 -3600 # Node ID b48b9d560f80037ab4e12eae128022622c7ccb34 # Parent 4b0ad05490115e4c6f31d2419c0e5b628040f90b [PATCH] kvm-userspace: ppc: fix compatfd build decision v2 From: Christian Ehrhardt qemu-kvm.c uses qemu_eventfd

Re: [PATCH 1 of 6] [PATCH] kvm-userspace: ppc: fix compatfd build decision

compatfd.c takes care if CONFIG_signalfd/CONFIG_eventfd are set. Therefore we can savely remove the makefile guard completely and just always build compatfd.c. This updated patch works for x86&powerpc with/without --disable-aio in my tests. It should appear on the list shortly. -- Grüsse / rega

[PATCH] [PATCH] kvm-userspace: gdb: fix new gdb function types

# HG changeset patch # User Christian Ehrhardt # Date 1229085659 -3600 # Node ID 37967a80a2757505488685aac135681945e6da91 # Parent f0ed33f14658fe91a14ec02501cb42d26e32f01f [PATCH] kvm-userspace: gdb: fix new gdb function types From: Christian Ehrhardt The types changed in the header but not

Re: [PATCH] [PATCH] qemu: ppc: kvm-userspace: KVM PowerPC support for qemu gdbstub

Hollis Blanchard wrote: On Thu, 2008-12-11 at 17:05 +0100, Jan Kiszka wrote: Hollis Blanchard wrote: On Thu, 2008-12-11 at 13:53 +0100, Christian Ehrhardt wrote: This is v2 as version one had a type in it occured when splitting patches. Mercurial somehow lost my changes to the

[PATCH] [PATCH] qemu: ppc: kvm-userspace: KVM PowerPC support for qemu gdbstub

# HG changeset patch # User Christian Ehrhardt <[EMAIL PROTECTED]> # Date 1228999833 -3600 # Node ID dc1466c9077ab162f4637fffee1869f26be02299 # Parent 4c07fe2a56c7653a9113e05bb08c2de9aec210ce [PATCH] qemu: ppc: kvm-userspace: KVM PowerPC support for qemu gdbstub From: Hollis Blanchard &

Re: [PATCH] [PATCH] qemu: ppc: kvm-userspace: KVM PowerPC support for qemu gdbstub

This is v2 as version one had a type in it occured when splitting patches. Mercurial somehow lost my changes to the patch description explaining that, but the patch is right this way. Christian Ehrhardt wrote: # HG changeset patch # User Christian Ehrhardt <[EMAIL PROTECTED]>

[PATCH 3 of 3] [PATCH] kvm-userspace: fix gdbstub kvm integration

# HG changeset patch # User Christian Ehrhardt <[EMAIL PROTECTED]> # Date 1228989958 -3600 # Node ID f80fb35de91fe69dae889c70948c9a53212ee444 # Parent 6f228c807ad0b239b7342d2974debfc66418d784 [PATCH] kvm-userspace: fix gdbstub kvm integration From: Christian Ehrhardt <[EMAIL PROTECTE

[PATCH 1 of 3] [PATCH] kvm-userspace: ppc: Add kvm_translate wrapper

# HG changeset patch # User Christian Ehrhardt <[EMAIL PROTECTED]> # Date 1228924564 -3600 # Node ID 38846cef16e56c681da1ddc179e248972c8b2ff9 # Parent 705d874ff7a24484eaa15ed75a748c4e1a70c2ef [PATCH] kvm-userspace: ppc: Add kvm_translate wrapper From: Hollis Blanchard <[EMAIL PROTECT

[PATCH 2 of 3] [PATCH] qemu: ppc: kvm-userspace: KVM PowerPC support for qemu gdbstub

# HG changeset patch # User Christian Ehrhardt <[EMAIL PROTECTED]> # Date 1228989956 -3600 # Node ID 6f228c807ad0b239b7342d2974debfc66418d784 # Parent 38846cef16e56c681da1ddc179e248972c8b2ff9 [PATCH] qemu: ppc: kvm-userspace: KVM PowerPC support for qemu gdbstub From: Hollis Blanchard &

[PATCH 0 of 3] update gdbstub support

This patch series updates the gdbstub support for kvm. Patch 1&2 introduce basic powerpc support while patch 3 fixes gdbstub generic code that was broken in a qemu merge. -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to [EMAIL PROTECTED] More majordo

kvm-userspace requires kvm capable kernel headers in default search path of the compiler

overlooked something and there is an even better or trivial approach :-) Since this could be solved several very different ways I think its worth a discussion. As I prefer b) I attached a simple patch example how this could look like :-). -- Grüsse / regards, Christian Ehrhardt IBM

[PATCH] [PATCH] kvm: powerpc: fix some whitespaces in kvm_ppc.h

From: Christian Ehrhardt <[EMAIL PROTECTED]> Fix some whitespaces in kvm_ppc.h Signed-off-by: Christian Ehrhardt <[EMAIL PROTECTED]> --- [diffstat] [diff] diff --git a/arch/powerpc/include/asm/kvm_ppc.h b/arch/powerpc/include/asm/kvm_ppc.h --- a/arch/powerpc/include/asm/kvm_ppc.

[PATCH] kvm: powerpc: add exit timing statistics v5

From: Christian Ehrhardt <[EMAIL PROTECTED]> *update to v5* - add exittiming.c to diff content - prefix all exit timing functions with kvmppc to prevent name collisions (was already done for some of the functions, now its consequently done for all of them) - renamed header &

Re: [PATCH] kvm: powerpc: add exit timing statistics v4

Hollis Blanchard wrote: On Tue, 2008-11-11 at 16:43 +0100, Christian Ehrhardt wrote: From: Christian Ehrhardt <[EMAIL PROTECTED]> *update to v4* - EMUL_CORE no longer had more than wrtee emulation, therefore it now accounts for WRTEE in the output and set_exit_type calls are in the

[PATCH] kvm: powerpc: add exit timing statistics v4

From: Christian Ehrhardt <[EMAIL PROTECTED]> *update to v4* - EMUL_CORE no longer had more than wrtee emulation, therefore it now accounts for WRTEE in the output and set_exit_type calls are in the wrtee handlers to let any residual core op be counted as EMULINST" *update to v

[PATCH] kvm: powerpc: add exit timing statistics v3

From: Christian Ehrhardt <[EMAIL PROTECTED]> *update to v3* - ensure build time optimization when calling exit accouting functions using build time bug / constant check - migrate most of the exit timing code from powerpc.c and kvm_timing_stats.h to a separate exittiming.c file - renamed

Re: [PATCH] kvm: powerpc: add exit timing statistics v3

And btw - the wiki page is updated with new versions of the exittimings using all of our new memory management improvements. The page now also has some extended descriptions about the simple workloads used, holds the current version of the postprocessing script etc. Christian Ehrhardt wrote

[PATCH] kvm: powerpc: add exit timing statistics v3

From: Christian Ehrhardt <[EMAIL PROTECTED]> *update to v3* - ensure build time optimization when calling exit accouting functions using build time bug / constant check - migrate most of the exit timing code from powerpc.c and kvm_timing_stats.h to a separate exittiming.c file - renamed

[PATCH] kvm: powerpc: add exit timing statistics v2

From: Christian Ehrhardt <[EMAIL PROTECTED]> *resend with header file in diff* *update to v2* The update fixes accounting for sets to MSR[WE] which should not be accoutned as instruction emulation. While adding that and analyzing the data it became obvious that several types of emulations

Re: [PATCH] [mq]: fix-kvm-init.diff

59,10 +2959,8 @@ env->cpu_model_str = cpu_model; cpu_ppc_register_internal(env, def); cpu_ppc_reset(env); -#ifdef USE_KVM if (kvm_enabled()) - kvm_init_new_ap(env->cpu_index, env); -#endif + kvm_init_vcpu(env); return env; } -- Grüsse / regards, Christi

Re: Exit timing - results online

Hollis Blanchard wrote: On Thu, 2008-11-06 at 12:25 +0100, Christian Ehrhardt wrote: Hi, I just added the following page to our wiki based online documentation to show some numbers on kvmppc as of today. You can find that page at thew wiki entry: PowerPC_Exittimings <h

Exit timing - results online

e yet. I think I add some explanations and theories why you can see which effect there once I chatted with a few involved people. I welcome everyone to discuss with us on the list about that too. -- Grüsse / regards, Christian Ehrhardt IBM Linux Technology Center, Open Virtualization -- To

Re: [PATCH] [PATCH] kvm: powerpc: add exit timing statistics

f(" avg %16.4lf stddev %12.3lf %% %5.2f\n",$9/$3, sqrt($11/$3-(($9/$3)*($9/$3))), ($9/('$sumsum'/100))); }' $1 This runs awk twice, because for % of overall time you need the sum the durations and I personally don't like all those "rewind hacks" for awk

Re: [PATCH 0 of 7] kvm-userspace: support multiple processors in the same architecture

c :-) I know you started with the arch-platform-os-compiler after our discussion, but I like the $PROCESSOR solution for our *powerpc* Makefiles too. And a good catch with that AR usage in patch 7. (full series) Acked-by: Christian Ehrhardt <[EMAIL PROTECTED]> -- Grüsse / regards, Chri

Re: [PATCH 03 of 10] [PATCH] user: ppc: better error reporting in load_file

nchard <[EMAIL PROTECTED]> This patch adds a better error reporting for powerpc testcases. It prints the bytes read in load_file so far until an error occured. Signed-off-by: Hollis Blanchard <[EMAIL PROTECTED]> Signed-off-by: Christian Ehrhardt <[EMAIL PROTECTED]> --- [dif

Re: [PATCH 0/3] kvm-userspace: ppc: userspace fixes for powerpc

single patch I just submitted while cleaning our userspace repo to get the missing things upstream. Avi, let me know if I confused you and I'll send them once again with some time in between to order them easier. [EMAIL PROTECTED] wrote: From: Christian Ehrhardt <[EMAIL PROTECTED]>

Re: [PATCH] kvm: external module: fix unifdef problem

/\#include/! s/\blapic\b/l_apic/g' > $1 && rm $1.orig +unifdef_uflags = $(foreach arch, $(NONARCH_CONFIG), -UCONFIG_$(arch)) $(patsubst ...), or even $(NONARCH_CONFIG:%=-UCONFIG_%) But I think NONARCH_CONFIG needs to be adjusted as well. -- Grüsse / regards, Christ

Re: [PATCH 1 of 3] user: ppc: add stub nmi handler

Further checks later - it was in our repo with a different name not upstream. I'll submit it together with the rest of the backlog we have in our queue. Christian Ehrhardt wrote: I already wrote and brought that one upstream. It is in the repo as kvmppc-add-kvm_arch_try_push_nmi.diff and

Re: [PATCH 0 of 3] userspace updates

7;s not fully featured but should work right ? -- Grüsse / regards, Christian Ehrhardt IBM Linux Technology Center, Open Virtualization -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://v

Re: [PATCH 1 of 3] user: ppc: add stub nmi handler

indow = test_io_window, .try_push_interrupts = test_try_push_interrupts, + .try_push_nmi = test_try_push_nmi, .post_kvm_run = test_post_kvm_run, .pre_kvm_run = test_pre_kvm_run, .powerpc_dcr_read = test_dcr_read, -- Grüsse / regards, Christian Ehrhardt IBM Linux T

Patch to increase the number of tlb entries a guest uses

such a change would be to our shadow tlb management. -- Grüsse / regards, Christian Ehrhardt IBM Linux Technology Center, Open Virtualization -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to [EMAIL PROTECTED] More majordomo inf

Re: [PATCH 1/3] kvmppc: optimize irq delivery path

Hollis Blanchard wrote: On Fri, 2008-10-10 at 12:59 +0200, [EMAIL PROTECTED] wrote: From: Christian Ehrhardt <[EMAIL PROTECTED]> In kvmppc_deliver_interrupt is just one case left in the switch and it is a rare one (less than 8%) when looking at the exit numbers. Therefore we can at

exit timing analysis - optimizations v1

Grüsse / regards, Christian Ehrhardt IBM Linux Technology Center, Open Virtualization -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: exit timing analysis v1 - comments&discussions welcome

ases like DTLVVIRT, ITLBVIRT and EMULINST we are at ~2.75%. Therefore it should be ok to keep the generic find_next_bit there. -- Grüsse / regards, Christian Ehrhardt IBM Linux Technology Center, Open Virtualization -- To unsubscribe from this list: send the line "unsubscribe kvm-pp

Re: exit timing analysis v1 - comments&discussions welcome

ough). This code has to be touched anyway when going for a change in the guest/host (shadow)TLB management. Christian Ehrhardt wrote: I modified the code according to your comments and my ideas, the new values are shown in column impISF (irq delivery, Stat, FindFirstBit) I changed some code of

Re: exit timing analysis v1 - comments&discussions welcome

should be worth to look into that section once again more in detail first. Christian Ehrhardt wrote: Hollis Blanchard wrote: On Wed, 2008-10-08 at 15:49 +0200, Christian Ehrhardt wrote: Wondering about that 30.5% for postprocessing and kvmppc_check_and_deliver_interrupts I quickly checked that

Re: exit timing analysis v1 - comments&discussions welcome

Hollis Blanchard wrote: On Wed, 2008-10-08 at 15:49 +0200, Christian Ehrhardt wrote: Wondering about that 30.5% for postprocessing and kvmppc_check_and_deliver_interrupts I quickly checked that in detail - part d is now divided in 4 subparts. I also looked at the return to guest path if the

Re: exit timing analysis v1 - comments&discussions welcome

is worth to try it :-) Now I go for the TLB replacement in f1. Christian Christian Ehrhardt wrote: As intended I separated the time of one of our exits into it's segments to see where we loose the constant base time. I looked at the syscall exit which is pretty fast and does not deviate very

Re: exit timing analysis v1 - comments&discussions welcome

dated. Christian Christian Ehrhardt wrote: Today I refactored my code in a way that it might eventually get upstream. That means I removed some debug blocks, made it configurable and print output only on request per sysrq. Feel free to review that code now, otherwise wait for my separate rfc

Re: exit timing analysis v1 - comments&discussions welcome

csum8680180 sumsum 92206510 => ~1:32 runtime sumavg 4610325 Hollis Blanchard wrote: On Thu, 2008-09-25 at 17:32 +0800, Liu Yu-B13201 wrote: On Wed, 2008-09-24 at 11:24

Re: [Qemu-devel] [PATCH 2/3] kvm-userspace: kvmppc: fix hostlonbits detection when cross compiling v2

malc wrote: On Tue, 30 Sep 2008, [EMAIL PROTECTED] wrote: From: Christian Ehrhardt <[EMAIL PROTECTED]> *update* further debugging according to some requests revealed that ARCH_CFLAGS does not contain all CFLAGS that might be needed, especially those supplied via extra-cflags. The

exit timing analysis v1 - comments&discussions welcome

r hit USR_PR_INST, HALT, DEBUG -- Grüsse / regards, Christian Ehrhardt IBM Linux Technology Center, Open Virtualization diff --git a/arch/powerpc/kernel/asm-offsets.c b/arch/powerpc/kernel/asm-offsets.c --- a/arch/powerpc/kernel/asm-offsets.c +++ b/arch/powerpc/kernel/asm-offsets.c

Re: [PATCH 3/6] kvmppc: rewrite guest code - sprg0-3

Liu Yu-B13201 wrote: -Original Message- From: Christian Ehrhardt [mailto:[EMAIL PROTECTED] Sent: Monday, September 01, 2008 8:15 PM To: Liu Yu-B13201 Cc: kvm-ppc@vger.kernel.org; [EMAIL PROTECTED] Subject: Re: [PATCH 3/6] kvmppc: rewrite guest code - sprg0-3

Re: [PATCH 3/6] kvmppc: rewrite guest code - sprg0-3

: Christian Ehrhardt <[EMAIL PROTECTED]> This patch adds the functionality of rewriting guest code using the magic page mechanism. If a paravirtual guest memory (magic page) is registered the host rewrites trapping emulations instead of emulating them. This only works with instructions th

Re: [PATCH 3/6] kvmppc: rewrite guest code - sprg0-3

guest code - sprg0-3 From: Christian Ehrhardt <[EMAIL PROTECTED]> This patch adds the functionality of rewriting guest code using the magic page mechanism. If a paravirtual guest memory (magic page) is registered the host rewrites trapping emulations instead of emulating them. This only

Re: [PATCH 4/4] kvmppc: convert wrteei to wrtee as kvm guest optimization

ntioned (maybe a bit too hidden) in the [0/4] mail of this series. -- Grüsse / regards, Christian Ehrhardt IBM Linux Technology Center, Open Virtualization -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to [EMAIL PROTECTED] Mor

Re: [PATCH 4/4] add e500 support for kvm

| 88 +++- arch/powerpc/kvm/powerpc.c |4 + arch/powerpc/kvm/powerpc.h |4 + 11 files changed, 261 insertions(+), 12 deletions(-) [...] -- Grüsse / regards, Christian Ehrhardt IBM Linux Technology Center, Open Virtualization -- To unsubscribe from this list: s

Re: [PATCH 2/4] add e500 tlb implementation

t_tlb_tlbsel(const struct kvm_vcpu *vcpu) +{ + return (vcpu->arch.mas0 >> 28) & 0x3; +} + +static inline unsigned int get_tlb_nv(const struct kvm_vcpu *vcpu) +{ + return vcpu->arch.mas0 & 0xfff; +} + +static inline unsigned int get_tlb_esel(const struct kvm_vcpu *vcpu) +{ +

Re: [PATCH 4/4] kvmppc: convert wrteei to wrtee as kvm guest optimization

Kumar Gala wrote: On Aug 19, 2008, at 5:36 AM, [EMAIL PROTECTED] wrote: From: Christian Ehrhardt <[EMAIL PROTECTED]> Dependent on the already existing CONFIG_KVM_GUEST config option this patch changes wrteei to wrtee allowing the hypervisor to rewrite those to nontrapping instru

Re: [PATCH 4/4] kvmppc: convert wrteei to wrtee as kvm guest optimization

mon system to be sure. -- Grüsse / regards, Christian Ehrhardt IBM Linux Technology Center, Open Virtualization -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/6] kvmppc: magic page hypercall - host part

ings break) we can fix that. This is bringing me back to our discussion that I wanted to have a "migration starts to run on new host" hook. I need to look for that. I think we need to put a little more thought into all the corner cases here. yeah, lets do that in a brainstorm session

Re: [PATCH 3/6] kvmppc: rewrite guest code - sprg0-3

27;re passing pcpage to kunmap_atomic() instead of pcaddr.) damn - stepped in my own trap ;-) thanks for the hint - fixed -- Grüsse / regards, Christian Ehrhardt IBM Linux Technology Center, Open Virtualization -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" i

Re: [PATCH 4/4] kvmppc: convert wrteei to wrtee as kvm guest optimization

in two parts one for the overhead free optimizations and on for the rest that might add some complexity for non virtualized execution (like this one). Signed-off-by: Christian Ehrhardt <[EMAIL PROTECTED]> How significant is the performance impact of this change for non-virtualized s

Re: [PATCH 2/4] kvmppc: add hypercall infrastructure - guest part

hange it atm. When we discussed about that I was too new to the power architecture to really get all the details, but I assume Hollis and Jimi can answer you that. -- Grüsse / regards, Christian Ehrhardt IBM Linux Technology Center, Open Virtualization -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Serial stdio overwhelming interrupts

65535 /* * We default to IRQ0 for the "no irq" hack. Some Best Regards. Yu N�r��y���b�X��ǧv�^�)޺{.n�+jir)���w*jg����ݢj/���z�ޖ��2�ޙ���&�)ߡ�a�����G���h��j:+v���w�٥ -- Grüsse / regards, Christian Ehrhardt IBM Linux Technology Center, Open Virtualization

Re: [PATCH 4 of 5] kvm: ppc: Write only modified shadow entries into theTLB on exit

Liu Yu wrote: -Original Message- From: Christian Ehrhardt [mailto:[EMAIL PROTECTED] Sent: Monday, August 11, 2008 7:48 PM To: Liu Yu Cc: Hollis Blanchard; kvm-ppc@vger.kernel.org Subject: Re: [PATCH 4 of 5] kvm: ppc: Write only modified shadow entries into theTLB on exit When you

Re: [PATCH 4 of 5] kvm: ppc: Write only modified shadow entries into theTLB on exit

Liu Yu wrote: -Original Message- From: Christian Ehrhardt [mailto:[EMAIL PROTECTED] Sent: Monday, August 11, 2008 4:33 PM To: Liu Yu Cc: Hollis Blanchard; kvm-ppc@vger.kernel.org Subject: Re: [PATCH 4 of 5] kvm: ppc: Write only modified shadow entries into theTLB on exit Liu Yu

Re: [PATCH 4 of 5] kvm: ppc: Write only modified shadow entries into theTLB on exit

mean the loop to clear up to the hwater mark where this patch makes changes and not this patch itself? -- Grüsse / regards, Christian Ehrhardt IBM Linux Technology Center, Open Virtualization -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message

Re: [PATCH 0 of 5] PowerPC patches for 2.6.27

gt; > > By the way, I will be on vacation for a few weeks starting Monday, but > > Christian Ehrhardt should be able to take care of any technical issues. > > Applied all; thanks. I prefer to only merge bug fixes at this time for > 2.6.27. As far as I can tell, patch 2 is independ

Re: [PATCH 5 of 5] kvm: powerpc: Map guest userspace with TID=0 mappings

be working fine. > > > > The net is that we don't need to flush the TLB on privilege > > switches, but we do on guest context switches (which are far > > more infrequent). Guest boot time performance improvement: about 30%. > > -- Grüsse / regards, Christi