Re: Please add my kvm-ppc-next branch to linux-next

2015-09-08 Thread Stephen Rothwell
g list, * reviewed by you (or another maintainer of your subsystem tree), * successfully unit tested, and * destined for the current or next Linux merge window. Basically, this should be just what you would send to Linus (or ask him to fetch). It is allowed to be rebased if you deem

Re: Please add my kvm-ppc-next branch to linux-next

2015-09-07 Thread Stephen Rothwell
; intended to go into 4.3, and I won't put in any commits for 4.4 until > 4.3-rc1 is out. I notice that this has now been merged into the kvm tree, so I will not bother adding your tree until tomorrow. -- Cheers, Stephen Rothwells...@canb.auug.org.au -- To unsubscribe

Re: [PATCH 3/8] vfio: add external user support

2013-06-27 Thread Stephen Rothwell
> + > + BUG_ON(filep->f_op != &vfio_group_fops); We usually reserve BUG_ON for situations where there is no way to continue running or continuing will corrupt the running kernel. Maybe WARN_ON() and return? -- Cheers, Stephen Rothwells...@canb.auug.org.au

Re: [PATCH 3/8] vfio: add external user support

2013-06-26 Thread Stephen Rothwell
ser); You cannot EXPORT a static symbol ... The same through the rest of the file. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpv4zCGfMNC4.pgp Description: PGP signature

Re: [PATCH 3/6 v5] powerpc: export debug registers save function for KVM

2013-06-26 Thread Stephen Rothwell
endif We usually don't bother guarding function declarations. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpkE_3z91GtM.pgp Description: PGP signature

Re: [PATCH] BUILD_BUG_ON: make it handle more cases

2009-11-04 Thread Stephen Rothwell
t this is caused by the "MAYBE_BUILD_BUG_ON(fbit >= 32)" in virtio_has_feature() (in include/linux/virtio_config.h) which is called all over the place. Unfortunately, virtio_has_feature() gets uninlined in those two files ... I have taken the patch back out again for today. --

Re: [PATCH 20/27] Split init_new_context and destroy_context

2009-10-30 Thread Stephen Rothwell
n void set_context(unsigned long id, pgd_t *pgd); > > #ifdef CONFIG_PPC_BOOK3S_64 > +extern int __init_new_context(void); > +extern void __destroy_context(int context_id); > +#endif > + > +#ifdef CONFIG_PPC_BOOK3S_64 don't add the #endif/#ifdef pair ... -- C

Re: [PATCH 19/27] Export symbols for KVM module

2009-10-30 Thread Stephen Rothwell
_ticks_per_jiffy); Since you are moving this anyway, how about moving it into arch/powerpc/kernel/time.c where tb_ticks_per_jiffy is defined. -- Cheers, Stephen Rothwells...@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ pgpP7R01gfhSi.pgp Description: PGP signature

linux-next: tree build failure

2009-09-23 Thread Stephen Rothwell
integer constant Presumably caused by commit 8c87df457cb58fe75b9b893007917cf8095660a0 ("BUILD_BUG_ON(): fix it and a couple of bogus uses of it"). I applied the following patch for today. This inline function is only called from one place in one file ... From: Stephen Rothwell Date: Thu, 24 Sep 2009 15:13:2

[PATCH] powerpc/kvm: fix some init/exit annotations

2009-06-01 Thread Stephen Rothwell
function kvmppc_booke_exit() has valid usage outside the exit section and the fix is to remove the __exit annotation of kvmppc_booke_exit. Also add some __init annotations on obvious routines. Signed-off-by: Stephen Rothwell --- arch/powerpc/kvm/44x.c |4 ++-- arch/powerpc/kvm/booke.c |2