Re: [PATCH 1/2] ppc64: Rudimentary Support for extra page sizes on server CPUs

2012-06-19 Thread Alexander Graf
On 19.06.2012, at 07:56, Benjamin Herrenschmidt wrote: > More recent Power server chips (i.e. based on the 64 bit hash MMU) > support more than just the traditional 4k and 16M page sizes. This > can get quite complicated, because which page sizes are supported, > which combinations are supported

[PATCH 1/2] ppc64: Rudimentary Support for extra page sizes on server CPUs

2012-06-18 Thread Benjamin Herrenschmidt
More recent Power server chips (i.e. based on the 64 bit hash MMU) support more than just the traditional 4k and 16M page sizes. This can get quite complicated, because which page sizes are supported, which combinations are supported within an MMU segment and how these page sizes are encoded both

Re: [PATCH 1/2] ppc64: Rudimentary Support for extra page sizes on server CPUs

2012-05-10 Thread Benjamin Herrenschmidt
On Thu, 2012-05-10 at 20:55 +0300, Avi Kivity wrote: > On 05/10/2012 08:49 PM, Alexander Graf wrote: > >> +#if defined(TARGET_PPC64) > >> +if (def->sps) > >> +memcpy(&env->sps, def->sps, sizeof(*def->sps)); > > > > > > I never know if *def->... would dereference def or the complete > >

Re: [PATCH 1/2] ppc64: Rudimentary Support for extra page sizes on server CPUs

2012-05-10 Thread Avi Kivity
On 05/10/2012 08:49 PM, Alexander Graf wrote: >> +#if defined(TARGET_PPC64) >> +if (def->sps) >> +memcpy(&env->sps, def->sps, sizeof(*def->sps)); > > > I never know if *def->... would dereference def or the complete > construct. 'man operator' > How about sizeof(env->sps)? How about

Re: [PATCH 1/2] ppc64: Rudimentary Support for extra page sizes on server CPUs

2012-05-10 Thread Alexander Graf
On 04/27/2012 07:51 AM, Benjamin Herrenschmidt wrote: More recent Power server chips (i.e. based on the 64 bit hash MMU) support more than just the traditional 4k and 16M page sizes. This can get quite complicated, because which page sizes are supported, which combinations are supported within a

[PATCH 1/2] ppc64: Rudimentary Support for extra page sizes on server CPUs

2012-04-26 Thread Benjamin Herrenschmidt
More recent Power server chips (i.e. based on the 64 bit hash MMU) support more than just the traditional 4k and 16M page sizes. This can get quite complicated, because which page sizes are supported, which combinations are supported within an MMU segment and how these page sizes are encoded both