Re: [PATCH 3/4] drivers/vfio: New IOCTL command VFIO_EEH_INFO

2014-05-21 Thread Alexander Graf
Am 21.05.2014 um 02:23 schrieb Benjamin Herrenschmidt b...@kernel.crashing.org: On Tue, 2014-05-20 at 22:39 +1000, Gavin Shan wrote: Yeah. How about this? :-) - Move eeh-vfio.c to drivers/vfio/pci/ - From eeh-vfio.c, dereference arch/powerpc/kernel/eeh.c::eeh_ops, which is

Re: [PATCH 3/4] drivers/vfio: New IOCTL command VFIO_EEH_INFO

2014-05-21 Thread Benjamin Herrenschmidt
On Wed, 2014-05-21 at 08:23 +0200, Alexander Graf wrote: Note to Alex: This definitely kills the notifier idea for now though, at least as a first class citizen of the design. We can add it as an optional optimization on top later. I don't think it does. The notifier would just get

Re: [PATCH 3/4] drivers/vfio: New IOCTL command VFIO_EEH_INFO

2014-05-21 Thread Gavin Shan
On Wed, May 21, 2014 at 05:24:22PM +1000, Benjamin Herrenschmidt wrote: On Wed, 2014-05-21 at 08:23 +0200, Alexander Graf wrote: Note to Alex: This definitely kills the notifier idea for now though, at least as a first class citizen of the design. We can add it as an optional optimization

[PATCH 3/4] drivers/vfio: New IOCTL command VFIO_EEH_INFO

2014-05-20 Thread Gavin Shan
The patch adds new IOCTL command VFIO_EEH_OP to VFIO PCI device to support EEH functionality for PCI devices, which have been passed from host to guest via VFIO. Signed-off-by: Gavin Shan gws...@linux.vnet.ibm.com --- arch/powerpc/platforms/powernv/Makefile | 1 +

Re: [PATCH 3/4] drivers/vfio: New IOCTL command VFIO_EEH_INFO

2014-05-20 Thread Alexander Graf
On 20.05.14 10:30, Gavin Shan wrote: The patch adds new IOCTL command VFIO_EEH_OP to VFIO PCI device to support EEH functionality for PCI devices, which have been passed from host to guest via VFIO. Signed-off-by: Gavin Shan gws...@linux.vnet.ibm.com ---

Re: [PATCH 3/4] drivers/vfio: New IOCTL command VFIO_EEH_INFO

2014-05-20 Thread Gavin Shan
On Tue, May 20, 2014 at 01:28:40PM +0200, Alexander Graf wrote: On 20.05.14 13:21, Alexander Graf wrote: On 20.05.14 10:30, Gavin Shan wrote: The patch adds new IOCTL command VFIO_EEH_OP to VFIO PCI device to support EEH functionality for PCI devices, which have been passed from host to guest

Re: [PATCH 3/4] drivers/vfio: New IOCTL command VFIO_EEH_INFO

2014-05-20 Thread Alexander Graf
On 20.05.14 13:40, Gavin Shan wrote: On Tue, May 20, 2014 at 01:28:40PM +0200, Alexander Graf wrote: On 20.05.14 13:21, Alexander Graf wrote: On 20.05.14 10:30, Gavin Shan wrote: The patch adds new IOCTL command VFIO_EEH_OP to VFIO PCI device to support EEH functionality for PCI devices,

Re: [PATCH 3/4] drivers/vfio: New IOCTL command VFIO_EEH_INFO

2014-05-20 Thread Gavin Shan
On Tue, May 20, 2014 at 01:44:21PM +0200, Alexander Graf wrote: On 20.05.14 13:40, Gavin Shan wrote: On Tue, May 20, 2014 at 01:28:40PM +0200, Alexander Graf wrote: On 20.05.14 13:21, Alexander Graf wrote: On 20.05.14 10:30, Gavin Shan wrote: The patch adds new IOCTL command VFIO_EEH_OP to VFIO

Re: [PATCH 3/4] drivers/vfio: New IOCTL command VFIO_EEH_INFO

2014-05-20 Thread Alexander Graf
On 20.05.14 14:21, Gavin Shan wrote: On Tue, May 20, 2014 at 01:44:21PM +0200, Alexander Graf wrote: On 20.05.14 13:40, Gavin Shan wrote: On Tue, May 20, 2014 at 01:28:40PM +0200, Alexander Graf wrote: On 20.05.14 13:21, Alexander Graf wrote: On 20.05.14 10:30, Gavin Shan wrote: The patch

Re: [PATCH 3/4] drivers/vfio: New IOCTL command VFIO_EEH_INFO

2014-05-20 Thread Gavin Shan
On Tue, May 20, 2014 at 02:25:45PM +0200, Alexander Graf wrote: On 20.05.14 14:21, Gavin Shan wrote: On Tue, May 20, 2014 at 01:44:21PM +0200, Alexander Graf wrote: On 20.05.14 13:40, Gavin Shan wrote: On Tue, May 20, 2014 at 01:28:40PM +0200, Alexander Graf wrote: On 20.05.14 13:21, Alexander

Re: [PATCH 3/4] drivers/vfio: New IOCTL command VFIO_EEH_INFO

2014-05-20 Thread Benjamin Herrenschmidt
On Tue, 2014-05-20 at 14:25 +0200, Alexander Graf wrote: - Move eeh-vfio.c to drivers/vfio/pci/ - From eeh-vfio.c, dereference arch/powerpc/kernel/eeh.c::eeh_ops, which is arch/powerpc/plaforms/powernv/eeh-powernv.c::powernv_eeh_ops. Call Hrm, I think it'd be nicer to just export

Re: [PATCH 3/4] drivers/vfio: New IOCTL command VFIO_EEH_INFO

2014-05-20 Thread Benjamin Herrenschmidt
On Tue, 2014-05-20 at 22:39 +1000, Gavin Shan wrote: Yeah. How about this? :-) - Move eeh-vfio.c to drivers/vfio/pci/ - From eeh-vfio.c, dereference arch/powerpc/kernel/eeh.c::eeh_ops, which is arch/powerpc/plaforms/powernv/eeh-powernv.c::powernv_eeh_ops. Call Hrm, I think it'd be

Re: [PATCH 3/4] drivers/vfio: New IOCTL command VFIO_EEH_INFO

2014-05-20 Thread Gavin Shan
On Wed, May 21, 2014 at 10:23:52AM +1000, Benjamin Herrenschmidt wrote: On Tue, 2014-05-20 at 22:39 +1000, Gavin Shan wrote: Yeah. How about this? :-) - Move eeh-vfio.c to drivers/vfio/pci/ - From eeh-vfio.c, dereference arch/powerpc/kernel/eeh.c::eeh_ops, which is