Re: [PATCH 4/4] KVM: PPC: align vcpu_kick with x86

2011-12-23 Thread Benjamin Herrenschmidt
On Fri, 2011-12-23 at 13:56 +0100, Alexander Graf wrote: Hmm, unless smp_send_reschedule must be called with preemption disabled (doesn't seem like an obvious requirement, even if callers commonly have a reason to do so, and the only documentation of it I see is on the ia64

Re: [PATCH 4/4] KVM: PPC: align vcpu_kick with x86

2011-12-12 Thread Scott Wood
On 12/09/2011 05:15 PM, Alexander Graf wrote: On 09.12.2011, at 20:15, Scott Wood wrote: On 12/09/2011 01:10 PM, Alexander Graf wrote: On 09.12.2011, at 19:19, Scott Wood scottw...@freescale.com wrote: On 12/09/2011 09:26 AM, Alexander Graf wrote: Our vcpu kick implementation differs a

[PATCH 4/4] KVM: PPC: align vcpu_kick with x86

2011-12-09 Thread Alexander Graf
Our vcpu kick implementation differs a bit from x86 which resulted in us not disabling preemption during the kick. Get it a bit closer to what x86 does. Signed-off-by: Alexander Graf ag...@suse.de --- arch/powerpc/kvm/powerpc.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-)

Re: [PATCH 4/4] KVM: PPC: align vcpu_kick with x86

2011-12-09 Thread Alexander Graf
On 09.12.2011, at 19:19, Scott Wood scottw...@freescale.com wrote: On 12/09/2011 09:26 AM, Alexander Graf wrote: Our vcpu kick implementation differs a bit from x86 which resulted in us not disabling preemption during the kick. Get it a bit closer to what x86 does. Disabling preemption

Re: [PATCH 4/4] KVM: PPC: align vcpu_kick with x86

2011-12-09 Thread Scott Wood
On 12/09/2011 01:10 PM, Alexander Graf wrote: On 09.12.2011, at 19:19, Scott Wood scottw...@freescale.com wrote: On 12/09/2011 09:26 AM, Alexander Graf wrote: Our vcpu kick implementation differs a bit from x86 which resulted in us not disabling preemption during the kick. Get it a bit

Re: [PATCH 4/4] KVM: PPC: align vcpu_kick with x86

2011-12-09 Thread Alexander Graf
On 09.12.2011, at 20:15, Scott Wood wrote: On 12/09/2011 01:10 PM, Alexander Graf wrote: On 09.12.2011, at 19:19, Scott Wood scottw...@freescale.com wrote: On 12/09/2011 09:26 AM, Alexander Graf wrote: Our vcpu kick implementation differs a bit from x86 which resulted in us not