Re: [PATCH v12 2/6] KVM: Add generic support for dirty page logging

2014-11-06 Thread Mario Smarduch
On 11/06/2014 02:14 AM, Paolo Bonzini wrote: > > > On 06/11/2014 00:05, Mario Smarduch wrote: >> On 11/05/2014 08:09 AM, Paolo Bonzini wrote: >>> >>> >>> On 01/11/2014 11:12, James Hogan wrote: AFAICT all of the arch implementations of kvm_vm_ioctl_get_dirty_log() except x86 and ppc hv

Re: [PATCH v12 2/6] KVM: Add generic support for dirty page logging

2014-11-06 Thread Paolo Bonzini
On 06/11/2014 00:05, Mario Smarduch wrote: > On 11/05/2014 08:09 AM, Paolo Bonzini wrote: >> >> >> On 01/11/2014 11:12, James Hogan wrote: >>> AFAICT all of the arch implementations of kvm_vm_ioctl_get_dirty_log() >>> except x86 and ppc hv (i.e. ia60, mips, ppc pv, s390) already make use >>> of t

Re: [PATCH v12 2/6] KVM: Add generic support for dirty page logging

2014-11-05 Thread Mario Smarduch
On 11/05/2014 08:09 AM, Paolo Bonzini wrote: > > > On 01/11/2014 11:12, James Hogan wrote: >> AFAICT all of the arch implementations of kvm_vm_ioctl_get_dirty_log() >> except x86 and ppc hv (i.e. ia60, mips, ppc pv, s390) already make use >> of the existing generic function kvm_get_dirty_log() to

Re: [PATCH v12 2/6] KVM: Add generic support for dirty page logging

2014-11-05 Thread Paolo Bonzini
On 01/11/2014 11:12, James Hogan wrote: > AFAICT all of the arch implementations of kvm_vm_ioctl_get_dirty_log() > except x86 and ppc hv (i.e. ia60, mips, ppc pv, s390) already make use > of the existing generic function kvm_get_dirty_log() to help implement > their kvm_vm_ioctl_get_dirty_log fun

Re: [PATCH v12 2/6] KVM: Add generic support for dirty page logging

2014-11-03 Thread Mario Smarduch
On 11/02/2014 07:01 PM, Takuya Yoshikawa wrote: > On Thu, 30 Oct 2014 12:19:00 -0700 > Mario Smarduch wrote: > >> On 10/30/2014 05:14 AM, Cornelia Huck wrote: >>> On Wed, 22 Oct 2014 15:34:07 -0700 >>> Mario Smarduch wrote: >>> This patch defines KVM_GENERIC_DIRTYLOG, and moves dirty log re

Re: [PATCH v12 2/6] KVM: Add generic support for dirty page logging

2014-11-03 Thread Mario Smarduch
On 11/01/2014 03:12 AM, James Hogan wrote: > Hi Mario, > > On Wed, Oct 22, 2014 at 03:34:07PM -0700, Mario Smarduch wrote: >> +/** >> + * kvm_vm_ioctl_get_dirty_log - get and clear the log of dirty pages in a >> slot >> + * @kvm: kvm instance >> + * @log: slot id and address to which we copy the

Re: [PATCH v12 2/6] KVM: Add generic support for dirty page logging

2014-11-02 Thread Takuya Yoshikawa
On Thu, 30 Oct 2014 12:19:00 -0700 Mario Smarduch wrote: > On 10/30/2014 05:14 AM, Cornelia Huck wrote: > > On Wed, 22 Oct 2014 15:34:07 -0700 > > Mario Smarduch wrote: > > > >> This patch defines KVM_GENERIC_DIRTYLOG, and moves dirty log read function > >> to it's own file virt/kvm/dirtylog.c.

Re: [PATCH v12 2/6] KVM: Add generic support for dirty page logging

2014-11-01 Thread James Hogan
Hi Mario, On Wed, Oct 22, 2014 at 03:34:07PM -0700, Mario Smarduch wrote: > +/** > + * kvm_vm_ioctl_get_dirty_log - get and clear the log of dirty pages in a > slot > + * @kvm: kvm instance > + * @log: slot id and address to which we copy the log > + * > + * We need to keep it in mind that VCPU t

Re: [PATCH v12 2/6] KVM: Add generic support for dirty page logging

2014-10-30 Thread Mario Smarduch
On 10/30/2014 05:14 AM, Cornelia Huck wrote: > On Wed, 22 Oct 2014 15:34:07 -0700 > Mario Smarduch wrote: > >> This patch defines KVM_GENERIC_DIRTYLOG, and moves dirty log read function >> to it's own file virt/kvm/dirtylog.c. x86 is updated to use the generic >> dirty log interface, selecting KV

Re: [PATCH v12 2/6] KVM: Add generic support for dirty page logging

2014-10-30 Thread Cornelia Huck
On Wed, 22 Oct 2014 15:34:07 -0700 Mario Smarduch wrote: > This patch defines KVM_GENERIC_DIRTYLOG, and moves dirty log read function > to it's own file virt/kvm/dirtylog.c. x86 is updated to use the generic > dirty log interface, selecting KVM_GENERIC_DIRTYLOG in its Kconfig and > makefile. No

[PATCH v12 2/6] KVM: Add generic support for dirty page logging

2014-10-22 Thread Mario Smarduch
This patch defines KVM_GENERIC_DIRTYLOG, and moves dirty log read function to it's own file virt/kvm/dirtylog.c. x86 is updated to use the generic dirty log interface, selecting KVM_GENERIC_DIRTYLOG in its Kconfig and makefile. No other architectures are affected, each uses it's own version. This