Re: [PATCH v2] KVM: Clean up vm creation and release

2010-11-10 Thread Avi Kivity
On 11/10/2010 12:21 PM, Avi Kivity wrote: Indeed. Anyway, this wasn't intended (even more if some compiler versions/settings dislike it). Ok. I'll add the name and hope that this was the problem. Interestingly, ia64 and powerpc fail the build for unrelated reasons. -- error compiling comm

Re: [PATCH v2] KVM: Clean up vm creation and release

2010-11-10 Thread Alexander Graf
On 10.11.2010, at 11:21, Avi Kivity wrote: > On 11/10/2010 12:18 PM, Jan Kiszka wrote: >> Am 10.11.2010 10:45, Avi Kivity wrote: >> > On 11/10/2010 11:30 AM, Jan Kiszka wrote: >> >> Am 10.11.2010 10:17, Avi Kivity wrote: >> >>> On 11/09/2010 11:01 PM, Alexander Graf wrote: >> On 09.11.

Re: [PATCH v2] KVM: Clean up vm creation and release

2010-11-10 Thread Avi Kivity
On 11/10/2010 12:18 PM, Jan Kiszka wrote: Am 10.11.2010 10:45, Avi Kivity wrote: > On 11/10/2010 11:30 AM, Jan Kiszka wrote: >> Am 10.11.2010 10:17, Avi Kivity wrote: >>> On 11/09/2010 11:01 PM, Alexander Graf wrote: On 09.11.2010, at 17:02, Jan Kiszka wrote: >IA64 support

Re: [PATCH v2] KVM: Clean up vm creation and release

2010-11-10 Thread Avi Kivity
On 11/09/2010 11:01 PM, Alexander Graf wrote: On 09.11.2010, at 17:02, Jan Kiszka wrote: > IA64 support forces us to abstract the allocation of the kvm structure. > But instead of mixing this up with arch-specific initialization and > doing the same on destruction, split both steps. This allo

Re: [PATCH v2] KVM: Clean up vm creation and release

2010-11-10 Thread Jan Kiszka
Am 10.11.2010 10:45, Avi Kivity wrote: > On 11/10/2010 11:30 AM, Jan Kiszka wrote: >> Am 10.11.2010 10:17, Avi Kivity wrote: >>> On 11/09/2010 11:01 PM, Alexander Graf wrote: On 09.11.2010, at 17:02, Jan Kiszka wrote: > IA64 support forces us to abstract the allocation of the kvm

Re: [PATCH v2] KVM: Clean up vm creation and release

2010-11-10 Thread Jan Kiszka
Am 10.11.2010 10:17, Avi Kivity wrote: > On 11/09/2010 11:01 PM, Alexander Graf wrote: >> On 09.11.2010, at 17:02, Jan Kiszka wrote: >> >>> IA64 support forces us to abstract the allocation of the kvm structure. >>> But instead of mixing this up with arch-specific initialization and >>> doing th

Re: [PATCH v2] KVM: Clean up vm creation and release

2010-11-10 Thread Avi Kivity
On 11/10/2010 11:30 AM, Jan Kiszka wrote: Am 10.11.2010 10:17, Avi Kivity wrote: > On 11/09/2010 11:01 PM, Alexander Graf wrote: >> On 09.11.2010, at 17:02, Jan Kiszka wrote: >> >>> IA64 support forces us to abstract the allocation of the kvm structure. >>> But instead of mixing this up wit

Re: [PATCH v2] KVM: Clean up vm creation and release

2010-11-09 Thread Alexander Graf
On 09.11.2010, at 17:02, Jan Kiszka wrote: > IA64 support forces us to abstract the allocation of the kvm structure. > But instead of mixing this up with arch-specific initialization and > doing the same on destruction, split both steps. This allows to move > generic destruction calls into generi

[PATCH v2] KVM: Clean up vm creation and release

2010-11-09 Thread Jan Kiszka
IA64 support forces us to abstract the allocation of the kvm structure. But instead of mixing this up with arch-specific initialization and doing the same on destruction, split both steps. This allows to move generic destruction calls into generic code. It also fixes error clean-up on failures of