Re: [RFC PATCH v3 6/6] kvm/ppc/mpic: add KVM_CAP_IRQ_MPIC

2013-04-05 Thread Scott Wood
On 04/05/2013 01:09:50 AM, Alexander Graf wrote: Am 05.04.2013 um 00:35 schrieb Scott Wood : > On 04/04/2013 05:30:05 PM, Alexander Graf wrote: >> Am 04.04.2013 um 20:41 schrieb Scott Wood : >> > On 04/04/2013 07:54:20 AM, Alexander Graf wrote: >> >> On 03.04.2013, at 03:57, Scott Wood wrot

Re: [RFC PATCH v3 6/6] kvm/ppc/mpic: add KVM_CAP_IRQ_MPIC

2013-04-04 Thread Alexander Graf
Am 05.04.2013 um 00:35 schrieb Scott Wood : > On 04/04/2013 05:30:05 PM, Alexander Graf wrote: >> Am 04.04.2013 um 20:41 schrieb Scott Wood : >> > On 04/04/2013 07:54:20 AM, Alexander Graf wrote: >> >> On 03.04.2013, at 03:57, Scott Wood wrote: >> >> > +if (opp->mpic_mode_mask == GCR_MODE_PR

Re: [RFC PATCH v3 6/6] kvm/ppc/mpic: add KVM_CAP_IRQ_MPIC

2013-04-04 Thread Scott Wood
On 04/04/2013 05:30:05 PM, Alexander Graf wrote: Am 04.04.2013 um 20:41 schrieb Scott Wood : > On 04/04/2013 07:54:20 AM, Alexander Graf wrote: >> On 03.04.2013, at 03:57, Scott Wood wrote: >> > +if (opp->mpic_mode_mask == GCR_MODE_PROXY) >> Shouldn't this be an &? > > The way the mode fie

Re: [RFC PATCH v3 6/6] kvm/ppc/mpic: add KVM_CAP_IRQ_MPIC

2013-04-04 Thread Alexander Graf
Am 04.04.2013 um 20:41 schrieb Scott Wood : > On 04/04/2013 07:54:20 AM, Alexander Graf wrote: >> On 03.04.2013, at 03:57, Scott Wood wrote: >> > +if (opp->mpic_mode_mask == GCR_MODE_PROXY) >> Shouldn't this be an &? > > The way the mode field was originally documented was a two-bit field,

Re: [RFC PATCH v3 6/6] kvm/ppc/mpic: add KVM_CAP_IRQ_MPIC

2013-04-04 Thread Scott Wood
On 04/04/2013 07:54:20 AM, Alexander Graf wrote: On 03.04.2013, at 03:57, Scott Wood wrote: > + if (opp->mpic_mode_mask == GCR_MODE_PROXY) Shouldn't this be an &? The way the mode field was originally documented was a two-bit field, where 0b11 was external proxy, and 0b10 was reserved. I

Re: [RFC PATCH v3 6/6] kvm/ppc/mpic: add KVM_CAP_IRQ_MPIC

2013-04-04 Thread Alexander Graf
On 03.04.2013, at 03:57, Scott Wood wrote: > Enabling this capability connects the vcpu to the designated in-kernel > MPIC. Using explicit connections between vcpus and irqchips allows > for flexibility, but the main benefit at the moment is that it > simplifies the code -- KVM doesn't need vm-g

[RFC PATCH v3 6/6] kvm/ppc/mpic: add KVM_CAP_IRQ_MPIC

2013-04-02 Thread Scott Wood
Enabling this capability connects the vcpu to the designated in-kernel MPIC. Using explicit connections between vcpus and irqchips allows for flexibility, but the main benefit at the moment is that it simplifies the code -- KVM doesn't need vm-global state to remember which MPIC object is associat