Re: [PATCH 2/2 v2] KVM: PPC: booke: Add watchdog emulation

2012-07-17 Thread Alexander Graf
On 17.07.2012, at 03:02, Scott Wood scottw...@freescale.com wrote: On 07/16/2012 12:18 PM, Alexander Graf wrote: +/* + * Return the number of jiffies until the next timeout. If the timeout is + * longer than the NEXT_TIMER_MAX_DELTA, that then? return NEXT_TIMER_MAX_DELTA + *

RE: [PATCH 2/2 v2] KVM: PPC: booke: Add watchdog emulation

2012-07-17 Thread Bhushan Bharat-R65777
; Bhushan Bharat-R65777; Benjamin Herrenschmidt; Kumar Gala Subject: Re: [PATCH 2/2 v2] KVM: PPC: booke: Add watchdog emulation On 17.07.2012, at 03:02, Scott Wood scottw...@freescale.com wrote: On 07/16/2012 12:18 PM, Alexander Graf wrote: +/* + * Return the number of jiffies until

Re: [PATCH 2/2 v2] KVM: PPC: booke: Add watchdog emulation

2012-07-17 Thread Alexander Graf
; k...@vger.kernel.org; bharatb.ya...@gmail.com; Bhushan Bharat-R65777; Benjamin Herrenschmidt; Kumar Gala Subject: Re: [PATCH 2/2 v2] KVM: PPC: booke: Add watchdog emulation On 17.07.2012, at 03:02, Scott Wood scottw...@freescale.com wrote: On 07/16/2012 12:18 PM, Alexander Graf wrote

RE: [PATCH 2/2 v2] KVM: PPC: booke: Add watchdog emulation

2012-07-17 Thread Bhushan Bharat-R65777
; Benjamin Herrenschmidt; Kumar Gala; Avi Kivity Subject: Re: [PATCH 2/2 v2] KVM: PPC: booke: Add watchdog emulation On 07/17/2012 11:57 AM, Bhushan Bharat-R65777 wrote: -Original Message- From: kvm-ppc-ow...@vger.kernel.org [mailto:kvm-ppc-ow...@vger.kernel.org] On Behalf

Re: [PATCH 2/2 v2] KVM: PPC: booke: Add watchdog emulation

2012-07-17 Thread Alexander Graf
; k...@vger.kernel.org; bharatb.ya...@gmail.com; Benjamin Herrenschmidt; Kumar Gala; Avi Kivity Subject: Re: [PATCH 2/2 v2] KVM: PPC: booke: Add watchdog emulation On 07/17/2012 11:57 AM, Bhushan Bharat-R65777 wrote: -Original Message- From: kvm-ppc-ow...@vger.kernel.org [mailto:kvm-ppc-ow

RE: [PATCH 2/2 v2] KVM: PPC: booke: Add watchdog emulation

2012-07-17 Thread Bhushan Bharat-R65777
; Benjamin Herrenschmidt; Kumar Gala; Avi Kivity Subject: Re: [PATCH 2/2 v2] KVM: PPC: booke: Add watchdog emulation On 07/17/2012 03:15 PM, Bhushan Bharat-R65777 wrote: -Original Message- From: kvm-ppc-ow...@vger.kernel.org [mailto:kvm-ppc-ow...@vger.kernel.org] On Behalf

Re: [PATCH 2/2 v2] KVM: PPC: booke: Add watchdog emulation

2012-07-17 Thread Alexander Graf
; k...@vger.kernel.org; bharatb.ya...@gmail.com; Benjamin Herrenschmidt; Kumar Gala; Avi Kivity Subject: Re: [PATCH 2/2 v2] KVM: PPC: booke: Add watchdog emulation On 07/17/2012 03:15 PM, Bhushan Bharat-R65777 wrote: -Original Message- From: kvm-ppc-ow...@vger.kernel.org [mailto:kvm-ppc-ow

Re: [PATCH 2/2 v2] KVM: PPC: booke: Add watchdog emulation

2012-07-17 Thread Scott Wood
-R65777 Cc: Wood Scott-B07421; kvm-ppc@vger.kernel.org; k...@vger.kernel.org; bharatb.ya...@gmail.com; Benjamin Herrenschmidt; Kumar Gala; Avi Kivity Subject: Re: [PATCH 2/2 v2] KVM: PPC: booke: Add watchdog emulation On 07/17/2012 03:15 PM, Bhushan Bharat-R65777 wrote: -Original Message

Re: [PATCH 2/2 v2] KVM: PPC: booke: Add watchdog emulation

2012-07-17 Thread Alexander Graf
, 2012 7:31 PM To: Bhushan Bharat-R65777 Cc: Wood Scott-B07421; kvm-ppc@vger.kernel.org; k...@vger.kernel.org; bharatb.ya...@gmail.com; Benjamin Herrenschmidt; Kumar Gala; Avi Kivity Subject: Re: [PATCH 2/2 v2] KVM: PPC: booke: Add watchdog emulation On 07/17/2012 03:15 PM, Bhushan Bharat-R65777

RE: [PATCH 2/2 v2] KVM: PPC: booke: Add watchdog emulation

2012-07-17 Thread Bhushan Bharat-R65777
] KVM: PPC: booke: Add watchdog emulation On 07/17/2012 06:31 AM, Bhushan Bharat-R65777 wrote: int kvm_arch_vcpu_runnable(struct kvm_vcpu *v) { -return !(v-arch.shared-msr MSR_WE) || - !!(v-arch.pending_exceptions) || - v-requests; +bool ret = !(v

Re: [PATCH 2/2 v2] KVM: PPC: booke: Add watchdog emulation

2012-07-17 Thread Scott Wood
Herrenschmidt; Kumar Gala Subject: Re: [PATCH 2/2 v2] KVM: PPC: booke: Add watchdog emulation On 07/17/2012 06:31 AM, Bhushan Bharat-R65777 wrote: int kvm_arch_vcpu_runnable(struct kvm_vcpu *v) { -return !(v-arch.shared-msr MSR_WE) || - !!(v-arch.pending_exceptions

RE: [PATCH 2/2 v2] KVM: PPC: booke: Add watchdog emulation

2012-07-17 Thread Bhushan Bharat-R65777
...@vger.kernel.org; bharatb.ya...@gmail.com; Benjamin Herrenschmidt; Kumar Gala Subject: Re: [PATCH 2/2 v2] KVM: PPC: booke: Add watchdog emulation On 07/17/2012 06:31 AM, Bhushan Bharat-R65777 wrote: int kvm_arch_vcpu_runnable(struct kvm_vcpu *v) { -return !(v-arch.shared-msr MSR_WE

Re: [PATCH 2/2 v2] KVM: PPC: booke: Add watchdog emulation

2012-07-17 Thread Scott Wood
Herrenschmidt; Kumar Gala Subject: Re: [PATCH 2/2 v2] KVM: PPC: booke: Add watchdog emulation On 07/17/2012 11:56 AM, Bhushan Bharat-R65777 wrote: -Original Message- From: Wood Scott-B07421 Sent: Tuesday, July 17, 2012 10:08 PM To: Bhushan Bharat-R65777 Cc: Wood Scott-B07421

Re: [PATCH 2/2 v2] KVM: PPC: booke: Add watchdog emulation

2012-07-17 Thread Scott Wood
On 07/17/2012 11:51 AM, Alexander Graf wrote: On 07/17/2012 06:27 PM, Scott Wood wrote: Determining whether we're on final expiration is based only on the previous value of TSR[ENW,WIS] when the timer expires. We look at TCR to determine whether we need to actually exit to QEMU (as opposed to

Re: [PATCH 2/2 v2] KVM: PPC: booke: Add watchdog emulation

2012-07-16 Thread Scott Wood
On 07/16/2012 12:18 PM, Alexander Graf wrote: +/* + * Return the number of jiffies until the next timeout. If the timeout is + * longer than the NEXT_TIMER_MAX_DELTA, that then? return NEXT_TIMER_MAX_DELTA + * instead. I can read code. Come on, it's not exactly x++; /* add one to