Re: [PATCH v2] booke: Added ONE_REG interface for IAC/DAC debug registers

2012-07-24 Thread Alexander Graf
- R65777 Subject: Re: [PATCH v2] booke: Added ONE_REG interface for IAC/DAC debug registers On 07/23/2012 06:19 AM, Bharat Bhushan wrote: IAC/DAC are defined as 32 bit while they are 64 bit wide. So ONE_REG interface is added to set/get them. Signed-off-by: Bharat Bhushan bharat.bhus...@freescale.com

RE: [PATCH v2] booke: Added ONE_REG interface for IAC/DAC debug registers

2012-07-24 Thread Bhushan Bharat-R65777
+struct kvmppc_debug_reg { +#ifdef CONFIG_BOOKE + u32 dbcr0; + u32 dbcr1; + u32 dbcr2; +#ifdef CONFIG_KVM_E500MC + u32 dbcr4; +#endif + u64 iac[KVMPPC_MAX_IAC]; + u64 dac[KVMPPC_MAX_DAC]; +#endif +}; Is there any reason for this to be a

Re: [PATCH v2] booke: Added ONE_REG interface for IAC/DAC debug registers

2012-07-24 Thread Alexander Graf
On 07/24/2012 03:26 PM, Bhushan Bharat-R65777 wrote: +struct kvmppc_debug_reg { +#ifdef CONFIG_BOOKE + u32 dbcr0; + u32 dbcr1; + u32 dbcr2; +#ifdef CONFIG_KVM_E500MC + u32 dbcr4; +#endif + u64 iac[KVMPPC_MAX_IAC]; + u64 dac[KVMPPC_MAX_DAC]; +#endif +}; Is

Re: [PATCH v2] booke: Added ONE_REG interface for IAC/DAC debug registers

2012-07-23 Thread Scott Wood
On 07/23/2012 06:19 AM, Bharat Bhushan wrote: IAC/DAC are defined as 32 bit while they are 64 bit wide. So ONE_REG interface is added to set/get them. Signed-off-by: Bharat Bhushan bharat.bhus...@freescale.com --- v2: - Using copy_to/from_user() apis. arch/powerpc/include/asm/kvm.h

RE: [PATCH v2] booke: Added ONE_REG interface for IAC/DAC debug registers

2012-07-23 Thread Bhushan Bharat-R65777
-Original Message- From: Wood Scott-B07421 Sent: Monday, July 23, 2012 9:12 PM To: Bhushan Bharat-R65777 Cc: kvm-ppc@vger.kernel.org; ag...@suse.de; k...@vger.kernel.org; Bhushan Bharat- R65777 Subject: Re: [PATCH v2] booke: Added ONE_REG interface for IAC/DAC debug registers

Re: [PATCH v2] booke: Added ONE_REG interface for IAC/DAC debug registers

2012-07-23 Thread Scott Wood
: Added ONE_REG interface for IAC/DAC debug registers This will exceed the array size if userspace asks to access IAC3/4 on an e500- family chip. No , is not the array size already set to maximum. But yes we should not let IAC3/4 being accessed for e500 (FSL_BOOKE). Why not just set