Re: [PATCH v3 2/4] arm_gicv2m: Add GICv2m widget to support MSIs

2015-05-26 Thread Eric Auger
Reviewed-by: Eric Auger On 05/24/2015 12:51 PM, Christoffer Dall wrote: > The ARM GICv2m widget is a little device that handles MSI interrupt > writes to a trigger register and ties them to a range of interrupt lines > wires to the GIC. It has a few status/id registers and the interrupt wires, >

Re: [PATCH v3 1/4] target-arm: Add GIC phandle to VirtBoardInfo

2015-05-26 Thread Eric Auger
Reviewed-by: Eric Auger On 05/24/2015 12:51 PM, Christoffer Dall wrote: > Instead of passing the GIC phandle around between functions, add it to > the VirtBoardInfo just like we do for the clock_phandle. We are about > to add the v2m phandle as well, and it's easier not having to pass > around a

Re: [PATCH v3 3/4] target-arm: Extend the gic node properties

2015-05-26 Thread Eric Auger
Reviewed-by: Eric Auger only minor things below On 05/24/2015 12:51 PM, Christoffer Dall wrote: > From: Shanker Donthineni > > In preparation for adding the GICv2m which requires address specifiers > and is a subnode of the gic, we extend the gic DT definition to specify > the #address-cells a

Re: [PATCH v3 4/4] target-arm: Add the GICv2m to the virt board

2015-05-26 Thread Eric Auger
Reviewed-by: Eric Auger The only question I have is related to mid-term virt strategy about GICv3 integration. Are we going to reuse that memory map for the machine instantiating the GICv3? If yes, shouldn't we put the GICv2M somewhere else to leave space for GICv3 redistributors, assuming we reu

Re: [PATCH v3 4/4] target-arm: Add the GICv2m to the virt board

2015-05-26 Thread Peter Maydell
On 26 May 2015 at 13:54, Eric Auger wrote: > Reviewed-by: Eric Auger > > The only question I have is related to mid-term virt strategy about > GICv3 integration. Are we going to reuse that memory map for the machine > instantiating the GICv3? If yes, shouldn't we put the GICv2M somewhere > else t

Re: [PATCH v3 4/4] target-arm: Add the GICv2m to the virt board

2015-05-26 Thread Eric Auger
On 05/26/2015 02:55 PM, Peter Maydell wrote: > On 26 May 2015 at 13:54, Eric Auger wrote: >> Reviewed-by: Eric Auger >> >> The only question I have is related to mid-term virt strategy about >> GICv3 integration. Are we going to reuse that memory map for the machine >> instantiating the GICv3? If

Re: [PATCH v3 4/4] target-arm: Add the GICv2m to the virt board

2015-05-26 Thread Peter Maydell
On 26 May 2015 at 14:07, Eric Auger wrote: > On 05/26/2015 02:55 PM, Peter Maydell wrote: >> On 26 May 2015 at 13:54, Eric Auger wrote: >>> Reviewed-by: Eric Auger >>> >>> The only question I have is related to mid-term virt strategy about >>> GICv3 integration. Are we going to reuse that memory

RE: [Qemu-devel] [PATCH v3 4/4] target-arm: Add the GICv2m to the virt board

2015-05-26 Thread Pavel Fedin
Hi! My word... > What is your guidance, should we introduce new memory maps for GICv3 > enabled machine or should we move to a single dynamic memory map? IMHO there's no reason to introduce another memory map. I have already done test integration some time ago, and here is what i got: --- cut

Re: [Qemu-devel] [RFC/RFT PATCH v2 1/3] arm/arm64: pageattr: add set_memory_nc

2015-05-26 Thread Mario Smarduch
On 05/25/2015 10:11 AM, Andrew Jones wrote: > On Fri, May 22, 2015 at 06:08:30PM -0700, Mario Smarduch wrote: >> On 05/18/2015 08:53 AM, Catalin Marinas wrote: >>> On Thu, May 14, 2015 at 02:46:44PM +0100, Andrew Jones wrote: On Thu, May 14, 2015 at 01:05:09PM +0200, Christoffer Dall wrote: >>