RE: [PATCH v2 00/15] KVM: arm64: GICv3 ITS emulation

2015-07-15 Thread Pavel Fedin
Hello! > this respin tries to address all comments I got so far from the list. > Thanks to Eric, Pavel and Christoffer for the review! Tested-by: Pavel Fedin Works fine. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia __

RE: [PATCH v2 15/15] KVM: arm64: enable ITS emulation as a virtual MSI controller

2015-07-15 Thread Pavel Fedin
Hello! > But why would it need the capability to create models? Actually it doesn't. > The idea is to > check the capability before the actual KVM_SIGNAL_MSI or > KVM_SET_GSI_ROUTING ioctl (and cache that result). I have a function > with a static variable to do that, so it looks like: > > +

Re: [PATCH v2 15/15] KVM: arm64: enable ITS emulation as a virtual MSI controller

2015-07-15 Thread Andre Przywara
On 15/07/15 10:10, Pavel Fedin wrote: >> -Original Message- >> From: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] On Behalf >> Of Andre Przywara >> Sent: Friday, July 10, 2015 5:22 PM >> To: marc.zyng...@arm.com; christoffer.d...@linaro.org; >> kvmarm@lists.cs.columbia.edu

RE: [PATCH v2 15/15] KVM: arm64: enable ITS emulation as a virtual MSI controller

2015-07-15 Thread Pavel Fedin
Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia > -Original Message- > From: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] On Behalf > Of Andre Przywara > Sent: Friday, July 10, 2015 5:22 PM > To: marc.zyng...@arm.com; christoffer.d..

RE: [PATCH v2 4/7] KVM: arm/arm64: enable irqchip routing

2015-07-15 Thread Pavel Fedin
Hello! > >> + struct kvm_msi msi; > >> + > >> + msi.address_lo = e->msi.address_lo; > >> + msi.address_hi = e->msi.address_hi; > >> + msi.data = e->msi.data; > >> + if (e->type == KVM_IRQ_ROUTING_EXTENDED_MSI) { > >> + msi.devid = e->devid; > >> + msi.flags = KVM_MSI_VALID_