Re: [PATCH 3/3] KVM: ARM64: Fix guest dead loop when register accessor returns false

2016-01-13 Thread Marc Zyngier
On 13/01/16 09:16, Shannon Zhao wrote: > From: Shannon Zhao > > Currently emulate_cp will return 0 (Handled) no matter what the accessor > returns. If register accessor returns false, it will not skip current PC > while emulate_cp return handled. Then guest will stuck in

[PATCH 2/3] KVM: ARM64: Fix comments of the CP handler

2016-01-13 Thread Shannon Zhao
From: Shannon Zhao Signed-off-by: Shannon Zhao --- arch/arm64/kvm/sys_regs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c index eec3598..4048934 100644 ---

[PATCH 1/3] KVM: ARM64: Fix wrong use of the CPSR MODE mask

2016-01-13 Thread Shannon Zhao
From: Shannon Zhao The values of CPSR MODE mask are different between aarch32 and aarch64. It should use the right one according to the execution state. Signed-off-by: Shannon Zhao --- arch/arm64/include/asm/kvm_emulate.h | 8 ++-- 1 file

[PATCH 0/3] Three fixes for KVM ARM64

2016-01-13 Thread Shannon Zhao
From: Shannon Zhao These bugs are found when I test the 32 bit part of guest PMU patch set. Shannon Zhao (3): KVM: ARM64: Fix wrong use of the CPSR MODE mask KVM: ARM64: Fix comments of the CP handler KVM: ARM64: Fix guest dead loop when register accessor returns

Re: [PATCH 1/3] KVM: ARM64: Fix wrong use of the CPSR MODE mask

2016-01-13 Thread Marc Zyngier
On 13/01/16 09:16, Shannon Zhao wrote: > From: Shannon Zhao > > The values of CPSR MODE mask are different between aarch32 and aarch64. > It should use the right one according to the execution state. > > Signed-off-by: Shannon Zhao > --- >

Re: [PATCH 2/3] KVM: ARM64: Fix comments of the CP handler

2016-01-13 Thread Marc Zyngier
On 13/01/16 09:16, Shannon Zhao wrote: > From: Shannon Zhao > > Signed-off-by: Shannon Zhao > --- > arch/arm64/kvm/sys_regs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/kvm/sys_regs.c

Re: [PATCH V2 0/5] Enable ACPI support for KVM ARM

2016-01-13 Thread Graeme Gregory
Wei Huang redhat.com> writes: > > Initial ACPI support for ARM64 has been accepted into Linux kernel recently. > Now it is a good time to re-visit ACPI support for KVM. This patchset > enables ACPI for both arch_timer and vGIC by probing related ACPI tables > and does necessary

Re: [PATCH v6 1/6] arm/arm64: KVM: Introduce armv7 fp/simd vcpu fields and helpers

2016-01-13 Thread Mario Smarduch
On 1/12/2016 4:57 PM, Mario Smarduch wrote: > > > On 1/12/2016 6:12 AM, Christoffer Dall wrote: >> On Mon, Jan 11, 2016 at 03:39:21PM -0800, Mario Smarduch wrote: >>> >>> >>> On 1/10/2016 8:32 AM, Christoffer Dall wrote: Hi Mario, I spotted one more potential issue...

Re: [PATCH 1/3] KVM: ARM64: Fix wrong use of the CPSR MODE mask

2016-01-13 Thread Shannon Zhao
On 2016/1/13 17:31, Marc Zyngier wrote: > On 13/01/16 09:16, Shannon Zhao wrote: >> From: Shannon Zhao >> >> The values of CPSR MODE mask are different between aarch32 and aarch64. >> It should use the right one according to the execution state. >> >> Signed-off-by:

Re: [kvm-unit-tests PATCH 02/11] arm/pci: PCI bus scanning

2016-01-13 Thread Andrew Jones
On Sat, Jan 09, 2016 at 01:22:49PM +0100, Alexander Gordeev wrote: > Scan bus 0 and function 0 only for now > > Cc: Andrew Jones > Signed-off-by: Alexander Gordeev > --- > arm/pci-test.c | 4 +++ > lib/pci-host-generic.c | 67 >

Re: [PATCH 3/3] KVM: ARM64: Fix guest dead loop when register accessor returns false

2016-01-13 Thread Shannon Zhao
Marc Zyngier arm.com> writes: > Good catch again, but I'd rather approach this in a way that is similar > to the patch I posted last year, unifying some of the paths between > the 32 and 64 accesses (the code paths are really pointlessly different). > > I have the below patch, fully untested.

Re: [kvm-unit-tests PATCH 01/11] arm/pci: Device tree PCI probing

2016-01-13 Thread Andrew Jones
On Sat, Jan 09, 2016 at 01:22:48PM +0100, Alexander Gordeev wrote: > Cc: Andrew Jones > Signed-off-by: Alexander Gordeev > --- > arm/pci-test.c | 25 +++ > config/config-arm-common.mak | 5 +- > lib/alloc.c | 3 - >