Re: [PATCH v3 2/2] arm64: add micro test

2018-01-24 Thread Christoffer Dall
Hi Shih-Wei, On Fri, Jan 19, 2018 at 04:57:55PM -0500, Shih-Wei Li wrote: > Thanks for the feedback about the mistakes in math and some issues in > naming, print msg, and coding style. I'll be careful and try to avoid > the same problems the next patch set. Sorry for all of the confusion. > > So

Re: [PATCH v3 2/2] arm64: add micro test

2018-01-24 Thread Andrew Jones
On Wed, Jan 24, 2018 at 09:17:55AM +0100, Christoffer Dall wrote: > Hi Shih-Wei, > > On Fri, Jan 19, 2018 at 04:57:55PM -0500, Shih-Wei Li wrote: > > Thanks for the feedback about the mistakes in math and some issues in > > naming, print msg, and coding style. I'll be careful and try to avoid > >

Re: [PATCH v3 2/2] arm64: add micro test

2018-01-24 Thread Christoffer Dall
On Wed, Jan 24, 2018 at 09:30:28AM +0100, Andrew Jones wrote: > On Wed, Jan 24, 2018 at 09:17:55AM +0100, Christoffer Dall wrote: > > Hi Shih-Wei, > > > > On Fri, Jan 19, 2018 at 04:57:55PM -0500, Shih-Wei Li wrote: > > > Thanks for the feedback about the mistakes in math and some issues in > > >

Re: [PATCH v6 03/13] arm64: cpufeature: Detect CPU RAS Extentions

2018-01-24 Thread gengdongjiu
Hi James, Thanks for this mail. > Hi gengdongjiu, > > On 23/01/18 09:06, gengdongjiu wrote: > > On 2018/1/23 3:32, James Morse wrote: > >>> it seems this "CONFIG_ARM64_RAS_EXTN" is not enabled in the > >>> "arch/arm64/configs/defconfig", if not, I want to enable this config to > >>> enable RA

Re: [PATCH v3 14/41] KVM: arm64: Introduce VHE-specific kvm_vcpu_run

2018-01-24 Thread Dave Martin
On Fri, Jan 12, 2018 at 01:07:20PM +0100, Christoffer Dall wrote: > So far this is just a copy of the legacy non-VHE switch function, but we > will start reworking these functions in separate directions to work on > VHE and non-VHE in the most optimal way in later patches. I'd be concerned that no

Re: [PATCH v3 15/41] KVM: arm64: Remove kern_hyp_va() use in VHE switch function

2018-01-24 Thread Dave Martin
On Fri, Jan 12, 2018 at 01:07:21PM +0100, Christoffer Dall wrote: > VHE kernels run completely in EL2 and therefore don't have a notion of > kernel and hyp addresses, they are all just kernel addresses. Therefore > don't call kern_hyp_va() in the VHE switch function. Isn't this an example of avoi

Re: [PATCH v9 5/7] arm64: kvm: Introduce KVM_ARM_SET_SERROR_ESR ioctl

2018-01-24 Thread gengdongjiu
Hi James, Thanks a lot for your review and comments. > > Hi Dongjiu Geng, > > On 06/01/18 16:02, Dongjiu Geng wrote: > > The ARM64 RAS SError Interrupt(SEI) syndrome value is specific to the > > guest and user space needs a way to tell KVM this value. So we add a > > new ioctl. Before user sp

Re: [PATCH v3 2/2] arm64: add micro test

2018-01-24 Thread Shih-Wei Li
Hi Christoffer, In the previous patch, we did the avg and min/max altogether in a single function, in which we can skip the test (and output msg to tell the user about it) if its cost is smaller than 1 cnnfrq for more than X times. I think we can use two functions, one for "avg" and one for "minx